| Message ID | 20220610074459.3261383-2-andy.chiu@sifive.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a1f0161eadbd7941c09b5f4c6a210c390d2b86d6 |
| Headers | show |
| Series | Add simple PM operations to sifive-spi | expand |
On Fri, Jun 10, 2022 at 03:44:59PM +0800, Andy Chiu wrote: > +static int sifive_spi_suspend(struct device *dev) > +{ > + struct spi_master *master = dev_get_drvdata(dev); > + struct sifive_spi *spi = spi_master_get_devdata(master); > + int ret; > + > + ret = spi_master_suspend(master); > + if (ret) > + return ret; > + > + /* Disable all the interrupts just in case */ > + sifive_spi_write(spi, SIFIVE_SPI_REG_IE, 0); > + > + clk_disable_unprepare(spi->clk); Seems like the clock managemnet could usefully be done as runtime PM too? In any case, that can be done as an incremental change.
> Seems like the clock managemnet could usefully be done as runtime PM > too? In any case, that can be done as an incremental change. Thanks for the suggestion. We will work on it soon in the future.
On Fri, Jun 10, 2022 at 10:05 AM Andy Chiu <andy.chiu@sifive.com> wrote: > Missed changelog. > Signed-off-by: Andy Chiu <andy.chiu@sifive.com> > Reviewed-by: Greentime Hu <greentime.hu@sifive.com> > .driver = { > .name = SIFIVE_SPI_DRIVER_NAME, > + .pm = &sifive_spi_pm_ops, Missed pm_sleep_ptr(). Have you compiled it with CONFIG_PM_SLEEP=n? Have you got warnings of unused functions? > .of_match_table = sifive_spi_of_match, > },
diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c index f7c1e20432e0..e29e85cee88a 100644 --- a/drivers/spi/spi-sifive.c +++ b/drivers/spi/spi-sifive.c @@ -427,6 +427,44 @@ static int sifive_spi_remove(struct platform_device *pdev) return 0; } +static int sifive_spi_suspend(struct device *dev) +{ + struct spi_master *master = dev_get_drvdata(dev); + struct sifive_spi *spi = spi_master_get_devdata(master); + int ret; + + ret = spi_master_suspend(master); + if (ret) + return ret; + + /* Disable all the interrupts just in case */ + sifive_spi_write(spi, SIFIVE_SPI_REG_IE, 0); + + clk_disable_unprepare(spi->clk); + + return ret; +} + +static int sifive_spi_resume(struct device *dev) +{ + struct spi_master *master = dev_get_drvdata(dev); + struct sifive_spi *spi = spi_master_get_devdata(master); + int ret; + + ret = clk_prepare_enable(spi->clk); + if (ret) + return ret; + ret = spi_master_resume(master); + if (ret) + clk_disable_unprepare(spi->clk); + + return ret; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(sifive_spi_pm_ops, + sifive_spi_suspend, sifive_spi_resume); + + static const struct of_device_id sifive_spi_of_match[] = { { .compatible = "sifive,spi0", }, {} @@ -438,6 +476,7 @@ static struct platform_driver sifive_spi_driver = { .remove = sifive_spi_remove, .driver = { .name = SIFIVE_SPI_DRIVER_NAME, + .pm = &sifive_spi_pm_ops, .of_match_table = sifive_spi_of_match, }, };