| Message ID | 20220720201158.78068-3-nick.hawkins@hpe.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add SPI Driver to HPE GXP Architecture | expand |
On Wed, 20 Jul 2022 15:11:55 -0500, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Create documentation for the hpe,gxp-spifi binding to support access to > the SPI parts > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > --- > .../bindings/spi/hpe,gxp-spifi.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.example.dtb: spi@200: Unevaluated properties are not allowed ('interrupt-parrent' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 20/07/2022 22:11, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Create documentation for the hpe,gxp-spifi binding to support access to > the SPI parts > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > --- > .../bindings/spi/hpe,gxp-spifi.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml b/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml > new file mode 100644 > index 000000000000..015130ecf971 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/hpe,gxp-spifi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP spi controller flash interface > + > +maintainers: > + - Nick Hawkins <nick.hawkins@hpe.com> > + - Jean-Marie Verdun <verdun@hpe.com> > + > +allOf: > + - $ref: "spi-controller.yaml#" > + > +properties: > + compatible: > + const: hpe,gxp-spifi > + > + reg: > + items: > + - description: cfg registers > + - description: data registers > + - description: mapped memory > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + > + spi@200 { > + compatible = "hpe,gxp-spifi"; > + reg = <0x200 0x80>, <0xc000 0x100>, <0x38000000 0x800000>; > + interrupts = <20>; > + interrupt-parrent = <&vic0>; Wrong property. > + #address-cells = <1>; > + #size-cells = <0>; > + > + flash@0 { > + reg = < 0 >; Wrong indentation, no spaces for <. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml b/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml new file mode 100644 index 000000000000..015130ecf971 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/hpe,gxp-spifi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HPE GXP spi controller flash interface + +maintainers: + - Nick Hawkins <nick.hawkins@hpe.com> + - Jean-Marie Verdun <verdun@hpe.com> + +allOf: + - $ref: "spi-controller.yaml#" + +properties: + compatible: + const: hpe,gxp-spifi + + reg: + items: + - description: cfg registers + - description: data registers + - description: mapped memory + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + + spi@200 { + compatible = "hpe,gxp-spifi"; + reg = <0x200 0x80>, <0xc000 0x100>, <0x38000000 0x800000>; + interrupts = <20>; + interrupt-parrent = <&vic0>; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + reg = < 0 >; + compatible = "jedec,spi-nor"; + }; + + flash@1 { + reg = < 1 >; + compatible = "jedec,spi-nor"; + }; + };