[v2] spi: a3700: support BE for AC5 SPI driver

Commit Message

Vadym Kochan July 26, 2022, 1 p.m. UTC

From: Noam <[e-mail]>

Signed-off-by: Noam <[e-mail]>
Tested-by: Raz Adashi <[e-mail]>
Reviewed-by: Raz Adashi <[e-mail]>
Signed-off-by: Vadym Kochan <[e-mail]>
---
v2:
   #1 added missing SOB for Noam

   #2 fix wrong endianess in a3700_spi_fifo_read()

 drivers/spi/spi-armada-3700.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Brown July 26, 2022, 3:32 p.m. UTC | #1

On Tue, Jul 26, 2022 at 04:00:37PM +0300, Vadym Kochan wrote:
> From: Noam <[e-mail]>
> 
> Signed-off-by: Noam <[e-mail]>
> Tested-by: Raz Adashi <[e-mail]>
> Reviewed-by: Raz Adashi <[e-mail]>
> Signed-off-by: Vadym Kochan <[e-mail]>
> ---
> v2:
>    #1 added missing SOB for Noam

Noam, is this OK?

Noam Liron July 26, 2022, 3:42 p.m. UTC | #2

Hi Mark,

Yes, patch looks ok

-----Original Message-----
From: Mark Brown <[e-mail]> 
Sent: Tuesday, July 26, 2022 6:32 PM
To: Vadym Kochan <[e-mail]>
Cc: [e-mail]; [e-mail]; Elad Nachman <[e-mail]>; Noam Liron <[e-mail]>
Subject: [EXT] Re: [PATCH v2] spi: a3700: support BE for AC5 SPI driver

External Email

----------------------------------------------------------------------
On Tue, Jul 26, 2022 at 04:00:37PM +0300, Vadym Kochan wrote:
> From: Noam <[e-mail]>
> 
> Signed-off-by: Noam <[e-mail]>
> Tested-by: Raz Adashi <[e-mail]>
> Reviewed-by: Raz Adashi <[e-mail]>
> Signed-off-by: Vadym Kochan <[e-mail]>
> ---
> v2:
>    #1 added missing SOB for Noam

Noam, is this OK?

Mark Brown July 26, 2022, 5:39 p.m. UTC | #3

On Tue, 26 Jul 2022 16:00:37 +0300, Vadym Kochan wrote:
> From: Noam <[e-mail]>
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: a3700: support BE for AC5 SPI driver
      commit: 66bbf1441d218316948877f7ec6b477c9a49d554

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
index d8cc4b270644..9df9fc40b783 100644
--- a/drivers/spi/spi-armada-3700.c
+++ b/drivers/spi/spi-armada-3700.c
@@ -497,7 +497,7 @@  static int a3700_spi_fifo_write(struct a3700_spi *a3700_spi)
 
 	while (!a3700_is_wfifo_full(a3700_spi) && a3700_spi->buf_len) {
 		val = *(u32 *)a3700_spi->tx_buf;
-		spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val);
+		spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, cpu_to_le32(val));
 		a3700_spi->buf_len -= 4;
 		a3700_spi->tx_buf += 4;
 	}
@@ -519,7 +519,7 @@  static int a3700_spi_fifo_read(struct a3700_spi *a3700_spi)
 	while (!a3700_is_rfifo_empty(a3700_spi) && a3700_spi->buf_len) {
 		val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG);
 		if (a3700_spi->buf_len >= 4) {
-
+			val = le32_to_cpu(val);
 			memcpy(a3700_spi->rx_buf, &val, 4);
 
 			a3700_spi->buf_len -= 4;