| Message ID | 20221006194819.1536932-1-robert.marko@sartura.hr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b40af6183b685b0cf7870987b858de0d48db9ea0 |
| Headers | show |
| Series | spi: qup: support using GPIO as chip select line | expand |
On Thu, Oct 6, 2022 at 9:48 PM Robert Marko <robert.marko@sartura.hr> wrote: > Most of the device with QUP SPI adapter are actually using GPIO-s for > chip select. > > However, this stopped working after ("spi: Retire legacy GPIO handling") > as it introduced a check on ->use_gpio_descriptors flag and since spi-qup > driver does not set the flag it meant that all of boards using GPIO-s and > with QUP adapter SPI devices stopped working. > > So, to enable using GPIO-s again set ->use_gpio_descriptors to true and > populate ->max_native_cs. > > Fixes: f48dc6b96649 ("spi: Retire legacy GPIO handling") > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > Cc: luka.perkov@sartura.hr Ooops sorry about that! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, 6 Oct 2022 21:48:19 +0200, Robert Marko wrote: > Most of the device with QUP SPI adapter are actually using GPIO-s for > chip select. > > However, this stopped working after ("spi: Retire legacy GPIO handling") > as it introduced a check on ->use_gpio_descriptors flag and since spi-qup > driver does not set the flag it meant that all of boards using GPIO-s and > with QUP adapter SPI devices stopped working. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: qup: support using GPIO as chip select line commit: b40af6183b685b0cf7870987b858de0d48db9ea0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 00d6084306b4..81c2e00532cf 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -1057,6 +1057,8 @@ static int spi_qup_probe(struct platform_device *pdev) else master->num_chipselect = num_cs; + master->use_gpio_descriptors = true; + master->max_native_cs = SPI_NUM_CHIPSELECTS; master->bus_num = pdev->id; master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LOOP; master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32);
Most of the device with QUP SPI adapter are actually using GPIO-s for chip select. However, this stopped working after ("spi: Retire legacy GPIO handling") as it introduced a check on ->use_gpio_descriptors flag and since spi-qup driver does not set the flag it meant that all of boards using GPIO-s and with QUP adapter SPI devices stopped working. So, to enable using GPIO-s again set ->use_gpio_descriptors to true and populate ->max_native_cs. Fixes: f48dc6b96649 ("spi: Retire legacy GPIO handling") Signed-off-by: Robert Marko <robert.marko@sartura.hr> Cc: luka.perkov@sartura.hr --- drivers/spi/spi-qup.c | 2 ++ 1 file changed, 2 insertions(+)