From patchwork Mon Feb 6 18:31:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Lima X-Patchwork-Id: 13130493 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E49C05027 for ; Mon, 6 Feb 2023 18:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbjBFScZ (ORCPT ); Mon, 6 Feb 2023 13:32:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbjBFScV (ORCPT ); Mon, 6 Feb 2023 13:32:21 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC3A22E82D for ; Mon, 6 Feb 2023 10:32:13 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id r34-20020a05683044a200b0068d4a8a8d2dso3441844otv.12 for ; Mon, 06 Feb 2023 10:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eclypsium.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z5Dop0JJ1yXeqdmayLcKzOJgB2NB2hJjMqigFOhcalc=; b=UWPCVmXV/OVoiqbJXD3UrCLx/AzD90fZvAgKXN07YWo7ZM0hnGBzv3N7N6DTj4INRQ 8M1wip0CDevWGv0pSfEE2MMb8Yuhm73cDrHJv87cBfUMpowVSn1ci05HZrA/ES2x0d6J jtNVGzKqu+KLrnlf/6LRb62WcqZECL1uaydVH/70g1/IEu4ump4xZQ958qhnExd4LRzn pP2uArcM5sueX5SC/kTh5OXypAzQt157cK3Yn9j9rqKUOaZB2WgyD/hB2+u9SXLB29yq Cgx+HbAiZoa7mBeoznOJyq+ynURWgfwIzXGcHs5mF3qbX4EwqjysS08FFO8Z/IdTflO6 5R7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z5Dop0JJ1yXeqdmayLcKzOJgB2NB2hJjMqigFOhcalc=; b=OAeJYlOwGH9Wlqy6MuoZhSTjmtVjM0QYagSgCSJdirIdqZieB7TbV5JGk0s9lLJaI1 kJYBS8rTVkTl0xaZlfxPQ1oBRYhXYEKwVLKzVLrj1ipAQOQeoKE9372IpRJekpY/RWEq Q83qiDW+mQNUVEG2H79cl090Nrobq+KaiTEaP2NAHZXB+ZRtUcdzN1Ezmxd0aicEgMLc uhZtTZx3eZjUNaWN5lPPHhawYbG436d4sBwI7TP43W7pJNVa/8B16xLE4tLMtOcIGm6A JYc7Ou597CC688jnP8qxPT5UukajI04PTsdww4fFAQevtOv7KkkAnSc30qQnLSYZ4PEw Kobg== X-Gm-Message-State: AO0yUKWVCwkSf0EIZ8OLl+RJ5AwSATEuLFyvJG8UhqeqguZqg+ZNPz50 v/TTgfsTZI14mxDRhbOMSlq2rhLA2oXVYJCu X-Google-Smtp-Source: AK7set9yreks8FLO+D7nQBY1YwZqgq43bkFaoHhBymtpwNvXXWloyHw4v2EoZjTPAoJCNpyRi1HW5A== X-Received: by 2002:a9d:177:0:b0:68d:a785:5f5f with SMTP id 110-20020a9d0177000000b0068da7855f5fmr334566otu.2.1675708333198; Mon, 06 Feb 2023 10:32:13 -0800 (PST) Received: from fedora.. ([186.122.48.201]) by smtp.gmail.com with ESMTPSA id x39-20020a056830246700b0068bb7bd2668sm5201636otr.73.2023.02.06.10.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 10:32:12 -0800 (PST) From: Mauro Lima To: mika.westerberg@linux.intel.com Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Lima Subject: [PATCH 1/1] spi: intel: Remove DANGEROUS tag from pci driver Date: Mon, 6 Feb 2023 15:31:43 -0300 Message-Id: <20230206183143.75274-2-mauro.lima@eclypsium.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230206183143.75274-1-mauro.lima@eclypsium.com> References: <20230206183143.75274-1-mauro.lima@eclypsium.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Modern CPUs exposes this controller as PCI device that only uses hardware sequencing capabilities which is safer than software sequencing. Leave the platform driver as *DANGEROUS* and update help text since most of these controllers are using software sequencing. Signed-off-by: Mauro Lima Acked-by: Mika Westerberg --- drivers/spi/Kconfig | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 87fc2bd16b72..3a362c450cb6 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -447,7 +447,7 @@ config SPI_INTEL tristate config SPI_INTEL_PCI - tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" + tristate "Intel PCH/PCU SPI flash PCI driver" depends on PCI depends on X86 || COMPILE_TEST depends on SPI_MEM @@ -455,8 +455,9 @@ config SPI_INTEL_PCI help This enables PCI support for the Intel PCH/PCU SPI controller in master mode. This controller is present in modern Intel hardware - and is used to hold BIOS and other persistent settings. Using - this driver it is possible to upgrade BIOS directly from Linux. + and is used to hold BIOS and other persistent settings. This + driver only supports hardware sequencing mode. Using this + driver it is possible to upgrade BIOS directly from Linux. Say N here unless you know what you are doing. Overwriting the SPI flash may render the system unbootable. @@ -471,10 +472,10 @@ config SPI_INTEL_PLATFORM select SPI_INTEL help This enables platform support for the Intel PCH/PCU SPI - controller in master mode. This controller is present in modern - Intel hardware and is used to hold BIOS and other persistent - settings. Using this driver it is possible to upgrade BIOS - directly from Linux. + controller in master mode that is used to hold BIOS and other + persistent settings. Most of these controllers are using + software sequencing mode. Using this driver it is possible to + upgrade BIOS directly from Linux. Say N here unless you know what you are doing. Overwriting the SPI flash may render the system unbootable.