| Message ID | 20230210101403.14609-1-avolmat@me.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: spi: conversion of spi-st-ssc into DT schema YAML | expand |
On 10/02/2023 11:14, Alain Volmat wrote: > File st,ssc-spi.yaml replaces spi-st-ssc.txt for the > ST Microelectronics SSC SPI driver. subject: spi: dt-bindings: spi-st-ssc: convert to DT schema YAML is redundant, "conversion" of too long > > Signed-off-by: Alain Volmat <avolmat@me.com> > --- > .../devicetree/bindings/spi/spi-st-ssc.txt | 40 ------------ > .../devicetree/bindings/spi/st,ssc-spi.yaml | 61 +++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 62 insertions(+), 40 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/spi-st-ssc.txt > create mode 100644 Documentation/devicetree/bindings/spi/st,ssc-spi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/spi-st-ssc.txt b/Documentation/devicetree/bindings/spi/spi-st-ssc.txt > deleted file mode 100644 > index 1bdc4709e474..000000000000 > --- a/Documentation/devicetree/bindings/spi/spi-st-ssc.txt > +++ /dev/null > @@ -1,40 +0,0 @@ > -STMicroelectronics SSC (SPI) Controller > ---------------------------------------- > - > -Required properties: > -- compatible : "st,comms-ssc4-spi" > -- reg : Offset and length of the device's register set > -- interrupts : The interrupt specifier > -- clock-names : Must contain "ssc" > -- clocks : Must contain an entry for each name in clock-names > - See ../clk/* > -- pinctrl-names : Uses "default", can use "sleep" if provided > - See ../pinctrl/pinctrl-bindings.txt > - > -Optional properties: > -- cs-gpios : List of GPIO chip selects > - See ../spi/spi-bus.txt > - > -Child nodes represent devices on the SPI bus > - See ../spi/spi-bus.txt > - > -Example: > - spi@9840000 { > - compatible = "st,comms-ssc4-spi"; > - reg = <0x9840000 0x110>; > - interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>; > - clock-names = "ssc"; > - pinctrl-0 = <&pinctrl_spi0_default>; > - pinctrl-names = "default"; > - cs-gpios = <&pio17 5 0>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - st95hf@0{ > - compatible = "st,st95hf"; > - reg = <0>; > - spi-max-frequency = <1000000>; > - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml b/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml > new file mode 100644 > index 000000000000..496118df3a1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/st,ssc-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics SSC SPI Controller > + > +description: | > + The STMicroelectronics SSC SPI controller can be found on STi platforms > + and it used to communicate with external devices using the > + Serial Peripheral Interface. > + > +maintainers: > + - Patrice Chotard <patrice.chotard@foss.st.com> > + > +allOf: > + - $ref: "spi-controller.yaml#" Drop quotes. > + > +properties: > + compatible: > + const: st,comms-ssc4-spi > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: ssc > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/stih407-clks.h> > + spi@9840000 { > + compatible = "st,comms-ssc4-spi"; > + reg = <0x9840000 0x110>; > + interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>; > + clock-names = "ssc"; > + pinctrl-0 = <&pinctrl_spi0_default>; > + pinctrl-names = "default"; > + #address-cells = <1>; > + #size-cells = <0>; Messed coding style. Only one space before =. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/spi-st-ssc.txt b/Documentation/devicetree/bindings/spi/spi-st-ssc.txt deleted file mode 100644 index 1bdc4709e474..000000000000 --- a/Documentation/devicetree/bindings/spi/spi-st-ssc.txt +++ /dev/null @@ -1,40 +0,0 @@ -STMicroelectronics SSC (SPI) Controller ---------------------------------------- - -Required properties: -- compatible : "st,comms-ssc4-spi" -- reg : Offset and length of the device's register set -- interrupts : The interrupt specifier -- clock-names : Must contain "ssc" -- clocks : Must contain an entry for each name in clock-names - See ../clk/* -- pinctrl-names : Uses "default", can use "sleep" if provided - See ../pinctrl/pinctrl-bindings.txt - -Optional properties: -- cs-gpios : List of GPIO chip selects - See ../spi/spi-bus.txt - -Child nodes represent devices on the SPI bus - See ../spi/spi-bus.txt - -Example: - spi@9840000 { - compatible = "st,comms-ssc4-spi"; - reg = <0x9840000 0x110>; - interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>; - clock-names = "ssc"; - pinctrl-0 = <&pinctrl_spi0_default>; - pinctrl-names = "default"; - cs-gpios = <&pio17 5 0>; - #address-cells = <1>; - #size-cells = <0>; - - st95hf@0{ - compatible = "st,st95hf"; - reg = <0>; - spi-max-frequency = <1000000>; - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; - }; - }; diff --git a/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml b/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml new file mode 100644 index 000000000000..496118df3a1b --- /dev/null +++ b/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/st,ssc-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics SSC SPI Controller + +description: | + The STMicroelectronics SSC SPI controller can be found on STi platforms + and it used to communicate with external devices using the + Serial Peripheral Interface. + +maintainers: + - Patrice Chotard <patrice.chotard@foss.st.com> + +allOf: + - $ref: "spi-controller.yaml#" + +properties: + compatible: + const: st,comms-ssc4-spi + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: ssc + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/stih407-clks.h> + spi@9840000 { + compatible = "st,comms-ssc4-spi"; + reg = <0x9840000 0x110>; + interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>; + clock-names = "ssc"; + pinctrl-0 = <&pinctrl_spi0_default>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 2e32eb8d44f5..0fc3e4c6c1e5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2926,6 +2926,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained W: http://www.stlinux.com F: Documentation/devicetree/bindings/i2c/st,sti-i2c.yaml +F: Documentation/devicetree/bindings/spi/st,ssc-spi.yaml F: arch/arm/boot/dts/sti* F: arch/arm/mach-sti/ F: drivers/ata/ahci_st.c
File st,ssc-spi.yaml replaces spi-st-ssc.txt for the ST Microelectronics SSC SPI driver. Signed-off-by: Alain Volmat <avolmat@me.com> --- .../devicetree/bindings/spi/spi-st-ssc.txt | 40 ------------ .../devicetree/bindings/spi/st,ssc-spi.yaml | 61 +++++++++++++++++++ MAINTAINERS | 1 + 3 files changed, 62 insertions(+), 40 deletions(-) delete mode 100644 Documentation/devicetree/bindings/spi/spi-st-ssc.txt create mode 100644 Documentation/devicetree/bindings/spi/st,ssc-spi.yaml