diff mbox series

[-next] spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe()

Message ID 20230217075226.185920-1-yangyingliang@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe() | expand

Commit Message

Yang Yingliang Feb. 17, 2023, 7:52 a.m. UTC
Set the error code when sysfs_create_group() fails in bcmbca_hsspi_probe().

Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/spi/spi-bcm63xx-hsspi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

William Zhang Feb. 20, 2023, 10:51 p.m. UTC | #1
Hi Yingliang,

On 02/16/2023 11:52 PM, Yang Yingliang wrote:
> Set the error code when sysfs_create_group() fails in bcmbca_hsspi_probe().
> 
> Fixes: 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>   drivers/spi/spi-bcm63xx-hsspi.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
> index 68093c045e0b..cd0a6478f5e7 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -849,7 +849,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(&pdev->dev);
>   
> -	if (sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group)) {
> +	ret = sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
> +	if (ret) {
>   		dev_err(&pdev->dev, "couldn't register sysfs group\n");
>   		goto out_pm_disable;
>   	}
> 
Thanks for the patch but this issue was previously fixed with this 
patch: https://lore.kernel.org/all/Y+zmoGH6LubPhiI0@kili/
diff mbox series

Patch

diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
index 68093c045e0b..cd0a6478f5e7 100644
--- a/drivers/spi/spi-bcm63xx-hsspi.c
+++ b/drivers/spi/spi-bcm63xx-hsspi.c
@@ -849,7 +849,8 @@  static int bcm63xx_hsspi_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(&pdev->dev);
 
-	if (sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group)) {
+	ret = sysfs_create_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
+	if (ret) {
 		dev_err(&pdev->dev, "couldn't register sysfs group\n");
 		goto out_pm_disable;
 	}