| Message ID | 20230303172041.2103336-7-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7412afb044178ac0e6facc5f12b5ab220e06c34c |
| Headers | show |
| Series | spi: Convert to platform remove callback returning void | expand |
On 03.03.2023 19:19, Uwe Kleine-König wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > drivers/spi/spi-atmel.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 5c5678f065f3..73f80c8ac2ff 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1596,7 +1596,7 @@ static int atmel_spi_probe(struct platform_device *pdev) > return ret; > } > > -static int atmel_spi_remove(struct platform_device *pdev) > +static void atmel_spi_remove(struct platform_device *pdev) > { > struct spi_controller *host = platform_get_drvdata(pdev); > struct atmel_spi *as = spi_controller_get_devdata(host); > @@ -1627,8 +1627,6 @@ static int atmel_spi_remove(struct platform_device *pdev) > > pm_runtime_put_noidle(&pdev->dev); > pm_runtime_disable(&pdev->dev); > - > - return 0; > } > > static int atmel_spi_runtime_suspend(struct device *dev) > @@ -1712,7 +1710,7 @@ static struct platform_driver atmel_spi_driver = { > .of_match_table = atmel_spi_dt_ids, > }, > .probe = atmel_spi_probe, > - .remove = atmel_spi_remove, > + .remove_new = atmel_spi_remove, > }; > module_platform_driver(atmel_spi_driver); > > -- > 2.39.1 >
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 5c5678f065f3..73f80c8ac2ff 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -1596,7 +1596,7 @@ static int atmel_spi_probe(struct platform_device *pdev) return ret; } -static int atmel_spi_remove(struct platform_device *pdev) +static void atmel_spi_remove(struct platform_device *pdev) { struct spi_controller *host = platform_get_drvdata(pdev); struct atmel_spi *as = spi_controller_get_devdata(host); @@ -1627,8 +1627,6 @@ static int atmel_spi_remove(struct platform_device *pdev) pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static int atmel_spi_runtime_suspend(struct device *dev) @@ -1712,7 +1710,7 @@ static struct platform_driver atmel_spi_driver = { .of_match_table = atmel_spi_dt_ids, }, .probe = atmel_spi_probe, - .remove = atmel_spi_remove, + .remove_new = atmel_spi_remove, }; module_platform_driver(atmel_spi_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/spi/spi-atmel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)