| Message ID | 20230310111544.57342-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 21d19e601fd221cd61105286b0b6ec2f9c5a2576 |
| Headers | show |
| Series | [v1,1/1] spi: mpc5xxx-psc: Remove goto to the unexisted label | expand |
Hi Andy, On Fri, Mar 10, 2023 at 01:15:44PM +0200, Andy Shevchenko wrote: > The previous cleanup patch had lost one of its parts in a crack, > Finish the cleanup by removing the leftovers. I wonder how this was compiling. > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 9e21720a4958 ("spi: mpc5xxx-psc: use devm_clk_get_enabled() for core clock") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Andi
On Fri, 10 Mar 2023 13:15:44 +0200, Andy Shevchenko wrote: > The previous cleanup patch had lost one of its parts in a crack, > Finish the cleanup by removing the leftovers. > > Applied to broonie/spi.git for-next Thanks! [1/1] spi: mpc5xxx-psc: Remove goto to the unexisted label commit: 21d19e601fd221cd61105286b0b6ec2f9c5a2576 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index 77a228f633d1..0b86f1804682 100644 --- a/drivers/spi/spi-mpc512x-psc.c +++ b/drivers/spi/spi-mpc512x-psc.c @@ -511,13 +511,9 @@ static int mpc512x_psc_spi_of_probe(struct platform_device *pdev) ret = mpc512x_psc_spi_port_config(master, mps); if (ret < 0) - goto free_ipg_clock; - - ret = devm_spi_register_master(dev, master); - if (ret < 0) - goto free_ipg_clock; + return ret; - return ret; + return devm_spi_register_master(dev, master); } static const struct of_device_id mpc512x_psc_spi_of_match[] = {
The previous cleanup patch had lost one of its parts in a crack, Finish the cleanup by removing the leftovers. Reported-by: kernel test robot <lkp@intel.com> Fixes: 9e21720a4958 ("spi: mpc5xxx-psc: use devm_clk_get_enabled() for core clock") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/spi/spi-mpc512x-psc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)