| Message ID | 20230615070706.18322-3-quic_ptalari@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi-geni-qcom: Add SPI SLAVE mode support for | expand |
On 15/06/2023 09:07, Praveen Talari wrote: > Set this property to configure QUPV3 as SPI slave controller. 1. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. 2. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested by our tools. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. 3. Commit msg: Don't explain what you are doing, but explain why you are doing and why this is needed. > > Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com> > --- > Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml > index 2e20ca313ec1..cdd6d19876d3 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml > @@ -66,6 +66,8 @@ properties: > reg: > maxItems: 1 > > + qcom,slv-ctrl: It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Awesome, so you send untested, broken code skipping necessary mailing lists so even automation won't test it. :( Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml index 2e20ca313ec1..cdd6d19876d3 100644 --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml @@ -66,6 +66,8 @@ properties: reg: maxItems: 1 + qcom,slv-ctrl: + required: - compatible - clocks
Set this property to configure QUPV3 as SPI slave controller. Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com> --- Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 2 ++ 1 file changed, 2 insertions(+)