From patchwork Tue Jan 9 21:00:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Dasu X-Patchwork-Id: 13515397 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8CC3D985 for ; Tue, 9 Jan 2024 21:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="M6spIOd0" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6da4a923b1bso1702291b3a.2 for ; Tue, 09 Jan 2024 13:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1704834114; x=1705438914; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s6+RZVLAeb8qYjwNyOM9JDHgFUq66Gh6JTm8jgrKm3Q=; b=M6spIOd0uX15mAX1CrP2y8G3SxZpNdJ92XBOP0+XLcP7DhpwacLsD3SQIhVYsx0909 dWSqxpfVenj1qkCgzQLbLs9ZqZwS8cdMsisAv1XzKibhYsoYn9moj3ScmOitrGlfIbBY Y3DoNyztGKlORA1Vz7ciDo4K0E1CnFDflaFAc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704834114; x=1705438914; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s6+RZVLAeb8qYjwNyOM9JDHgFUq66Gh6JTm8jgrKm3Q=; b=oG/0SHDopHBJiynaX5s3iBfSPUozsrJ3lA5/jNqKt5JPvry9+/c02ONqfyUsAL3+q2 46KA5Xrl+UGEhC0MUQvy8SHq8xw0eqgH0Bvg8lm20UQ8KmG2CF3dku/TgVJG8tiujjvR LZpCvqsEheDQc5RAxkb0rumT+qnDImGNcfm+tK8u7EbeTNsVGZPMGZXJ8/q2UkTXidYT 5ejg7R2ikND0qmb41QmVPTnauJBf2dJoUFbCJpci7T4wCCtuGyQdp9REdLVkJ9jf12vG zgN3KGSB7hstxx5m5d+OBvmtCHg/XvUGhIRxeISk5nh2CLOXfHnYIm7KPUqbrlMIbup0 Z17A== X-Gm-Message-State: AOJu0Ywdd2jLiDk9I+NMsQ/RkoUoIFiVELEdVxj0DrfLfqR41v1hRySS +t/AZwo5b5g4aTgFz+GcwB2twnNySk5q X-Google-Smtp-Source: AGHT+IE4riUZP6nc5yXMxlnQqAnXAVMak+hczBLACEyCAL0QtjwSb/HMRPe4NjhGPPP8I04L+y7htg== X-Received: by 2002:a05:6a00:3cc7:b0:6d9:a2de:c798 with SMTP id ln7-20020a056a003cc700b006d9a2dec798mr104851pfb.30.1704834114220; Tue, 09 Jan 2024 13:01:54 -0800 (PST) Received: from mail.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id y15-20020a62ce0f000000b006ce71af841bsm2191277pfg.4.2024.01.09.13.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 13:01:53 -0800 (PST) From: Kamal Dasu To: Kamal Dasu , Broadcom internal kernel review list , Mark Brown , Boris Brezillon Cc: Kamal Dasu , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: bcm-qspi: fix SFDP BFPT read by usig mspi read Date: Tue, 9 Jan 2024 16:00:32 -0500 Message-Id: <20240109210033.43249-1-kamal.dasu@broadcom.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: SFDP read shall use the mspi reads when using the bcm_qspi_exec_mem_op() call. This fixes SFDP parameter page read failures seen with parts that now use SFDP protocol to read the basic flash parameter table. Fixes: 5f195ee7d830 ("spi: bcm-qspi: Implement the spi_mem interface") Signed-off-by: Kamal Dasu Tested-by: Florian Fainelli Reviewed-by: Florian Fainelli --- drivers/spi/spi-bcm-qspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index ef08fcac2f6d..0407b91183ca 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include #include #include "spi-bcm-qspi.h" @@ -1221,7 +1221,7 @@ static int bcm_qspi_exec_mem_op(struct spi_mem *mem, /* non-aligned and very short transfers are handled by MSPI */ if (!IS_ALIGNED((uintptr_t)addr, 4) || !IS_ALIGNED((uintptr_t)buf, 4) || - len < 4) + len < 4 || op->cmd.opcode == SPINOR_OP_RDSFDP) mspi_read = true; if (!has_bspi(qspi) || mspi_read)