| Message ID | 20240228204919.3680786-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c5e6d3d85efa7451590edd94725b4b280e2fd8a3 |
| Headers | show |
| Series | iio: core: New macros and making use of them | expand |
On Wed, Feb 28, 2024 at 10:41:31PM +0200, Andy Shevchenko wrote: > The check_shl_overflow() uses u64 type that is defined in types.h. > Instead of including that header, just switch to use POD type > directly. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Kees Cook <keescook@chromium.org>
On Wed, Feb 28, 2024 at 01:33:15PM -0800, Kees Cook wrote: > On Wed, Feb 28, 2024 at 10:41:31PM +0200, Andy Shevchenko wrote: > > The check_shl_overflow() uses u64 type that is defined in types.h. > > Instead of including that header, just switch to use POD type > > directly. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Acked-by: Kees Cook <keescook@chromium.org> Based on the further discussion this seems pretty independent. Can you take it through your tree?
On Wed, 28 Feb 2024 22:41:31 +0200, Andy Shevchenko wrote: > The check_shl_overflow() uses u64 type that is defined in types.h. > Instead of including that header, just switch to use POD type > directly. > > Applied to for-next/hardening, thanks! [1/8] overflow: Use POD in check_shl_overflow() https://git.kernel.org/kees/c/4e55a75495b7 Take care,
diff --git a/include/linux/overflow.h b/include/linux/overflow.h index dede374832c9..bc390f026128 100644 --- a/include/linux/overflow.h +++ b/include/linux/overflow.h @@ -197,7 +197,7 @@ static inline bool __must_check __must_check_overflow(bool overflow) typeof(a) _a = a; \ typeof(s) _s = s; \ typeof(d) _d = d; \ - u64 _a_full = _a; \ + unsigned long long _a_full = _a; \ unsigned int _to_shift = \ is_non_negative(_s) && _s < 8 * sizeof(*d) ? _s : 0; \ *_d = (_a_full << _to_shift); \
The check_shl_overflow() uses u64 type that is defined in types.h. Instead of including that header, just switch to use POD type directly. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/overflow.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)