| Message ID | 20240429210131.373487-18-eajames@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: aspeed: Add IBM P11 BMC Boards | expand |
On 29/04/2024 23:01, Eddie James wrote: > Use p9-scom instead of fsi2pib. Why? Commits must *always* say why you are doing it. What is easy to see. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > --- > drivers/fsi/fsi-scom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c > index 61dbda9dbe2b..18ca213fdc7e 100644 > --- a/drivers/fsi/fsi-scom.c > +++ b/drivers/fsi/fsi-scom.c > @@ -589,7 +589,7 @@ static int scom_remove(struct device *dev) > } > > static const struct of_device_id scom_of_ids[] = { > - { .compatible = "ibm,fsi2pib" }, > + { .compatible = "ibm,p9-scom" }, This breaks all users without any explanation in the commit! Best regards, Krzysztof
diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c index 61dbda9dbe2b..18ca213fdc7e 100644 --- a/drivers/fsi/fsi-scom.c +++ b/drivers/fsi/fsi-scom.c @@ -589,7 +589,7 @@ static int scom_remove(struct device *dev) } static const struct of_device_id scom_of_ids[] = { - { .compatible = "ibm,fsi2pib" }, + { .compatible = "ibm,p9-scom" }, { } }; MODULE_DEVICE_TABLE(of, scom_of_ids);
Use p9-scom instead of fsi2pib. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/fsi/fsi-scom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)