| Message ID | 20240814192839.345523-1-visitorckw@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f626a0cd07ddb13f146e52adb4b534da40bb1ff7 |
| Headers | show |
| Series | spi: zynq-qspi: Replace kzalloc with kmalloc for buffer allocation | expand |
On 8/14/24 21:28, Kuan-Wei Chiu wrote: > In zynq_qspi_exec_mem_op(), the temporary buffer is allocated with > kzalloc and then immediately initialized using memset to 0xff. To > optimize this, replace kzalloc with kmalloc, as the zeroing operation > is redundant and unnecessary. > > Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com> > --- > Note: Build test only. > > drivers/spi/spi-zynq-qspi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c > index d6325c6be3d4..b67455bda972 100644 > --- a/drivers/spi/spi-zynq-qspi.c > +++ b/drivers/spi/spi-zynq-qspi.c > @@ -569,7 +569,7 @@ static int zynq_qspi_exec_mem_op(struct spi_mem *mem, > } > > if (op->dummy.nbytes) { > - tmpbuf = kzalloc(op->dummy.nbytes, GFP_KERNEL); > + tmpbuf = kmalloc(op->dummy.nbytes, GFP_KERNEL); > if (!tmpbuf) > return -ENOMEM; > Reviewed-by: Michal Simek <michal.simek@amd.com> Thanks, Michal
On Thu, 15 Aug 2024 03:28:39 +0800, Kuan-Wei Chiu wrote: > In zynq_qspi_exec_mem_op(), the temporary buffer is allocated with > kzalloc and then immediately initialized using memset to 0xff. To > optimize this, replace kzalloc with kmalloc, as the zeroing operation > is redundant and unnecessary. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: zynq-qspi: Replace kzalloc with kmalloc for buffer allocation commit: f626a0cd07ddb13f146e52adb4b534da40bb1ff7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index d6325c6be3d4..b67455bda972 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -569,7 +569,7 @@ static int zynq_qspi_exec_mem_op(struct spi_mem *mem, } if (op->dummy.nbytes) { - tmpbuf = kzalloc(op->dummy.nbytes, GFP_KERNEL); + tmpbuf = kmalloc(op->dummy.nbytes, GFP_KERNEL); if (!tmpbuf) return -ENOMEM;
In zynq_qspi_exec_mem_op(), the temporary buffer is allocated with kzalloc and then immediately initialized using memset to 0xff. To optimize this, replace kzalloc with kmalloc, as the zeroing operation is redundant and unnecessary. Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com> --- Note: Build test only. drivers/spi/spi-zynq-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)