| Message ID | 20241002162652.957102-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] spi: spi-ti-qspi: remove redundant assignment to variable ret | expand |
On Wed, 02 Oct 2024 17:26:52 +0100, Colin Ian King wrote: > Variable ret is being assigned a value but it is never read, instead > the variable is being reassigned later in the exit path via label > no_dma. Remove the redundant assignment. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-ti-qspi: remove redundant assignment to variable ret commit: 46854574fd76c711c890423f8ac60df4fb726559 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c index 0b8f496c6bf4..dfd4a7948c03 100644 --- a/drivers/spi/spi-ti-qspi.c +++ b/drivers/spi/spi-ti-qspi.c @@ -861,11 +861,10 @@ static int ti_qspi_probe(struct platform_device *pdev) qspi->rx_chan = dma_request_chan_by_mask(&mask); if (IS_ERR(qspi->rx_chan)) { dev_err(qspi->dev, "No Rx DMA available, trying mmap mode\n"); qspi->rx_chan = NULL; - ret = 0; goto no_dma; } qspi->rx_bb_addr = dma_alloc_coherent(qspi->dev, QSPI_DMA_BUFFER_SIZE, &qspi->rx_bb_dma_addr,
Variable ret is being assigned a value but it is never read, instead the variable is being reassigned later in the exit path via label no_dma. Remove the redundant assignment. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/spi/spi-ti-qspi.c | 1 - 1 file changed, 1 deletion(-)