| Message ID | 20241126134529.936451-4-va@nvidia.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add spidev nodes for SPI controllers | expand |
On 26/11/2024 14:45, Vishwaroop A wrote: > Add "tegra-spidev" name string to load spidev driver > which allows user-space programs to access and communicate > with SPI devices connected to the system. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Vishwaroop A <va@nvidia.com> > --- > drivers/spi/spidev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c > index 653f82984216..1d2c01bd76a9 100644 > --- a/drivers/spi/spidev.c > +++ b/drivers/spi/spidev.c > @@ -711,6 +711,7 @@ static const struct spi_device_id spidev_spi_ids[] = { > { .name = "spi-authenta" }, > { .name = "em3581" }, > { .name = "si3210" }, > + { .name = "tegra-spidev" }, > {}, > }; > MODULE_DEVICE_TABLE(spi, spidev_spi_ids); > @@ -741,6 +742,7 @@ static const struct of_device_id spidev_dt_ids[] = { > { .compatible = "semtech,sx1301", .data = &spidev_of_check }, > { .compatible = "silabs,em3581", .data = &spidev_of_check }, > { .compatible = "silabs,si3210", .data = &spidev_of_check }, > + { .compatible = "nvidia,tegra-spidev", .data = &spidev_of_check }, That's too generic. You need to come with compatibles matching exactly the device connected. Above comment applies to all your patches here - DTS and bindings as well. Best regards, Krzysztof
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 653f82984216..1d2c01bd76a9 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -711,6 +711,7 @@ static const struct spi_device_id spidev_spi_ids[] = { { .name = "spi-authenta" }, { .name = "em3581" }, { .name = "si3210" }, + { .name = "tegra-spidev" }, {}, }; MODULE_DEVICE_TABLE(spi, spidev_spi_ids); @@ -741,6 +742,7 @@ static const struct of_device_id spidev_dt_ids[] = { { .compatible = "semtech,sx1301", .data = &spidev_of_check }, { .compatible = "silabs,em3581", .data = &spidev_of_check }, { .compatible = "silabs,si3210", .data = &spidev_of_check }, + { .compatible = "nvidia,tegra-spidev", .data = &spidev_of_check }, {}, }; MODULE_DEVICE_TABLE(of, spidev_dt_ids);
Add "tegra-spidev" name string to load spidev driver which allows user-space programs to access and communicate with SPI devices connected to the system. Signed-off-by: Vishwaroop A <va@nvidia.com> --- drivers/spi/spidev.c | 2 ++ 1 file changed, 2 insertions(+)