diff mbox series

[3/3] spi: dt-bindings: cdns,qspi-nor: Make the example real

Message ID 20250305200133.2511308-4-miquel.raynal@bootlin.com (mailing list archive)
State New
Headers show
Series spi: dt-bindings: cdns,qspi-nor: Improve description | expand

Commit Message

Miquel Raynal March 5, 2025, 8:01 p.m. UTC
Add several properties to the example. They are actually mandatory from
a description point of view. Unfortunately, because of some YAML
limitations, they are just listed in a file showing the peripheral
properties that "can" be used for this specific controller without
marking them "required" explicitly.

At least mention these properties in the example to hint people they
exist.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski March 6, 2025, 8:59 a.m. UTC | #1
On Wed, Mar 05, 2025 at 09:01:33PM +0100, Miquel Raynal wrote:
> Add several properties to the example. They are actually mandatory from
> a description point of view. Unfortunately, because of some YAML
> limitations, they are just listed in a file showing the peripheral
> properties that "can" be used for this specific controller without
> marking them "required" explicitly.

You can mark them as required - in this binding. See exynos-srom.yaml
(I fixed missing ref to mc-peripheral-props in separate patch).

> 
> At least mention these properties in the example to hint people they
> exist.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
index 0104cc5283db..a22752806ae1 100644
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
@@ -177,5 +177,10 @@  examples:
         flash@0 {
             compatible = "jedec,spi-nor";
             reg = <0x0>;
+            cdns,read-delay = <4>;
+            cdns,tshsl-ns = <60>;
+            cdns,tsd2d-ns = <60>;
+            cdns,tchsh-ns = <60>;
+            cdns,tslch-ns = <60>;
         };
     };