| Message ID | 20250306024716.27856-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3707fd9c383fc7ae19733a3ad2e5a82bf86370a0 |
| Headers | show |
| Series | [-next] spi: stm32: Remove unnecessary print function dev_err() | expand |
On Thu, 06 Mar 2025 10:47:16 +0800, Jiapeng Chong wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > ./drivers/spi/spi-stm32-ospi.c:798:2-9: line 798 is redundant because platform_get_irq() already prints an error. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: stm32: Remove unnecessary print function dev_err() commit: 3707fd9c383fc7ae19733a3ad2e5a82bf86370a0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index 8eadcb64f34a..114ebb1516d4 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -794,10 +794,8 @@ static int stm32_ospi_get_resources(struct platform_device *pdev) } ospi->irq = platform_get_irq(pdev, 0); - if (ospi->irq < 0) { - dev_err(dev, "Can't get irq %d\n", ospi->irq); + if (ospi->irq < 0) return ospi->irq; - } ret = devm_request_irq(dev, ospi->irq, stm32_ospi_irq, 0, dev_name(dev), ospi);
The print function dev_err() is redundant because platform_get_irq() already prints an error. ./drivers/spi/spi-stm32-ospi.c:798:2-9: line 798 is redundant because platform_get_irq() already prints an error. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19220 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/spi/spi-stm32-ospi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)