| Message ID | 20250307032530.116837-1-hanchunchao@inspur.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | spi: stm32: Fix a NULL vs IS_ERR() bug | expand |
On 3/7/25 04:25, Charles Han wrote: > The devm_ioremap() function doesn't return error pointers, it may > returns NULL. Update the error checking to match. > > Fixes: 79b8a705e26c ("spi: stm32: Add OSPI driver") > Signed-off-by: Charles Han <hanchunchao@inspur.com> > --- > drivers/spi/spi-stm32-ospi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c > index 8eadcb64f34a..a544d7897edf 100644 > --- a/drivers/spi/spi-stm32-ospi.c > +++ b/drivers/spi/spi-stm32-ospi.c > @@ -835,10 +835,10 @@ static int stm32_ospi_get_resources(struct platform_device *pdev) > if (rmem) { > ospi->mm_size = rmem->size; > ospi->mm_base = devm_ioremap(dev, rmem->base, rmem->size); > - if (IS_ERR(ospi->mm_base)) { > + if (!ospi->mm_base) { > dev_err(dev, "unable to map memory region: %pa+%pa\n", > &rmem->base, &rmem->size); > - ret = PTR_ERR(ospi->mm_base); > + ret = -ENOMEM; > goto err_dma; > } > Hi No need to copy/paste other contributor's patch by just swapping some words in title/commit message. This fix has already sent By Dan Carpenter and merged. Patrice
On Fri, Mar 07, 2025 at 09:59:42AM +0100, Patrice CHOTARD wrote: > On 3/7/25 04:25, Charles Han wrote: > > The devm_ioremap() function doesn't return error pointers, it may > > returns NULL. Update the error checking to match. > No need to copy/paste other contributor's patch by just swapping some > words in title/commit message. > This fix has already sent By Dan Carpenter and merged. No idea if it applies here or not but since a lot of Dan's work is based on static checker results it's quite common to see duplicates of his patches when someone else runs the same or similar checkers - I think all the people running these checkers are aware this happens but often figure it's easier to send the duplicates than to check -next.
diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index 8eadcb64f34a..a544d7897edf 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -835,10 +835,10 @@ static int stm32_ospi_get_resources(struct platform_device *pdev) if (rmem) { ospi->mm_size = rmem->size; ospi->mm_base = devm_ioremap(dev, rmem->base, rmem->size); - if (IS_ERR(ospi->mm_base)) { + if (!ospi->mm_base) { dev_err(dev, "unable to map memory region: %pa+%pa\n", &rmem->base, &rmem->size); - ret = PTR_ERR(ospi->mm_base); + ret = -ENOMEM; goto err_dma; }
The devm_ioremap() function doesn't return error pointers, it may returns NULL. Update the error checking to match. Fixes: 79b8a705e26c ("spi: stm32: Add OSPI driver") Signed-off-by: Charles Han <hanchunchao@inspur.com> --- drivers/spi/spi-stm32-ospi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)