| Message ID | 20250316054651.13242-1-sperezglz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5a5fc308418aca275a898d638bc38c093d101855 |
| Headers | show |
| Series | [v2] spi: spi-mux: Fix coverity issue, unchecked return value | expand |
On Sat, 15 Mar 2025 23:46:06 -0600, Sergio Perez Gonzalez wrote: > The return value of spi_setup() is not captured within > spi_mux_select() and it is assumed to be always success. > > CID: 1638374 > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-mux: Fix coverity issue, unchecked return value commit: 5a5fc308418aca275a898d638bc38c093d101855 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-mux.c b/drivers/spi/spi-mux.c index c02c4204442f..0eb35c4e3987 100644 --- a/drivers/spi/spi-mux.c +++ b/drivers/spi/spi-mux.c @@ -68,9 +68,7 @@ static int spi_mux_select(struct spi_device *spi) priv->current_cs = spi_get_chipselect(spi, 0); - spi_setup(priv->spi); - - return 0; + return spi_setup(priv->spi); } static int spi_mux_setup(struct spi_device *spi)
The return value of spi_setup() is not captured within spi_mux_select() and it is assumed to be always success. CID: 1638374 Signed-off-by: Sergio Perez Gonzalez <sperezglz@gmail.com> --- v2: Return spi_setup() directly instead of using ret variable. --- drivers/spi/spi-mux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)