diff mbox series

spi: amd: add CONFIG_PCI dependency

Message ID 20250410140809.812863-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 7a978d8fcf57b283cb8c88dd4c9431502bd36ea8
Headers show
Series spi: amd: add CONFIG_PCI dependency | expand

Commit Message

Arnd Bergmann April 10, 2025, 2:07 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Without CONFIG_PCI, the module_pci_driver() macro is not defined:

drivers/spi/spi-amd-pci.c:67:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
   67 | module_pci_driver(amd_spi_pci_driver);

Fixes: b644c2776652 ("spi: spi_amd: Add PCI-based driver for AMD HID2 SPI controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown April 11, 2025, 12:54 a.m. UTC | #1 
On Thu, 10 Apr 2025 16:07:49 +0200, Arnd Bergmann wrote:
> Without CONFIG_PCI, the module_pci_driver() macro is not defined:
> 
> drivers/spi/spi-amd-pci.c:67:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
>    67 | module_pci_driver(amd_spi_pci_driver);
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: amd: add CONFIG_PCI dependency
      commit: 7a978d8fcf57b283cb8c88dd4c9431502bd36ea8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 52598f8e7848..b2f5b29980a2 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -1266,6 +1266,7 @@  config SPI_ZYNQMP_GQSPI
 
 config SPI_AMD
 	tristate "AMD SPI controller"
+	depends on PCI
 	depends on SPI_MASTER || COMPILE_TEST
 	help
 	  Enables SPI controller driver for AMD SoC.