| Message ID | 253543c462b765eca40ba54c66f4e3fdf4acdeb7.1659735546.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0df874c6712d9aa8f43c50ec887a21f7b86fc917 |
| Headers | show |
| Series | spi: lpspi: Simplify some error message | expand |
Am Freitag, 5. August 2022, 23:39:19 CEST schrieb Christophe JAILLET: > dev_err_probe() already prints the error code in a human readable way, so > there is no need to duplicate it as a numerical value at the end of the > message. > > Fixes: 12f62a857c83 ("spi: lpspi: Silence error message upon deferred > probe") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/spi/spi-fsl-lpspi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c > index 19b1f3d881b0..cbbe8bbef90a 100644 > --- a/drivers/spi/spi-fsl-lpspi.c > +++ b/drivers/spi/spi-fsl-lpspi.c > @@ -912,7 +912,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) > > ret = devm_spi_register_controller(&pdev->dev, controller); > if (ret < 0) { > - dev_err_probe(&pdev->dev, ret, "spi_register_controller error: %i\n", > ret); + dev_err_probe(&pdev->dev, ret, "spi_register_controller error\n"); > goto free_dma; > } Acked-By: Alexander Stein <alexander.stein@ew.tq-group.com>
On Fri, 5 Aug 2022 23:39:19 +0200, Christophe JAILLET wrote: > dev_err_probe() already prints the error code in a human readable way, so > there is no need to duplicate it as a numerical value at the end of the > message. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: lpspi: Simplify some error message commit: 0df874c6712d9aa8f43c50ec887a21f7b86fc917 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 19b1f3d881b0..cbbe8bbef90a 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -912,7 +912,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) ret = devm_spi_register_controller(&pdev->dev, controller); if (ret < 0) { - dev_err_probe(&pdev->dev, ret, "spi_register_controller error: %i\n", ret); + dev_err_probe(&pdev->dev, ret, "spi_register_controller error\n"); goto free_dma; }
dev_err_probe() already prints the error code in a human readable way, so there is no need to duplicate it as a numerical value at the end of the message. Fixes: 12f62a857c83 ("spi: lpspi: Silence error message upon deferred probe") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/spi/spi-fsl-lpspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)