| Message ID | 2f4b0a0b-2c03-41c0-8a4a-3d789a83832d@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cf1ba3cb245020459f2ca446b7a7b199839f5d83 |
| Headers | show |
| Series | [next] spi: spi-qpic-snand: Fix ECC_CFG_ECC_DISABLE shift in qcom_spi_read_last_cw() | expand |
On Thu, 06 Mar 2025 12:40:01 +0300, Dan Carpenter wrote: > The ECC_CFG_ECC_DISABLE define is BIT(0). It's supposed to be used > directly instead of used as a shifter. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-qpic-snand: Fix ECC_CFG_ECC_DISABLE shift in qcom_spi_read_last_cw() commit: cf1ba3cb245020459f2ca446b7a7b199839f5d83 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index 8c413a6a5152..ffb2b6ec685c 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -514,7 +514,7 @@ static int qcom_spi_read_last_cw(struct qcom_nand_controller *snandc, cfg0 = (ecc_cfg->cfg0_raw & ~(7U << CW_PER_PAGE)) | 0 << CW_PER_PAGE; cfg1 = ecc_cfg->cfg1_raw; - ecc_bch_cfg = 1 << ECC_CFG_ECC_DISABLE; + ecc_bch_cfg = ECC_CFG_ECC_DISABLE; snandc->regs->cmd = snandc->qspi->cmd; snandc->regs->cfg0 = cpu_to_le32(cfg0);
The ECC_CFG_ECC_DISABLE define is BIT(0). It's supposed to be used directly instead of used as a shifter. Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/spi/spi-qpic-snand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)