From patchwork Thu Aug 25 04:44:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9298681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CC6C260757 for ; Thu, 25 Aug 2016 04:58:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD5F0291C0 for ; Thu, 25 Aug 2016 04:58:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B2571291C5; Thu, 25 Aug 2016 04:58:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53077291C0 for ; Thu, 25 Aug 2016 04:58:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756497AbcHYEzy (ORCPT ); Thu, 25 Aug 2016 00:55:54 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36668 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbcHYExO (ORCPT ); Thu, 25 Aug 2016 00:53:14 -0400 Received: by mail-wm0-f66.google.com with SMTP id i138so5622771wmf.3 for ; Wed, 24 Aug 2016 21:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=qjPxkerKr/dRrMx0aoKD2CYrorZqrmHyPPM8D0qLDyo=; b=W8K8CFq8LTorhXFW8pRlzSIY2hMI9jN3dDCsenIAObEoADgfJwGq7c6iXze+IEw9l1 ygPARAd4zyA6AaO9Yqb/S3qY6iZPDuGIc+am+/xbIr22TDrI+ptOvnJ42QfP+GL+k8Cj +afv/bvPc9Z5vxS3TfECClmppOTt02lGFgAVV4RMdmgtw3ufc9mtQvww7r+8WMr1drS2 wAKX5vLvNwsVaiavKwY33pCY97Chkg7z8y+BIN6TPBB/R92Usza723tRgJIedGtLqxqS wcGgRX/0z8p5LjJjZtaPcNTE2kBfX7XxT93wDcZf7TKV712ddnovsg7sMUpuD6nFzJYn Ngng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=qjPxkerKr/dRrMx0aoKD2CYrorZqrmHyPPM8D0qLDyo=; b=jw5d3Y/j+N6yelhuveE5J+jhjdrCRo5AhvNgB+x1Ft36ZawkccfSJ1KjwoCExh4mPq 9xB8G6B99srgJZZz+6VOokdMw4wh59Li0l43/Ux75TvbjCeQE0GD2Yi6MZLvHgkBTAkH bEb+TZ4iBryiTPn7V4TaEbskBk0Y8fq1jOWujc2ntDjmg4tSPO6Frwbpxu0rxgOSUsiF F5dGJkfBQJ9WTz+IeZ2lRo2anKFRIXlLoWgBchaI+vJhYjNoE9kwlYArmUOxUy42MlkF p8gts+szY4dGbzNSIdtFhwZXb+X6e24OnevbWiPqaaxEe7OV6DNE+zlDYWF0F9zH7fLI KSew== X-Gm-Message-State: AEkoouvTfi7kjBxsh3SkUXCnbTWePZm/nMd3fCp6NOfuXmhFRpbITWlv8peYYd67PWQROw== X-Received: by 10.194.238.170 with SMTP id vl10mr6148110wjc.18.1472100793358; Wed, 24 Aug 2016 21:53:13 -0700 (PDT) Received: from ?IPv6:2003:62:5f43:9500:dd82:2805:e44f:720e? (p200300625F439500DD822805E44F720E.dip0.t-ipconnect.de. [2003:62:5f43:9500:dd82:2805:e44f:720e]) by smtp.googlemail.com with ESMTPSA id f10sm13089058wje.14.2016.08.24.21.53.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Aug 2016 21:53:13 -0700 (PDT) From: Heiner Kallweit Subject: [PATCH 05/23] spi: fsl-espi: change return type of fsl_espi_cpu_bufs to void To: Mark Brown References: Cc: "linux-spi@vger.kernel.org" Message-ID: <40dcd903-fdae-6669-5c35-af4b9e9e953b@gmail.com> Date: Thu, 25 Aug 2016 06:44:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP fsl_espi_cpu_bufs always returns 0, so change the return type to void. Signed-off-by: Heiner Kallweit --- drivers/spi/spi-fsl-espi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index 38eced3..cc09ce6 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -195,7 +195,7 @@ static void fsl_espi_setup_transfer(struct spi_device *spi, fsl_espi_change_mode(spi); } -static int fsl_espi_cpu_bufs(struct mpc8xxx_spi *mspi, struct spi_transfer *t, +static void fsl_espi_cpu_bufs(struct mpc8xxx_spi *mspi, struct spi_transfer *t, unsigned int len) { u32 word; @@ -209,8 +209,6 @@ static int fsl_espi_cpu_bufs(struct mpc8xxx_spi *mspi, struct spi_transfer *t, /* transmit word */ word = mspi->get_tx(mspi); mpc8xxx_spi_write_reg(®_base->transmit, word); - - return 0; } static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t) @@ -237,9 +235,7 @@ static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t) mpc8xxx_spi_write_reg(®_base->command, (SPCOM_CS(spi->chip_select) | SPCOM_TRANLEN(t->len - 1))); - ret = fsl_espi_cpu_bufs(mpc8xxx_spi, t, len); - if (ret) - return ret; + fsl_espi_cpu_bufs(mpc8xxx_spi, t, len); /* Won't hang up forever, SPI bus sometimes got lost interrupts... */ ret = wait_for_completion_timeout(&mpc8xxx_spi->done, 2 * HZ);