diff mbox series

spi: spidev: Add missing spi_device_id for jg10309-01

Message ID 54bbb9d8a8db7e52d13e266f2d4a9bcd8b42a98a.1725366625.git.geert+renesas@glider.be (mailing list archive)
State Accepted
Commit 5478a4f7b94414def7b56d2f18bc2ed9b0f3f1f2
Headers show
Series spi: spidev: Add missing spi_device_id for jg10309-01 | expand

Commit Message

Geert Uytterhoeven Sept. 3, 2024, 12:32 p.m. UTC
When the of_device_id entry for "elgin,jg10309-01" was added, the
corresponding spi_device_id was forgotten, causing a warning message
during boot-up:

    SPI driver spidev has no spi_device_id for elgin,jg10309-01

Fix module autoloading and shut up the warning by adding the missing
entry.

Fixes: 5f3eee1eef5d0edd ("spi: spidev: Add an entry for elgin,jg10309-01")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
What is the protocol used to talk to the LCD on the rv1108-elgin-r1
board?  If the LCD is just an HD44780 character LCD connected to a shift
register, it should be modelled as such (see [1] for an example), and
commit 5f3eee1eef5d0edd should be reverted.

[1] https://elixir.bootlin.com/linux/v6.10.7/source/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown Sept. 3, 2024, 5 p.m. UTC | #1
On Tue, 03 Sep 2024 14:32:27 +0200, Geert Uytterhoeven wrote:
> When the of_device_id entry for "elgin,jg10309-01" was added, the
> corresponding spi_device_id was forgotten, causing a warning message
> during boot-up:
> 
>     SPI driver spidev has no spi_device_id for elgin,jg10309-01
> 
> Fix module autoloading and shut up the warning by adding the missing
> entry.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spidev: Add missing spi_device_id for jg10309-01
      commit: 5478a4f7b94414def7b56d2f18bc2ed9b0f3f1f2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 14bf0fa65befefe0..face93a9cf203569 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -702,6 +702,7 @@  static const struct class spidev_class = {
 static const struct spi_device_id spidev_spi_ids[] = {
 	{ .name = "bh2228fv" },
 	{ .name = "dh2228fv" },
+	{ .name = "jg10309-01" },
 	{ .name = "ltc2488" },
 	{ .name = "sx1301" },
 	{ .name = "bk4" },