From patchwork Tue Feb 24 10:27:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 5871631 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DD23ABF440 for ; Tue, 24 Feb 2015 10:28:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DD3CE20621 for ; Tue, 24 Feb 2015 10:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB25A20610 for ; Tue, 24 Feb 2015 10:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbbBXK2B (ORCPT ); Tue, 24 Feb 2015 05:28:01 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:60905 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbbBXK2A (ORCPT ); Tue, 24 Feb 2015 05:28:00 -0500 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0LfioM-1Xl7PO1pKU-00pNch; Tue, 24 Feb 2015 11:27:12 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Mark Brown , Marek Vasut , Wolfram Sang , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Philipp Zabel , Barry Song , Maxime Ripard Subject: Re: [PATCH] spi: sirf: add reset controller dependency Date: Tue, 24 Feb 2015 11:27:06 +0100 Message-ID: <5840299.CR2H70RAJi@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150224075018.GM6236@finisterre.sirena.org.uk> References: <4553005.HBquOfbqXe@wuerfel> <6170208.Z0Upu48JrX@wuerfel> <20150224075018.GM6236@finisterre.sirena.org.uk> MIME-Version: 1.0 X-Provags-ID: V03:K0:Cn/DI8H/GoW+JquXoYIkiAoUMvkpeUoRbn9UA4Kd60EZV/XmOSr jZZlpO5srQxU456SJA+XEVcaw0kNmnEybqwruggdgBN+roQmDzOBaHGsEbM7ufaeYmt/89E J3bFaFXwimT+k/E10VB0SiXf5yvw8tQToJ/p6j1LiZHMmY1XARWVUusEmkYoX+SpUhIKRc+ OAhRLL13j1gUsxVSIWqGA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday 24 February 2015 16:50:18 Mark Brown wrote: > On Mon, Feb 23, 2015 at 11:01:18PM +0100, Arnd Bergmann wrote: > > On Saturday 21 February 2015 18:44:58 Mark Brown wrote: > > > > In that case a dependency seems wrong, I'd expect to see a select - it's > > > a bit obscure to have to grovel around to figure out what magic options > > > are needed to make things turn on and resets feel more like a utility > > > thing than a control bus (which tend to be the things we depend on). > > > Dunno, perhaps I'm wrong? > > > Mixing 'select' and 'depends on' causes recursive dependencies, and > > there are already lots of drivers that do 'depends on RESET_CONTROLLER'. > > Well, perhaps that's the cleanup we should be doing then... one of the > big problems with some of the other randconfig work there's been is that > a lot of the patches just add dependencies without looking at if that > makes sense. I generally try to keep the big picture in mind, but sometimes I take an easier way out to avoid starting a long discussion. > > Most users of this symbol seem to follow the strategy of selecting > > RESET_CONTROLLER when a driver is there to provide the functionality, > > but depending on it when a driver uses it. We are however a bit > > inconsistent here and it would be nice to clean it up. > > Right, to me that feels the opposite way round to how we normally do > things - the drivers for the subsystem normally depend on the subsystem > (or are hidden by it). I think it's the more common of the two approaches, but we are definitely inconsistent here. To make everything consistent here, I'd just do this: > > In this particular patch, I'm just following what others do. > > > We should probably 'select ARCH_HAS_RESET_CONTROLLER' unconditionally > > for ARM ARCH_MULTIPLATFORM, as it's a bit silly to select both > > ARCH_HAS_RESET_CONTROLLER and RESET_CONTROLLER from platform code. > > That does seem a bit odd. TBH I'm never sure that ARCH_HAS_ is that > good an idea for the driver things, most of them can just as reasonably > be used by off-SoC things. I'm totally fine with a patch to kill that off. I suspect it was introduced in order to not show up on x86 and stay under Linus' radar. He does get upset sometimes about seeing too many options for stuff he does not care about, especially when it breaks on x86. Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig index fbccc105819b..0670aa17409d 100644 --- a/drivers/gpu/drm/sti/Kconfig +++ b/drivers/gpu/drm/sti/Kconfig @@ -1,7 +1,7 @@ config DRM_STI tristate "DRM Support for STMicroelectronics SoC stiH41x Series" depends on DRM && (SOC_STIH415 || SOC_STIH416 || ARCH_MULTIPLATFORM) && HAVE_DMA_ATTRS - select RESET_CONTROLLER + depends on RESET_CONTROLLER select DRM_KMS_HELPER select DRM_GEM_CMA_HELPER select DRM_KMS_CMA_HELPER diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig index 7d3af190be55..545b442253e4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig @@ -1,11 +1,11 @@ config STMMAC_ETH tristate "STMicroelectronics 10/100/1000 Ethernet driver" depends on HAS_IOMEM && HAS_DMA + depends on RESET_CONTROLLER select MII select PHYLIB select CRC32 select PTP_1588_CLOCK - select RESET_CONTROLLER ---help--- This is the driver for the Ethernet IPs are built around a Synopsys IP Core and only tested on the STMicroelectronics