| Message ID | 874iyyb0w2.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: add Renesas MSIOF sound driver | expand |
On 18/03/2025 03:06, Kuninori Morimoto wrote: > Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as > both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which > uses Of-Graph in DT. > > MSIOF-SPI/I2S are using same DT compatible properties. > MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2, > MSIOF-SPI doesn't use Of-Graph. > > Ignore MSIOF-I2S case (= Of-Graph) in MSIOF-SPI Doc. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Missing dt-bindings. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/spi/renesas,sh-msiof.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml > index 49649fc3f95a..c491ef5bc78c 100644 > --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml > +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml > @@ -9,6 +9,18 @@ title: Renesas MSIOF SPI controller > maintainers: > - Geert Uytterhoeven <geert+renesas@glider.be> > > +# sharing with MSIOF I2S That's not how you create common schemas. You need to separate schema which is then referenced with $ref with all users. > +# see > +# ${LINUX}/Documentation/devicetree/bindings/sound/renesas,msiof.yaml In anycase drop ${linux}, so the path is verifiable.... which leads to problem: I do not see that file in next. > +select: > + properties: > + compatible: > + contains: > + pattern: "^renesas,.*-msiof$" You don't get custom selects. This replaces existing select which breaks the binding. Best regards, Krzysztof
Hi > > Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as > > both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which > > uses Of-Graph in DT. > > > > MSIOF-SPI/I2S are using same DT compatible properties. > > MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2, > > MSIOF-SPI doesn't use Of-Graph. > > > > Ignore MSIOF-I2S case (= Of-Graph) in MSIOF-SPI Doc. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. Yeah, I did :) git log --oneline --no-merges Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml 1f48cbd6f00f spi: renesas,sh-msiof: Add r8a779h0 support a0dcd1ff9629 spi: renesas,sh-msiof: Miscellaneous improvements aa69dc65e3b3 spi: renesas,sh-msiof: Add r8a779g0 support f4d381038700 spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings b076fdd02133 spi: renesas,sh-msiof: R-Car V3U is R-Car Gen4 e1e62f05d5d9 spi: renesas,sh-msiof: Add generic Gen4 and r8a779f0 support 5a674d9dc9a0 dt-bindings: Fix array constraints on scalar properties 6be69293196c spi: renesas,sh-msiof: Add r8a779a0 support 6fdc6e23a7d1 dt-bindings: Add missing 'unevaluatedProperties' aef161f4f1b8 spi: renesas,sh-msiof: Add r8a77961 support b4f7f5f54705 spi: renesas,sh-msiof: Add r8a774e1 support 6383b118efaf spi: renesas,sh-msiof: Add r8a7742 support fba5618451d2 dt-bindings: Fix incorrect 'reg' property sizes 3d21a4609335 dt-bindings: Remove cases of 'allOf' containing a '$ref' 97f41c68b83e dt-bindings: spi: sh-msiof: Add r8a774b1 support 9c3c41761f45 dt-bindings: spi: sh-msiof: Convert bindings to json-schema Thank you for your help !! Best regards --- Kuninori Morimoto
On 10/04/2025 01:19, Kuninori Morimoto wrote: > > Hi > >>> Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as >>> both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which >>> uses Of-Graph in DT. >>> >>> MSIOF-SPI/I2S are using same DT compatible properties. >>> MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2, >>> MSIOF-SPI doesn't use Of-Graph. >>> >>> Ignore MSIOF-I2S case (= Of-Graph) in MSIOF-SPI Doc. >> >> Please use subject prefixes matching the subsystem. You can get them for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching. > > Yeah, I did :) > > git log --oneline --no-merges Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml So run it on the directory. Apparently many contributors decided to ignore Mark's rule about naming and if people ignore Mark's rule, Mark was removing dt-bindings prefix, thus you have what you have below: > > 1f48cbd6f00f spi: renesas,sh-msiof: Add r8a779h0 support > a0dcd1ff9629 spi: renesas,sh-msiof: Miscellaneous improvements > aa69dc65e3b3 spi: renesas,sh-msiof: Add r8a779g0 support > f4d381038700 spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings > b076fdd02133 spi: renesas,sh-msiof: R-Car V3U is R-Car Gen4 > e1e62f05d5d9 spi: renesas,sh-msiof: Add generic Gen4 and r8a779f0 support > 5a674d9dc9a0 dt-bindings: Fix array constraints on scalar properties > 6be69293196c spi: renesas,sh-msiof: Add r8a779a0 support > 6fdc6e23a7d1 dt-bindings: Add missing 'unevaluatedProperties' > aef161f4f1b8 spi: renesas,sh-msiof: Add r8a77961 support > b4f7f5f54705 spi: renesas,sh-msiof: Add r8a774e1 support > 6383b118efaf spi: renesas,sh-msiof: Add r8a7742 support Prefixes are explained in the docs I linked to. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml index 49649fc3f95a..c491ef5bc78c 100644 --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml @@ -9,6 +9,18 @@ title: Renesas MSIOF SPI controller maintainers: - Geert Uytterhoeven <geert+renesas@glider.be> +# sharing with MSIOF I2S +# see +# ${LINUX}/Documentation/devicetree/bindings/sound/renesas,msiof.yaml +select: + properties: + compatible: + contains: + pattern: "^renesas,.*-msiof$" + port: false + required: + - compatible + allOf: - $ref: spi-controller.yaml#
Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which uses Of-Graph in DT. MSIOF-SPI/I2S are using same DT compatible properties. MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2, MSIOF-SPI doesn't use Of-Graph. Ignore MSIOF-I2S case (= Of-Graph) in MSIOF-SPI Doc. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- .../devicetree/bindings/spi/renesas,sh-msiof.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)