| Message ID | 87o6wy1a3a.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: add Renesas MSIOF sound driver | expand |
Hi Morimoto-san, On Tue, 15 Apr 2025 at 03:34, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > MSIOF will be used as both SPI or I2S. The node name is not "spi". > Rename it to "serial-engine". > > Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > @@ -1250,7 +1250,7 @@ tpu: pwm@e6e80000 { > status = "disabled"; > }; > > - msiof0: spi@e6e90000 { > + msiof0: serial-engine@e6e90000 { Unfortunately this means that this instance can no longer be used in SPI mode without changing the node name back. E.g. with [1]: serial-engine@e6ea0000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'cn5@0' were unexpected) > compatible = "renesas,msiof-r8a779g0", > "renesas,rcar-gen4-msiof"; > reg = <0 0xe6e90000 0 0x0064>; [1] "arm64: dts: renesas: white-hawk: cn5: Add overlay for MSIOF1" https://web.git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=topic/renesas-overlays&id=0b4f1af2c454b49b9f266900dcb578dc311b1475 Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi index 1760720b7128..0b85fa0d1f41 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi @@ -1250,7 +1250,7 @@ tpu: pwm@e6e80000 { status = "disabled"; }; - msiof0: spi@e6e90000 { + msiof0: serial-engine@e6e90000 { compatible = "renesas,msiof-r8a779g0", "renesas,rcar-gen4-msiof"; reg = <0 0xe6e90000 0 0x0064>; @@ -1266,7 +1266,7 @@ msiof0: spi@e6e90000 { status = "disabled"; }; - msiof1: spi@e6ea0000 { + msiof1: serial-engine@e6ea0000 { compatible = "renesas,msiof-r8a779g0", "renesas,rcar-gen4-msiof"; reg = <0 0xe6ea0000 0 0x0064>; @@ -1282,7 +1282,7 @@ msiof1: spi@e6ea0000 { status = "disabled"; }; - msiof2: spi@e6c00000 { + msiof2: serial-engine@e6c00000 { compatible = "renesas,msiof-r8a779g0", "renesas,rcar-gen4-msiof"; reg = <0 0xe6c00000 0 0x0064>; @@ -1298,7 +1298,7 @@ msiof2: spi@e6c00000 { status = "disabled"; }; - msiof3: spi@e6c10000 { + msiof3: serial-engine@e6c10000 { compatible = "renesas,msiof-r8a779g0", "renesas,rcar-gen4-msiof"; reg = <0 0xe6c10000 0 0x0064>; @@ -1314,7 +1314,7 @@ msiof3: spi@e6c10000 { status = "disabled"; }; - msiof4: spi@e6c20000 { + msiof4: serial-engine@e6c20000 { compatible = "renesas,msiof-r8a779g0", "renesas,rcar-gen4-msiof"; reg = <0 0xe6c20000 0 0x0064>; @@ -1330,7 +1330,7 @@ msiof4: spi@e6c20000 { status = "disabled"; }; - msiof5: spi@e6c28000 { + msiof5: serial-engine@e6c28000 { compatible = "renesas,msiof-r8a779g0", "renesas,rcar-gen4-msiof"; reg = <0 0xe6c28000 0 0x0064>;
MSIOF will be used as both SPI or I2S. The node name is not "spi". Rename it to "serial-engine". Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)