| Message ID | 928f3fb507d53ba0774df27cea0bbba4b055993b.1661599671.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2b2bf6b7faa9010fae10dc7de76627a3fdb525b3 |
| Headers | show |
| Series | spi: mt7621: Fix an erroneous message + clean-ups | expand |
On 27/08/2022 13:42, Christophe JAILLET wrote: > 'status' is known to be 0 at this point. The expected error code is > PTR_ERR(clk). > > Switch to dev_err_probe() in order to display the expected error code (in a > human readable way). > This also filters -EPROBE_DEFER cases, should it happen. > > Fixes: 1ab7f2a43558 ("staging: mt7621-spi: add mt7621 support") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/spi/spi-mt7621.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/spi-mt7621.c b/drivers/spi/spi-mt7621.c > index b4b9b7309b5e..351b0ef52bbc 100644 > --- a/drivers/spi/spi-mt7621.c > +++ b/drivers/spi/spi-mt7621.c > @@ -340,11 +340,9 @@ static int mt7621_spi_probe(struct platform_device *pdev) > return PTR_ERR(base); > > clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(clk)) { > - dev_err(&pdev->dev, "unable to get SYS clock, err=%d\n", > - status); > - return PTR_ERR(clk); > - } > + if (IS_ERR(clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(clk), > + "unable to get SYS clock\n"); > > status = clk_prepare_enable(clk); > if (status)
Il 27/08/22 13:42, Christophe JAILLET ha scritto: > 'status' is known to be 0 at this point. The expected error code is > PTR_ERR(clk). > > Switch to dev_err_probe() in order to display the expected error code (in a > human readable way). > This also filters -EPROBE_DEFER cases, should it happen. > > Fixes: 1ab7f2a43558 ("staging: mt7621-spi: add mt7621 support") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff --git a/drivers/spi/spi-mt7621.c b/drivers/spi/spi-mt7621.c index b4b9b7309b5e..351b0ef52bbc 100644 --- a/drivers/spi/spi-mt7621.c +++ b/drivers/spi/spi-mt7621.c @@ -340,11 +340,9 @@ static int mt7621_spi_probe(struct platform_device *pdev) return PTR_ERR(base); clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(clk)) { - dev_err(&pdev->dev, "unable to get SYS clock, err=%d\n", - status); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "unable to get SYS clock\n"); status = clk_prepare_enable(clk); if (status)
'status' is known to be 0 at this point. The expected error code is PTR_ERR(clk). Switch to dev_err_probe() in order to display the expected error code (in a human readable way). This also filters -EPROBE_DEFER cases, should it happen. Fixes: 1ab7f2a43558 ("staging: mt7621-spi: add mt7621 support") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/spi/spi-mt7621.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)