From patchwork Fri Jan 29 13:37:13 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pietrek, Markus" X-Patchwork-Id: 75751 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o0TE8uTS013700 for ; Fri, 29 Jan 2010 14:09:32 GMT Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1NarWp-0008Hp-Lo; Fri, 29 Jan 2010 14:08:55 +0000 Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.121] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1NarWo-0008Hg-TR for spi-devel-general@lists.sourceforge.net; Fri, 29 Jan 2010 14:08:54 +0000 Received-SPF: pass (sfi-mx-1.v28.ch3.sourceforge.com: domain of emtrion.de designates 80.150.99.69 as permitted sender) client-ip=80.150.99.69; envelope-from=Markus.Pietrek@emtrion.de; helo=mail3.emtrion.de; Received: from mail3.emtrion.de ([80.150.99.69]) by sfi-mx-1.v28.ch3.sourceforge.com with esmtp (Exim 4.69) id 1NarWn-0000Qc-Ie for spi-devel-general@lists.sourceforge.net; Fri, 29 Jan 2010 14:08:54 +0000 Received: from BMK019S01.emtrion.local ([fe80::4a1:cedc:cab6:e9ce]) by BMK019S01.emtrion.local ([fe80::4a1:cedc:cab6:e9ce%10]) with mapi; Fri, 29 Jan 2010 14:37:14 +0100 From: "Pietrek, Markus" To: "spi-devel-general@lists.sourceforge.net" Date: Fri, 29 Jan 2010 14:37:13 +0100 Thread-Topic: [PATCH] Fixed data sampling on the correct edge Thread-Index: Acqg6CoyFlQ2sDmERk6UGCpcNSl3ww== Message-ID: <95F51F4B902CAC40AF459205F6322F0171E8D4987E@BMK019S01.emtrion.local> Accept-Language: de-DE Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: de-DE x-tm-as-product-ver: SMEX-8.0.0.1307-6.000.1038-17160.007 x-tm-as-result: No--34.579400-8.000000-31 x-tm-as-user-approved-sender: No x-tm-as-user-blocked-sender: No MIME-Version: 1.0 X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1NarWn-0000Qc-Ie Cc: Magnus Damm Subject: [spi-devel-general] [PATCH] Fixed data sampling on the correct edge X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Fri, 29 Jan 2010 14:09:32 +0000 (UTC) diff --git a/drivers/spi/spi_sh_msiof.c b/drivers/spi/spi_sh_msiof.c index 51e5e1d..af15e97 100644 --- a/drivers/spi/spi_sh_msiof.c +++ b/drivers/spi/spi_sh_msiof.c @@ -173,13 +173,11 @@ static void sh_msiof_spi_set_pin_regs(struct sh_msiof_spi_priv *p, int edge; /* - * CPOL CPHA TSCKIZ RSCKIZ TEDG REDG(!) - * 0 0 10 10 1 0 - * 0 1 10 10 0 1 - * 1 0 11 11 0 1 - * 1 1 11 11 1 0 - * - * (!) Note: REDG is inverted recommended data sheet setting + * CPOL CPHA TSCKIZ RSCKIZ TEDG REDG + * 0 0 10 10 1 1 + * 0 1 10 10 0 0 + * 1 0 11 11 0 0 + * 1 1 11 11 1 1 */ sh_msiof_write(p, FCTR, 0); @@ -193,7 +191,7 @@ static void sh_msiof_spi_set_pin_regs(struct sh_msiof_spi_priv *p, edge = cpol ? cpha : !cpha; tmp |= edge << 27; /* TEDG */ - tmp |= !edge << 26; /* REDG */ + tmp |= edge << 26; /* REDG */ tmp |= (tx_hi_z ? 2 : 0) << 22; /* TXDIZ */ sh_msiof_write(p, CTR, tmp); }