From patchwork Fri Sep 10 22:57:57 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: wellsk40@gmail.com X-Patchwork-Id: 170522 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o8AMw9p3014512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 10 Sep 2010 22:58:36 GMT Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1OuCXm-0000dg-4y; Fri, 10 Sep 2010 22:58:06 +0000 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1OuCXk-0000db-Q6 for spi-devel-general@lists.sourceforge.net; Fri, 10 Sep 2010 22:58:04 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.216.47 as permitted sender) client-ip=209.85.216.47; envelope-from=wellsk40@gmail.com; helo=mail-qw0-f47.google.com; Received: from mail-qw0-f47.google.com ([209.85.216.47]) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.69) id 1OuCXi-000621-IK for spi-devel-general@lists.sourceforge.net; Fri, 10 Sep 2010 22:58:04 +0000 Received: by qwa26 with SMTP id 26so1761502qwa.34 for ; Fri, 10 Sep 2010 15:57:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.71.69 with SMTP id g5mr867473qcj.176.1284159477202; Fri, 10 Sep 2010 15:57:57 -0700 (PDT) Received: by 10.229.20.74 with HTTP; Fri, 10 Sep 2010 15:57:57 -0700 (PDT) Date: Fri, 10 Sep 2010 15:57:57 -0700 Message-ID: Subject: resend: [PATCH] amba_pl022: Setup SPI configuration based on spi->mode From: Kevin Wells To: sameo@linux.intel.com, rabin.vincent@stericsson.com, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, u.kleine-koenig@pengutronix.de, linux-arm-kernel@lists.infradead.org, tj@kernel.org, grant.likely@secretlab.ca, spi-devel-general@lists.sourceforge.net X-Spam-Score: 0.6 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.47 listed in list.dnswl.org] -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is freemail (wellsk40[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 2.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (wellsk40[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_TO_NO_BRKTS_FREEMAIL T_TO_NO_BRKTS_FREEMAIL -0.0 AWL AWL: From: address is in the auto white-list X-Headers-End: 1OuCXi-000621-IK Cc: Lukasz.Baj@tieto.com X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Fri, 10 Sep 2010 22:58:37 +0000 (UTC) X-MIME-Autoconverted: from quoted-printable to 8bit by demeter1.kernel.org id o8AMw9p3014512 diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c index acd35d1..1be488a 100644 --- a/drivers/spi/amba-pl022.c +++ b/drivers/spi/amba-pl022.c @@ -1248,12 +1248,6 @@ static int destroy_queue(struct pl022 *pl022)  static int verify_controller_parameters(struct pl022 *pl022,                                        struct pl022_config_chip *chip_info)  { -       if ((chip_info->lbm != LOOPBACK_ENABLED) -           && (chip_info->lbm != LOOPBACK_DISABLED)) { -               dev_err(chip_info->dev, -                       "loopback Mode is configured incorrectly\n"); -               return -EINVAL; -       }        if ((chip_info->iface < SSP_INTERFACE_MOTOROLA_SPI)            || (chip_info->iface > SSP_INTERFACE_UNIDIRECTIONAL)) {                dev_err(chip_info->dev, @@ -1279,24 +1273,6 @@ static int verify_controller_parameters(struct pl022 *pl022,                        "cpsdvsr is configured incorrectly\n");                return -EINVAL;        } -       if ((chip_info->endian_rx != SSP_RX_MSB) -           && (chip_info->endian_rx != SSP_RX_LSB)) { -               dev_err(chip_info->dev, -                       "RX FIFO endianess is configured incorrectly\n"); -               return -EINVAL; -       } -       if ((chip_info->endian_tx != SSP_TX_MSB) -           && (chip_info->endian_tx != SSP_TX_LSB)) { -               dev_err(chip_info->dev, -                       "TX FIFO endianess is configured incorrectly\n"); -               return -EINVAL; -       } -       if ((chip_info->data_size < SSP_DATA_BITS_4) -           || (chip_info->data_size > SSP_DATA_BITS_32)) { -               dev_err(chip_info->dev, -                       "DATA Size is configured incorrectly\n"); -               return -EINVAL; -       }        if ((chip_info->com_mode != INTERRUPT_TRANSFER)            && (chip_info->com_mode != DMA_TRANSFER)