From patchwork Thu Sep 1 20:35:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 9309561 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 780DF60756 for ; Thu, 1 Sep 2016 21:04:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C37E29543 for ; Thu, 1 Sep 2016 21:04:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5082E29544; Thu, 1 Sep 2016 21:04:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6E4C29540 for ; Thu, 1 Sep 2016 21:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756366AbcIAVEO (ORCPT ); Thu, 1 Sep 2016 17:04:14 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47618 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756355AbcIAVEM (ORCPT ); Thu, 1 Sep 2016 17:04:12 -0400 Received: from debutante.sirena.org.uk ([2a01:348:6:8808:fab::3] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bfYhx-0003bC-W7; Thu, 01 Sep 2016 20:35:36 +0000 Received: from broonie by debutante with local (Exim 4.87) (envelope-from ) id 1bfYhv-0002y8-0j; Thu, 01 Sep 2016 21:35:31 +0100 From: Mark Brown To: Heiner Kallweit Cc: Mark Brown , Mark Brown , "linux-spi@vger.kernel.org" In-Reply-To: <683bca81-4522-78d7-338f-0e1a137f4f4f@gmail.com> Message-Id: Date: Thu, 01 Sep 2016 21:35:31 +0100 X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Applied "spi: fsl-espi: remove unneeded variable in fsl_espi_do_trans" to the spi tree X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The patch spi: fsl-espi: remove unneeded variable in fsl_espi_do_trans has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From dbd4fefb5b7cba19e3f89c097d93ad02049e38e3 Mon Sep 17 00:00:00 2001 From: Heiner Kallweit Date: Thu, 25 Aug 2016 06:45:55 +0200 Subject: [PATCH] spi: fsl-espi: remove unneeded variable in fsl_espi_do_trans Creating a message, adding one transfer, and then iterating over all transfers in the message doesn't make sense. We can simply use the original transfer directly. Signed-off-by: Heiner Kallweit Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-espi.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index 029017818685..f9ef50444447 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -258,11 +258,9 @@ static void fsl_espi_do_trans(struct spi_message *m, struct spi_device *spi = m->spi; struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master); struct fsl_espi_transfer *espi_trans = tr; - struct spi_message message; struct spi_transfer *t, *first, trans; int status = 0; - spi_message_init(&message); memset(&trans, 0, sizeof(trans)); first = list_first_entry(&m->transfers, struct spi_transfer, @@ -284,23 +282,18 @@ static void fsl_espi_do_trans(struct spi_message *m, trans.len = espi_trans->len; trans.tx_buf = espi_trans->tx_buf; trans.rx_buf = espi_trans->rx_buf; - spi_message_add_tail(&trans, &message); - list_for_each_entry(t, &message.transfers, transfer_list) { - if (t->bits_per_word || t->speed_hz) - fsl_espi_setup_transfer(spi, t); + if (trans.bits_per_word || trans.speed_hz) + fsl_espi_setup_transfer(spi, &trans); - if (t->len) - status = fsl_espi_bufs(spi, t); + if (trans.len) + status = fsl_espi_bufs(spi, &trans); - if (status) { - status = -EMSGSIZE; - break; - } + if (status) + status = -EMSGSIZE; - if (t->delay_usecs) - udelay(t->delay_usecs); - } + if (trans.delay_usecs) + udelay(trans.delay_usecs); espi_trans->status = status; fsl_espi_setup_transfer(spi, NULL);