From patchwork Wed Nov 30 18:07:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 9454671 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6DA7660756 for ; Wed, 30 Nov 2016 18:08:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 672DB28483 for ; Wed, 30 Nov 2016 18:08:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B73228498; Wed, 30 Nov 2016 18:08:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCD1B2848E for ; Wed, 30 Nov 2016 18:08:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758554AbcK3SIO (ORCPT ); Wed, 30 Nov 2016 13:08:14 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36032 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758464AbcK3SII (ORCPT ); Wed, 30 Nov 2016 13:08:08 -0500 Received: from [2001:470:1f1d:6b5::3] (helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cC9IU-0005l3-53; Wed, 30 Nov 2016 18:08:00 +0000 Received: from broonie by debutante with local (Exim 4.87) (envelope-from ) id 1cC9IR-0008NZ-F7; Wed, 30 Nov 2016 18:07:55 +0000 From: Mark Brown To: Heiner Kallweit Cc: Mark Brown , Mark Brown , "linux-spi@vger.kernel.org" In-Reply-To: <4ce7fd3d-bdb2-3e28-a362-b4a61a207a89@gmail.com> Message-Id: Date: Wed, 30 Nov 2016 18:07:55 +0000 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Applied "spi: fsl-espi: remove unused linearization code" to the spi tree X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The patch spi: fsl-espi: remove unused linearization code has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From d54ef0574ade2eab4d203687d53ed20351e323ab Mon Sep 17 00:00:00 2001 From: Heiner Kallweit Date: Sat, 26 Nov 2016 00:00:28 +0100 Subject: [PATCH] spi: fsl-espi: remove unused linearization code After introducing direct transfers between hardware and transfer buffers remove all code which is unused now. This includes getting rid of the 64k linearization buffer. Signed-off-by: Heiner Kallweit Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-espi.c | 80 ---------------------------------------------- 1 file changed, 80 deletions(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index e93892dca90a..cd2832940092 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -95,9 +95,6 @@ struct fsl_espi { struct device *dev; void __iomem *reg_base; - const void *tx; - void *rx; - struct list_head *m_transfers; struct spi_transfer *tx_t; unsigned int tx_pos; @@ -107,11 +104,8 @@ struct fsl_espi { bool rx_done; bool swab; - unsigned int rx_len; - unsigned int tx_len; unsigned int rxskip; - u8 *local_buf; spinlock_t lock; u32 spibrg; /* SPIBRG input clock */ @@ -156,61 +150,6 @@ static inline void fsl_espi_write_reg8(struct fsl_espi *espi, int offset, iowrite8(val, espi->reg_base + offset); } -static void fsl_espi_memcpy_swab(void *to, const void *from, - struct spi_message *m, - struct spi_transfer *t) -{ - struct fsl_espi *espi = spi_master_get_devdata(m->spi->master); - unsigned int len = t->len; - - if (!espi->swab) { - memcpy(to, from, len); - return; - } - - while (len) - if (len >= 4) { - *(u32 *)to = swahb32p(from); - to += 4; - from += 4; - len -= 4; - } else { - *(u16 *)to = swab16p(from); - to += 2; - from += 2; - len -= 2; - } -} - -static void fsl_espi_copy_to_buf(struct spi_message *m, - struct fsl_espi *espi) -{ - struct spi_transfer *t; - u8 *buf = espi->local_buf; - - list_for_each_entry(t, &m->transfers, transfer_list) { - if (t->tx_buf) - fsl_espi_memcpy_swab(buf, t->tx_buf, m, t); - /* In RXSKIP mode controller shifts out zeros internally */ - else if (!espi->rxskip) - memset(buf, 0, t->len); - buf += t->len; - } -} - -static void fsl_espi_copy_from_buf(struct spi_message *m, - struct fsl_espi *espi) -{ - struct spi_transfer *t; - u8 *buf = espi->local_buf; - - list_for_each_entry(t, &m->transfers, transfer_list) { - if (t->rx_buf) - fsl_espi_memcpy_swab(t->rx_buf, buf, m, t); - buf += t->len; - } -} - static int fsl_espi_check_message(struct spi_message *m) { struct fsl_espi *espi = spi_master_get_devdata(m->spi->master); @@ -421,12 +360,6 @@ static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t) u32 mask, spcom; int ret; - espi->rx_len = t->len; - espi->tx_len = t->len; - - espi->tx = t->tx_buf; - espi->rx = t->rx_buf; - reinit_completion(&espi->done); /* Set SPCOM[CS] and SPCOM[TRANLEN] field */ @@ -436,10 +369,7 @@ static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t) /* configure RXSKIP mode */ if (espi->rxskip) { spcom |= SPCOM_RXSKIP(espi->rxskip); - espi->tx_len = espi->rxskip; - espi->rx_len = t->len - espi->rxskip; rx_len = t->len - espi->rxskip; - espi->rx = t->rx_buf + espi->rxskip; if (t->rx_nbits == SPI_NBITS_DUAL) spcom |= SPCOM_DO; } @@ -497,7 +427,6 @@ static int fsl_espi_trans(struct spi_message *m, struct spi_transfer *trans) if (espi->rxskip) espi->rx_t = list_next_entry(espi->rx_t, transfer_list); - fsl_espi_copy_to_buf(m, espi); fsl_espi_setup_transfer(spi, trans); ret = fsl_espi_bufs(spi, trans); @@ -511,7 +440,6 @@ static int fsl_espi_trans(struct spi_message *m, struct spi_transfer *trans) static int fsl_espi_do_one_msg(struct spi_master *master, struct spi_message *m) { - struct fsl_espi *espi = spi_master_get_devdata(m->spi->master); unsigned int delay_usecs = 0, rx_nbits = 0; struct spi_transfer *t, trans = {}; int ret; @@ -534,8 +462,6 @@ static int fsl_espi_do_one_msg(struct spi_master *master, trans.speed_hz = t->speed_hz; trans.bits_per_word = t->bits_per_word; trans.delay_usecs = delay_usecs; - trans.tx_buf = espi->local_buf; - trans.rx_buf = espi->local_buf; trans.rx_nbits = rx_nbits; if (trans.len) @@ -773,12 +699,6 @@ static int fsl_espi_probe(struct device *dev, struct resource *mem, init_completion(&espi->done); - espi->local_buf = devm_kmalloc(dev, SPCOM_TRANLEN_MAX, GFP_KERNEL); - if (!espi->local_buf) { - ret = -ENOMEM; - goto err_probe; - } - espi->reg_base = devm_ioremap_resource(dev, mem); if (IS_ERR(espi->reg_base)) { ret = PTR_ERR(espi->reg_base);