| Message ID | Y+zmrNJ9zjNQpzWq@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0696532e12524855fa8044590d374079f271f216 |
| Headers | show |
| Series | spi: bcmbca-hsspi: Fix error code in probe() function | expand |
On 2/15/23 06:05, Dan Carpenter wrote: > This code accidentally returns success instead of a negative error code. > > Fixes: a38a2233f23b ("spi: bcmbca-hsspi: Add driver for newer HSSPI controller") > Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On 02/15/2023 06:05 AM, Dan Carpenter wrote: > This code accidentally returns success instead of a negative error code. > > Fixes: a38a2233f23b ("spi: bcmbca-hsspi: Add driver for newer HSSPI controller") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > drivers/spi/spi-bcmbca-hsspi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-bcmbca-hsspi.c b/drivers/spi/spi-bcmbca-hsspi.c > index d58033251c02..c14c1969e2cb 100644 > --- a/drivers/spi/spi-bcmbca-hsspi.c > +++ b/drivers/spi/spi-bcmbca-hsspi.c > @@ -546,7 +546,8 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev) > > pm_runtime_enable(&pdev->dev); > > - if (sysfs_create_group(&pdev->dev.kobj, &bcmbca_hsspi_group)) { > + ret = sysfs_create_group(&pdev->dev.kobj, &bcmbca_hsspi_group); > + if (ret) { > dev_err(&pdev->dev, "couldn't register sysfs group\n"); > goto out_pm_disable; > } > Reviewed-by: William Zhang <william.zhang@broadcom.com> Thanks Dan for fixing both drivers!
On Wed, 15 Feb 2023 17:05:32 +0300, Dan Carpenter wrote: > This code accidentally returns success instead of a negative error code. > > Applied to broonie/spi.git for-next Thanks! [1/1] spi: bcmbca-hsspi: Fix error code in probe() function commit: 0696532e12524855fa8044590d374079f271f216 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-bcmbca-hsspi.c b/drivers/spi/spi-bcmbca-hsspi.c index d58033251c02..c14c1969e2cb 100644 --- a/drivers/spi/spi-bcmbca-hsspi.c +++ b/drivers/spi/spi-bcmbca-hsspi.c @@ -546,7 +546,8 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); - if (sysfs_create_group(&pdev->dev.kobj, &bcmbca_hsspi_group)) { + ret = sysfs_create_group(&pdev->dev.kobj, &bcmbca_hsspi_group); + if (ret) { dev_err(&pdev->dev, "couldn't register sysfs group\n"); goto out_pm_disable; }
This code accidentally returns success instead of a negative error code. Fixes: a38a2233f23b ("spi: bcmbca-hsspi: Add driver for newer HSSPI controller") Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/spi/spi-bcmbca-hsspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)