[for-6.14,v4,1/2] pm: runtime: Add new devm functions

Commit Message

Bence Csókás Feb. 10, 2025, 6:56 p.m. UTC

Hi,
This is the PM side of the series. As you can see, it just adds two 
functions in the style of the already-existing `devm_pm_runtime_enable()`.
Bence


-------- Forwarded Message --------
Subject: [PATCH for-6.14 v4 1/2] pm: runtime: Add new devm functions
Date: Mon, 10 Feb 2025 12:10:06 +0100
From: Bence Csókás <[e-mail]>
To: [e-mail], [e-mail]
CC: Bence Csókás <[e-mail]>, Rafael J. Wysocki 
<[e-mail]>, Len Brown <[e-mail]>, Pavel Machek 
<[e-mail]>, Greg Kroah-Hartman <[e-mail]>, 
Danilo Krummrich <[e-mail]>

Add `devm_pm_runtime_set_active()` and
`devm_pm_runtime_get_noresume()` for
simplifying common use cases in drivers.

Signed-off-by: Bence Csókás <[e-mail]>
---
  drivers/base/power/runtime.c | 36 ++++++++++++++++++++++++++++++++++++
  include/linux/pm_runtime.h   |  4 ++++
  2 files changed, 40 insertions(+)

device *dev, bool c) {}
  static inline void pm_runtime_allow(struct device *dev) {}
  static inline void pm_runtime_forbid(struct device *dev) {}
  +static inline int devm_pm_runtime_set_active(struct device *dev) { 
return 0; }
  static inline int devm_pm_runtime_enable(struct device *dev) { return 0; }
+static inline int devm_pm_runtime_get_noresume(struct device *dev) { 
return 0; }
   static inline void pm_suspend_ignore_children(struct device *dev, 
bool enable) {}
  static inline void pm_runtime_get_noresume(struct device *dev) {}

Comments

Mark Brown Feb. 10, 2025, 7:20 p.m. UTC | #1

On Mon, Feb 10, 2025 at 07:56:07PM +0100, Csókás Bence wrote:

> This is the PM side of the series. As you can see, it just adds two
> functions in the style of the already-existing `devm_pm_runtime_enable()`.

That might indeed be trivial enough for a fix - let me know whenever the
PM people have reviewed it.

Patch

diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 2ee45841486b..f0a6c64bec19 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -1545,6 +1545,24 @@  void pm_runtime_enable(struct device *dev)
  }
  EXPORT_SYMBOL_GPL(pm_runtime_enable);
  +static void pm_runtime_set_suspended_action(void *data)
+{
+	pm_runtime_set_suspended(data);
+}
+
+/**
+ * devm_pm_runtime_set_active - devres-enabled version of 
pm_runtime_set_active.
+ *
+ * @dev: Device to handle.
+ */
+int devm_pm_runtime_set_active(struct device *dev)
+{
+	pm_runtime_set_active(dev);
+
+	return devm_add_action_or_reset(dev, pm_runtime_set_suspended_action, 
dev);
+}
+EXPORT_SYMBOL_GPL(devm_pm_runtime_set_active);
+
  static void pm_runtime_disable_action(void *data)
  {
  	pm_runtime_dont_use_autosuspend(data);
@@ -1567,6 +1585,24 @@  int devm_pm_runtime_enable(struct device *dev)
  }
  EXPORT_SYMBOL_GPL(devm_pm_runtime_enable);
  +static void pm_runtime_put_noidle_action(void *data)
+{
+	pm_runtime_put_noidle(data);
+}
+
+/**
+ * devm_pm_runtime_get_noresume - devres-enabled version of 
pm_runtime_get_noresume.
+ *
+ * @dev: Device to handle.
+ */
+int devm_pm_runtime_get_noresume(struct device *dev)
+{
+	pm_runtime_get_noresume(dev);
+
+	return devm_add_action_or_reset(dev, pm_runtime_put_noidle_action, dev);
+}
+EXPORT_SYMBOL_GPL(devm_pm_runtime_get_noresume);
+
  /**
   * pm_runtime_forbid - Block runtime PM of a device.
   * @dev: Device to handle.
diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
index d39dc863f612..d7eca86150b8 100644
--- a/include/linux/pm_runtime.h
+++ b/include/linux/pm_runtime.h
@@ -93,7 +93,9 @@  extern void pm_runtime_new_link(struct device *dev);
  extern void pm_runtime_drop_link(struct device_link *link);
  extern void pm_runtime_release_supplier(struct device_link *link);
  +int devm_pm_runtime_set_active(struct device *dev);
  extern int devm_pm_runtime_enable(struct device *dev);
+int devm_pm_runtime_get_noresume(struct device *dev);
   /**
   * pm_suspend_ignore_children - Set runtime PM behavior regarding 
children.
@@ -276,7 +278,9 @@  static inline void __pm_runtime_disable(struct