| Message ID | a90bec10dec43719b12afdb967e87526c4bc849a.1654933052.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 116679aef2f92d535ea8049ef2a610bc73f94660 |
| Headers | show |
| Series | spi: microchip-core: Fix the error handling path in mchp_corespi_probe() | expand |
On 11/06/2022 08:37, Christophe JAILLET wrote: > clk_prepare_enable() is called instead of clk_disable_unprepare() in the > error handling path of the probe function. > > Change the function that is called so that resources are released > correctly. > > Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Hey Christophe, Peng Wu already sent a patch for this, but thanks for trying to clean up after me anyway. Thanks, Conor. > --- > drivers/spi/spi-microchip-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c > index 5b2aee30fa04..bf6847d95fe3 100644 > --- a/drivers/spi/spi-microchip-core.c > +++ b/drivers/spi/spi-microchip-core.c > @@ -580,7 +580,7 @@ static int mchp_corespi_probe(struct platform_device *pdev) > > error_release_hardware: > mchp_corespi_disable(spi); > - clk_prepare_enable(spi->clk); > + clk_disable_unprepare(spi->clk); > error_release_master: > spi_master_put(master); >
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c index 5b2aee30fa04..bf6847d95fe3 100644 --- a/drivers/spi/spi-microchip-core.c +++ b/drivers/spi/spi-microchip-core.c @@ -580,7 +580,7 @@ static int mchp_corespi_probe(struct platform_device *pdev) error_release_hardware: mchp_corespi_disable(spi); - clk_prepare_enable(spi->clk); + clk_disable_unprepare(spi->clk); error_release_master: spi_master_put(master);
clk_prepare_enable() is called instead of clk_disable_unprepare() in the error handling path of the probe function. Change the function that is called so that resources are released correctly. Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/spi/spi-microchip-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)