From patchwork Fri Apr 27 11:02:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10368155 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 62F50601D3 for ; Fri, 27 Apr 2018 11:02:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52CC729329 for ; Fri, 27 Apr 2018 11:02:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 475582936C; Fri, 27 Apr 2018 11:02:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1D7629329 for ; Fri, 27 Apr 2018 11:02:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932784AbeD0LCb (ORCPT ); Fri, 27 Apr 2018 07:02:31 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36640 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932700AbeD0LC3 (ORCPT ); Fri, 27 Apr 2018 07:02:29 -0400 Received: by mail-pf0-f196.google.com with SMTP id g14so1243703pfh.3; Fri, 27 Apr 2018 04:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=QmZqLalP/CIE6cCv5UajDm1VvFaqMW5iTzxj1BKMz/k=; b=SAdj6m2wOS/zqjo/dwJg/NYTbuhLnkUG1y0dAWogloBb79N6oTXR6bN/eaczwXlOKX t5SMUjEi7B0hs7Q+aL7LhWFbS/pW5yJaUYup1hAyQtqn4tyk14DvlBQFNBAFajr5Bu0/ 7EFTV2RMoBFm0+ifqt3xZzvEJNtsPAt8yvU9xqm+lPTyArpm90Qm40Qbld1CCwlaKjcR Alti2yCGtWKOe16Xgj3QAFqAlkImBrL7vghOwnLm3FtgdZIDrDQYSZrweXjiRpqFUCFf dq6N7P0DbqqFyp1k9I8ognNSHaFPrZ5PU7/Ky4on1tM2IEaLmzjqZVgmYhMPnU70pGl8 8Bmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QmZqLalP/CIE6cCv5UajDm1VvFaqMW5iTzxj1BKMz/k=; b=I81VHiD+8tu5Mv2s9BLHoxIt5qDCfngu0KOHiAMOtPLLk7OUsWYzGil+XD0ZWmIYPC /Au2Z6BEQ1CBaN0N1M4lEGV84T1YJGiZiFdEmyJzcXaO9++8CjLLSjxAlHh64BDysZ+p 1tf2tPY4PUsWA0hHK6cuBnM/EVXGMaVNwP/3RBxeWmKwdF5bM15kfcMYYX4ylAYHDQE5 LNXV1KdbBn9/iisDxtPQkx5EQumcC1omibRLRNw/GwlKC7Dk1kcYrmeA6/fLEvYFPckQ T93jEd5iLeAyTq0a9WuOzN+mqHxZ0UTqiW9RBG0WXkV54dShPSlh3B7UtFLreEaAMKqT Zs2w== X-Gm-Message-State: ALQs6tCUbkOWHN8wKpm6EZBUQXuxLlCDXOxHLVwe+8uq8QMuGaAyAHgv H9Bidj3wHeYJ1RfwZLRHKbk= X-Google-Smtp-Source: AB8JxZrQ2sKRMRqWVFpImAx2a1N36P/k8oavkofTHu9q61H0WAosxA04/QqxOWUfYT9/dZQEuGc2ZA== X-Received: by 2002:a17:902:aa90:: with SMTP id d16-v6mr1875151plr.189.1524826948539; Fri, 27 Apr 2018 04:02:28 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id r68sm3172401pfi.174.2018.04.27.04.02.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 Apr 2018 04:02:27 -0700 (PDT) From: Arvind Yadav To: broonie@kernel.org Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: [PATCH] spi: mpc52xx: Use gpio_is_valid() Date: Fri, 27 Apr 2018 16:32:17 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace the manual validity checks for the GPIO with the gpio_is_valid(). Signed-off-by: Arvind Yadav --- drivers/spi/spi-mpc52xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mpc52xx.c b/drivers/spi/spi-mpc52xx.c index e8b59ce..0e55784 100644 --- a/drivers/spi/spi-mpc52xx.c +++ b/drivers/spi/spi-mpc52xx.c @@ -447,7 +447,7 @@ static int mpc52xx_spi_probe(struct platform_device *op) for (i = 0; i < ms->gpio_cs_count; i++) { gpio_cs = of_get_gpio(op->dev.of_node, i); - if (gpio_cs < 0) { + if (!gpio_is_valid(gpio_cs)) { dev_err(&op->dev, "could not parse the gpio field in oftree\n"); rc = -ENODEV;