| Message ID | b63db431cbf35223a4400e44c296293d32c4543c.1742998909.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d32c4e58545f17caaa854415f854691e32d42075 |
| Headers | show |
| Series | spi: SPI_QPIC_SNAND should be tristate and depend on MTD | expand |
On Wed, 26 Mar 2025 15:22:19 +0100, Geert Uytterhoeven wrote: > SPI_QPIC_SNAND is the only driver that selects MTD instead of depending > on it, which could lead to circular dependencies. Moreover, as > SPI_QPIC_SNAND is bool, this forces MTD (and various related symbols) to > be built-in, as can be seen in an allmodconfig kernel. > > Except for a missing semicolon, there is no reason why SPI_QPIC_SNAND > cannot be tristate; all MODULE_*() boilerplate is already present. > Hence make SPI_QPIC_SNAND tristate, let it depend on MTD, and add the > missing semicolon. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: SPI_QPIC_SNAND should be tristate and depend on MTD commit: d32c4e58545f17caaa854415f854691e32d42075 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index c18bb46ed13fea9a..0121ecb13d541799 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -945,9 +945,9 @@ config SPI_QCOM_QSPI QSPI(Quad SPI) driver for Qualcomm QSPI controller. config SPI_QPIC_SNAND - bool "QPIC SNAND controller" + tristate "QPIC SNAND controller" depends on ARCH_QCOM || COMPILE_TEST - select MTD + depends on MTD help QPIC_SNAND (QPIC SPI NAND) driver for Qualcomm QPIC controller. QPIC controller supports both parallel nand and serial nand. diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index fbba7741a9bf336d..17eb67e19132612c 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -1614,7 +1614,7 @@ static const struct of_device_id qcom_snandc_of_match[] = { .data = &ipq9574_snandc_props, }, {} -} +}; MODULE_DEVICE_TABLE(of, qcom_snandc_of_match); static struct platform_driver qcom_spi_driver = {
SPI_QPIC_SNAND is the only driver that selects MTD instead of depending on it, which could lead to circular dependencies. Moreover, as SPI_QPIC_SNAND is bool, this forces MTD (and various related symbols) to be built-in, as can be seen in an allmodconfig kernel. Except for a missing semicolon, there is no reason why SPI_QPIC_SNAND cannot be tristate; all MODULE_*() boilerplate is already present. Hence make SPI_QPIC_SNAND tristate, let it depend on MTD, and add the missing semicolon. Fixes: 7304d1909080ef0c ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Compile-tested only. --- drivers/spi/Kconfig | 4 ++-- drivers/spi/spi-qpic-snand.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)