| Message ID | e259bb1c87e32c67295747f868f8684c1e929d68.1479985886.git.nicolas.ferre@atmel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ce24a513fb142e855b4aa77f91334c2f203c0d99 |
| Headers | show |
On Thu, Nov 24, 2016 at 12:24:57PM +0100, Nicolas Ferre wrote: > The info banner is here to tell that everything went well, so place > it at the very end of the probe function. Really we should just drop this, the banner is only telling us things enumerated from DT so it's adding noise to the boot.
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index a038ffe90766..68e22bf94647 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -1658,10 +1658,6 @@ static int atmel_spi_probe(struct platform_device *pdev) spi_writel(as, CR, SPI_BIT(FIFOEN)); } - /* go! */ - dev_info(&pdev->dev, "Atmel SPI Controller at 0x%08lx (irq %d)\n", - (unsigned long)regs->start, irq); - pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_active(&pdev->dev); @@ -1671,6 +1667,10 @@ static int atmel_spi_probe(struct platform_device *pdev) if (ret) goto out_free_dma; + /* go! */ + dev_info(&pdev->dev, "Atmel SPI Controller at 0x%08lx (irq %d)\n", + (unsigned long)regs->start, irq); + return 0; out_free_dma:
The info banner is here to tell that everything went well, so place it at the very end of the probe function. Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> --- drivers/spi/spi-atmel.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)