mbox series

[0/3] vhost/scsi: Respond to control queue operations

Message ID 1537229389-16176-1-git-send-email-bijan.mottahedeh@oracle.com (mailing list archive)
Headers show
Series vhost/scsi: Respond to control queue operations | expand

Message

Bijan Mottahedeh Sept. 18, 2018, 12:09 a.m. UTC
This patch series causes vhost-scsi control queue TMF requests to be
explicitly rejected rather than implicitly ignored in order to prevent
a guest virito-scsi driver to wait indefinitely for a response to a SCSI
TMF request.

In addition, control queue address notification operations
(VIRTIO_SCSI_T_AN_*) get an effective no-op response.

Patch 1/3 implements a control queue handler modeled after the existing
request queue handler.  There is no commonality between the two handlers.

Patch 2/3 factors out the common processing code from the control queue
handler into separate routines.

Patch 3/3 modifies the request handler to use the common processing routines.  

Bijan Mottahedeh (3):
  vhost/scsi: Respond to control queue operations
  vhost/scsi: Extract common handling code from control queue handler
  vhost/scsi: Use common handling code in request queue handler

 drivers/vhost/scsi.c | 422 +++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 326 insertions(+), 96 deletions(-)

Comments

Bijan Mottahedeh Oct. 1, 2018, 6:31 p.m. UTC | #1
Hello,

A reminder to please review this patch series.

Thank you.

Bijan Mottahedeh

> This patch series causes vhost-scsi control queue TMF requests to be
> explicitly rejected rather than implicitly ignored in order to prevent
> a guest virito-scsi driver to wait indefinitely for a response to a SCSI
> TMF request.
>
> In addition, control queue address notification operations
> (VIRTIO_SCSI_T_AN_*) get an effective no-op response.
>
> Patch 1/3 implements a control queue handler modeled after the existing
> request queue handler.  There is no commonality between the two handlers.
>
> Patch 2/3 factors out the common processing code from the control queue
> handler into separate routines.
>
> Patch 3/3 modifies the request handler to use the common processing routines.
>
> Bijan Mottahedeh (3):
>    vhost/scsi: Respond to control queue operations
>    vhost/scsi: Extract common handling code from control queue handler
>    vhost/scsi: Use common handling code in request queue handler
>
>   drivers/vhost/scsi.c | 422 +++++++++++++++++++++++++++++++++++++++------------
>   1 file changed, 326 insertions(+), 96 deletions(-)
>
Bijan Mottahedeh Oct. 8, 2018, 9:25 p.m. UTC | #2
A second reminder to please review this patch series.

Thanks.

--bijan

> Hello,
>
> A reminder to please review this patch series.
>
> Thank you.
>
> Bijan Mottahedeh
>
>> This patch series causes vhost-scsi control queue TMF requests to be
>> explicitly rejected rather than implicitly ignored in order to prevent
>> a guest virito-scsi driver to wait indefinitely for a response to a SCSI
>> TMF request.
>>
>> In addition, control queue address notification operations
>> (VIRTIO_SCSI_T_AN_*) get an effective no-op response.
>>
>> Patch 1/3 implements a control queue handler modeled after the existing
>> request queue handler.  There is no commonality between the two 
>> handlers.
>>
>> Patch 2/3 factors out the common processing code from the control queue
>> handler into separate routines.
>>
>> Patch 3/3 modifies the request handler to use the common processing 
>> routines.
>>
>> Bijan Mottahedeh (3):
>>    vhost/scsi: Respond to control queue operations
>>    vhost/scsi: Extract common handling code from control queue handler
>>    vhost/scsi: Use common handling code in request queue handler
>>
>>   drivers/vhost/scsi.c | 422 
>> +++++++++++++++++++++++++++++++++++++++------------
>>   1 file changed, 326 insertions(+), 96 deletions(-)
>>
>