From patchwork Wed Dec 5 12:18:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Disseldorp X-Patchwork-Id: 10713949 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 48C3E18B8 for ; Wed, 5 Dec 2018 12:18:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34CBF2C13E for ; Wed, 5 Dec 2018 12:18:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 229612C2CA; Wed, 5 Dec 2018 12:18:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C98EE2C2B3 for ; Wed, 5 Dec 2018 12:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbeLEMSt (ORCPT ); Wed, 5 Dec 2018 07:18:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:46216 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727267AbeLEMSs (ORCPT ); Wed, 5 Dec 2018 07:18:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id ADD4DB7BF; Wed, 5 Dec 2018 12:18:46 +0000 (UTC) From: David Disseldorp To: target-devel@vger.kernel.org Cc: bvanassche@acm.org, lduncan@suse.com, hare@suse.com, bly@catalogicsoftware.com, r.bolshakov@yadro.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Subject: [PATCH v7 0/5] target: user configurable T10 Vendor ID Date: Wed, 5 Dec 2018 13:18:33 +0100 Message-Id: <20181205121838.23982-1-ddiss@suse.de> X-Mailer: git-send-email 2.13.7 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch-set allows for the modification of the T10 Vendor Identification string returned in the SCSI INQUIRY response, via the target/core/$backstore/$name/wwn/vendor_id ConfigFS path. Changes since v6: - PATCH 2/5 + fill pscsi inquiry data using proper sd->inquiry pointer names + dump pscsi sd->inquiry data using sprintf + tweak emulate_model_alias truncation warning + drop a few duplicate BUILD_BUG_ON()s + drop Hannes' sign-off - PATCH 3/5 + check user vendor string for non-ascii-printable chars + strip newline before INQUIRY_VENDOR_LEN length check + drop sign-offs from Bryant, Lee and Hannes Changes since v5: - remove unnecessary TRANSPORT_FLAG_PASSTHROUGH conditional from t10_wwn ID defaults initialisation. Changes since v4: - merge null-termination changes into a single patch - add patch to initialise t10_wwn ID defaults earlier - use strlcpy() instead of strncpy() in some places Changes since v3: - perform explicit null termination of t10_wwn vendor, model and revision fields. - replace field dump for-loops Changes since v2: - https://www.spinics.net/lists/target-devel/msg10720.html - Support eight byte vendor ID strings - Split out consistent INQUIRY data padding as a separate patch - Drop t10_wwn.model buffer print fix, already upstream Changes since v1: - https://www.spinics.net/lists/target-devel/msg10545.html - Rebase against nab's for-next branch, which includes Christoph's configfs API changes. David Disseldorp (5): target: use consistent left-aligned ASCII INQUIRY data target: consistently null-terminate t10_wwn strings target: add device vendor_id configfs attribute target: remove hardcoded T10 Vendor ID in INQUIRY response target: perform t10_wwn ID initialisation in target_alloc_device() drivers/target/target_core_configfs.c | 86 +++++++++++++++++++++++++-- drivers/target/target_core_device.c | 55 +++++------------ drivers/target/target_core_pscsi.c | 50 +++++----------- drivers/target/target_core_spc.c | 20 +++++-- drivers/target/target_core_stat.c | 32 +++------- include/target/target_core_base.h | 14 ++++- 6 files changed, 145 insertions(+), 112 deletions(-)