mbox series

[0/3] Fix possible hangs and race conditions during login

Message ID 20230310100423.1258256-1-mlombard@redhat.com (mailing list archive)
Headers show
Series Fix possible hangs and race conditions during login | expand


Maurizio Lombardi March 10, 2023, 10:04 a.m. UTC
PATCH 1 fixes a possible hang when during a login operation the initiator
stops sending data to the target and the login_work doesn't get scheduled
by the sk_data_ready callback.

PATCH 3 fixes a bug in iscsi_target_locate_portal(), in the error
code path the login semaphore may end up being released even if
no one called down() against it, this may allow
multiple threads to access the semaphore-protected code.

Maurizio Lombardi (3):
  target: iscsi: fix hang in the iSCSI login code
  target: iscsi: remove unused transport_timer
  target: iscsi: prevent login threads from racing between each other

 drivers/target/iscsi/iscsi_target_login.c |  1 +
 drivers/target/iscsi/iscsi_target_nego.c  | 60 +++++++++++------------
 drivers/target/iscsi/iscsi_target_util.c  | 26 ++++++++++
 drivers/target/iscsi/iscsi_target_util.h  |  3 ++
 include/target/iscsi/iscsi_target_core.h  |  2 +-
 5 files changed, 59 insertions(+), 33 deletions(-)