[v5,0/9] target: TMF and recovery fixes

Message

Mike Christie March 19, 2023, 1:56 a.m. UTC

The following patches apply over Martin's 6.4 branches and Linus's tree.
They fix a couple regressions in iscsit that occur when there are TMRs
executing and a connection is closed. It also includes Dimitry's fixes in
related code paths for cmd cleanup when ERL2 is used and the write pending
hang during conn cleanup.

This version of the patchset brings it back to just regressions and fixes
for bugs we have a lot of users hitting. I'm going to fix isert and get it
hooked into iscsit properly in a second patchset, because this one was
getting so large. I've also moved my cleanup type of patches for a 3rd
patchset.

v5:
- Fix
scsi: target: Fix multiple LUN_RESET handling
so we don't execute a reset before it's submited.
- Move isert changes to separate patchset.
- Add write pending fix.
v4:
- Fix
[PATCH v3 07/14] scsi: target: Fix multiple LUN_RESET handling
so it doesn't add back the bug where resets can wait on each other
and deadlock.
- Updated
[PATCH v3 06/14] scsi: target: iscsit: Fix TAS handling during conn
so it handles the case where commands have passed the STOP checks and
have not yet hit them.
- Added patch to handle another hang found while testnig where we wait
on the free_compl but never drop a ref due to being in the wrong state.
v3:
- Drop patch "iscsit: Fix isert disconnect handling during login"
- Add patch to drop cmd lock in completion callout
- Add patch to clean up recovery commands earlier when ERL2 is used
- Add patch to handle use-after-free in isert
v2:
- Fix wait/stop use during login failures
- Add patches to support isert

Comments

Martin K. Petersen March 24, 2023, 9:40 p.m. UTC | #1

Mike,

> The following patches apply over Martin's 6.4 branches and Linus's
> tree.  They fix a couple regressions in iscsit that occur when there
> are TMRs executing and a connection is closed. It also includes
> Dimitry's fixes in related code paths for cmd cleanup when ERL2 is
> used and the write pending hang during conn cleanup.
>
> This version of the patchset brings it back to just regressions and
> fixes for bugs we have a lot of users hitting. I'm going to fix isert
> and get it hooked into iscsit properly in a second patchset, because
> this one was getting so large. I've also moved my cleanup type of
> patches for a 3rd patchset.

Applied to 6.4/scsi-staging, thanks!

Martin K. Petersen April 3, 2023, 2:15 a.m. UTC | #2

On Sat, 18 Mar 2023 20:56:11 -0500, Mike Christie wrote:

> The following patches apply over Martin's 6.4 branches and Linus's tree.
> They fix a couple regressions in iscsit that occur when there are TMRs
> executing and a connection is closed. It also includes Dimitry's fixes in
> related code paths for cmd cleanup when ERL2 is used and the write pending
> hang during conn cleanup.
> 
> This version of the patchset brings it back to just regressions and fixes
> for bugs we have a lot of users hitting. I'm going to fix isert and get it
> hooked into iscsit properly in a second patchset, because this one was
> getting so large. I've also moved my cleanup type of patches for a 3rd
> patchset.
> 
> [...]

Applied to 6.4/scsi-queue, thanks!

[1/9] scsi: target: Move sess cmd counter to new struct
      https://git.kernel.org/mkp/scsi/c/becd9be6069e
[2/9] scsi: target: Move cmd counter allocation
      https://git.kernel.org/mkp/scsi/c/4edba7e4a8f3
[3/9] scsi: target: Pass in cmd counter to use during cmd setup
      https://git.kernel.org/mkp/scsi/c/8e288be8606a
[4/9] scsi: target: iscsit/isert: Alloc per conn cmd counter
      https://git.kernel.org/mkp/scsi/c/6d256bee602b
[5/9] scsi: target: iscsit: stop/wait on cmds during conn close
      https://git.kernel.org/mkp/scsi/c/395cee83d02d
[6/9] scsi: target: iscsit: free cmds before session free
      https://git.kernel.org/mkp/scsi/c/d8990b5a4d06
[7/9] scsi: target: Fix multiple LUN_RESET handling
      https://git.kernel.org/mkp/scsi/c/673db054d7a2
[8/9] scsi: target: iscsit: Fix TAS handling during conn cleanup
      https://git.kernel.org/mkp/scsi/c/cc79da306ebb
[9/9] scsi: target: iscsi: handle abort for WRITE_PENDING cmds
      https://git.kernel.org/mkp/scsi/c/ea87981a0ee8