diff mbox

ibmvscsis: Add SGL limit

Message ID 1486397068-60338-1-git-send-email-bryantly@linux.vnet.ibm.com (mailing list archive)
State Accepted
Headers show

Commit Message

Bryant G. Ly Feb. 6, 2017, 4:04 p.m. UTC
This patch adds internal LIO sgl limit since the driver already
sets a max transfer limit on transport layer of 1MB to the client.

Cc: stable@vger.kernel.org
Tested-by: Steven Royer <seroyer@linux.vnet.ibm.com>
Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
---
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nicholas A. Bellinger Feb. 8, 2017, 6:49 p.m. UTC | #1
Hi Bryant,

(Adding the list CC' back)

On Wed, 2017-02-08 at 11:13 -0600, Bryant G. Ly wrote:
> This patch adds internal LIO sgl limit since the driver already
> sets a max transfer limit on transport layer of 1MB to the client.
> 
> Cc: stable@vger.kernel.org
> Tested-by: Steven Royer <seroyer@linux.vnet.ibm.com>
> Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> ---
>   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> index dfe4778..4bb5635 100644
> --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> @@ -3818,6 +3818,7 @@ static struct configfs_attribute *ibmvscsis_tpg_attrs[] = {
>   static const struct target_core_fabric_ops ibmvscsis_ops = {
>   	.module				= THIS_MODULE,
>   	.name				= "ibmvscsis",
> +	.max_data_sg_nents		= MAX_TXU / PAGE_SIZE,
>   	.get_fabric_name		= ibmvscsis_get_fabric_name,
>   	.tpg_get_wwn			= ibmvscsis_get_fabric_wwn,
>   	.tpg_get_tag			= ibmvscsis_get_tag,
> Hi Nic,
>
> Good to see you back, can you include this with the v4.10 series you
> plan to send to Linus soon?
>
> Thanks,
>
> Bryant

Sure, will include this into the v4.10 fixes PULL request.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bart Van Assche Feb. 8, 2017, 7:15 p.m. UTC | #2
On Wed, 2017-02-08 at 10:49 -0800, Nicholas A. Bellinger wrote:
> Sure, will include this into the v4.10 fixes PULL request.

If the new version of my patch series that I will post soon will not be
included in that pull request I will ask Linus to ignore your pull request.

Bart.--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nicholas A. Bellinger Feb. 8, 2017, 10:33 p.m. UTC | #3
On Wed, 2017-02-08 at 19:15 +0000, Bart Van Assche wrote:
> On Wed, 2017-02-08 at 10:49 -0800, Nicholas A. Bellinger wrote:
> > Sure, will include this into the v4.10 fixes PULL request.
> 
> If the new version of my patch series that I will post soon will not be
> included in that pull request I will ask Linus to ignore your pull request.
> 

Like I said, I'm sending bug-fixes to Linus for v4.10 with stable CC's
for customer issues we've encountered over the last months, and that my
QA team has verified in our nightly automation runs.

Considering you don't have any dedicated QA resources committed at your
company for upstream target, nor production customers at Sandisk who are
using LIO (I checked), you aren't really in a position to say who sends
what to mainline.



--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index dfe4778..4bb5635 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3818,6 +3818,7 @@  static struct configfs_attribute *ibmvscsis_tpg_attrs[] = {
 static const struct target_core_fabric_ops ibmvscsis_ops = {
 	.module				= THIS_MODULE,
 	.name				= "ibmvscsis",
+	.max_data_sg_nents		= MAX_TXU / PAGE_SIZE,
 	.get_fabric_name		= ibmvscsis_get_fabric_name,
 	.tpg_get_wwn			= ibmvscsis_get_fabric_wwn,
 	.tpg_get_tag			= ibmvscsis_get_tag,