From patchwork Thu Mar 9 13:16:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 9613353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E23AB604DD for ; Thu, 9 Mar 2017 13:20:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D456628518 for ; Thu, 9 Mar 2017 13:20:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C93512851A; Thu, 9 Mar 2017 13:20:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86A2E2860C for ; Thu, 9 Mar 2017 13:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754585AbdCINU1 (ORCPT ); Thu, 9 Mar 2017 08:20:27 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:41551 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754769AbdCINUX (ORCPT ); Thu, 9 Mar 2017 08:20:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3bYpkCnBsAHQ2PKamoZkCPTUqlN6JUFjZ/BUn+hMM/g=; b=fs2x0lObqiax+TCc+Sktjt/dn qX4lAibq58tzaUebvGY7E65vWIAIWR9Fr1MLeUK4NVUo/OFKasYTx6Spgcs4b1Hij8mc3RTaajEdq 8rZzM98QRHJkY2GAdWn1QZlniF2r2FcuDRw+n8oR+8v1DTv1pJvRnQJw6H/1YYHYvA/sTBweuc1EG 0cH22PXjmQanYJnKWir2Ncmf3JNNUaSBPNdnWXjN+HTip11PQe5Xnv3qejkCDaadgAeG3R025oi// 1Jqc6KQFIv8vTArQKshovUO/PCXbWOHV5p+3Seyiq4KqmzmZ5j4UmEu4fPb/JJ/E5S1pv6ci9XVzq oX4SX5/7A==; Received: from bzq-82-81-101-184.red.bezeqint.net ([82.81.101.184] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1clxwp-0001My-Jh; Thu, 09 Mar 2017 13:17:40 +0000 From: Sagi Grimberg To: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH rfc 10/10] target: Use non-selective polling Date: Thu, 9 Mar 2017 15:16:42 +0200 Message-Id: <1489065402-14757-11-git-send-email-sagi@grimberg.me> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1489065402-14757-1-git-send-email-sagi@grimberg.me> References: <1489065402-14757-1-git-send-email-sagi@grimberg.me> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't really make sense to do selective polling because we never care about specific IOs. Non selective polling can actually help by doing some useful work while we're submitting a command. We ask for a batch of (magic) 4 completions which looks like a decent network<->backend proportion, if less are available we'll see less. Signed-off-by: Sagi Grimberg --- drivers/target/target_core_iblock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index d316ed537d59..00726b6e51c4 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c @@ -757,6 +757,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, } iblock_submit_bios(&list); + blk_mq_poll_batch(bdev_get_queue(IBLOCK_DEV(dev)->ibd_bd), 4); iblock_complete_cmd(cmd); return 0;