From patchwork Wed Jan 25 23:36:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9538155 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B3336042C for ; Wed, 25 Jan 2017 23:37:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 713B727F17 for ; Wed, 25 Jan 2017 23:37:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65F9227FB0; Wed, 25 Jan 2017 23:37:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B6AD827FBB for ; Wed, 25 Jan 2017 23:37:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbdAYXh3 (ORCPT ); Wed, 25 Jan 2017 18:37:29 -0500 Received: from mail-dm3nam03on0040.outbound.protection.outlook.com ([104.47.41.40]:3443 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751839AbdAYXhQ (ORCPT ); Wed, 25 Jan 2017 18:37:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandiskcorp.onmicrosoft.com; s=selector1-sandisk-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a5Zp4cIH7DANsabWi9cYeks3Yj/3lWFp1jkmSXEVmkw=; b=os5Pnir6V0RwVcZ+NF9t3PfHhpSwU1KOI8k8Sj7rwWoAUApgFC0dwFU98ladRe+bPJRRH1PGiswJpluP82nd7970TTzULcodL1JA/gcT9KgJocPoBTjGrXmWAHTLSyu7IH3Y7aLzONrVFI3ZPNU/c94v+bNVH1hSYEQzqwjQZI0= Received: from BLUPR0201CA0010.namprd02.prod.outlook.com (10.163.116.20) by SN1PR02MB1423.namprd02.prod.outlook.com (10.162.0.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Wed, 25 Jan 2017 23:36:57 +0000 Received: from BL2FFO11FD038.protection.gbl (2a01:111:f400:7c09::173) by BLUPR0201CA0010.outlook.office365.com (2a01:111:e400:52e7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Wed, 25 Jan 2017 23:36:56 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; linux-iscsi.org; dkim=none (message not signed) header.d=none;linux-iscsi.org; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BL2FFO11FD038.mail.protection.outlook.com (10.173.161.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.8 via Frontend Transport; Wed, 25 Jan 2017 23:36:56 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 7C.C8.65426.6C339885; Wed, 25 Jan 2017 15:24:55 -0800 (PST) Received: from milsmgip11.sandisk.com (10.177.9.6) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.319.2; Wed, 25 Jan 2017 15:36:50 -0800 X-AuditID: 0ac94369-b62949800001ff92-33-588933c6f2c3 Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.9.6]) by (Symantec Messaging Gateway) with SMTP id 7F.35.16817.29639885; Wed, 25 Jan 2017 15:36:50 -0800 (PST) From: Bart Van Assche To: Bart Van Assche CC: , "Nicholas A . Bellinger" , Christoph Hellwig , David Disseldorp Subject: [PATCH 27/34] target: Reduce number of __transport_wait_for_tasks() arguments Date: Wed, 25 Jan 2017 15:36:39 -0800 Message-ID: <20170125233646.2243-28-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170125233646.2243-1-bart.vanassche@sandisk.com> References: <20170125233646.2243-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsXCddJ5ke5x484Ig9dzGC2+/p/OYrFy9VEm i7bVZxgtWpe+ZXJg8bi//QiTx+6bDWwem09Xe3zeJBfAEsVlk5Kak1mWWqRvl8CV8WLeD/aC KbIV7w4rNjCuluhi5OSQEDCRmHHjGRuILSSwlEniV7NYFyMXkL2NUaL7x1RWmKJZE7pZIBIb GSVeTTzEDJJgEzCS+PZ+JguILSJgIPG79wIjSBGzwAxGiTdbnwElODiEBcIkdv7QAKlhEVCV +PVqFROIzStgL9H66QsTxAJ5iV1tF8GWcYLEz/5kgbjITmL9gVYmkJkSAk2sEkdO/2eGaBaU ODnzCVgRs4CExMEXL5ghGtQlTi6ZzzSBUWgWkrJZSMoWMDKtYhTLzcwpzk1PLTA01StOzEvJ LM7WS87P3cQICevMHYx3n3gfYhTgYFTi4RXY0hEhxJpYVlyZe4hRgoNZSYR3nVxnhBBvSmJl VWpRfnxRaU5q8SFGaQ4WJXFet3tfwoQE0hNLUrNTUwtSi2CyTBycUg2M8V96rvzp6Aicofyd sXLrwtBM8xkSAo/eTl1acHbBSb1qq58v+xibJhvaZXx7zRT+/quH2omnCaZmE4TerFbpl+i8 1+i2x0n+rqD4zE0Ze+a85ZjBOfFgtFvOb8GaiCM1bXknFi10O9HV9yNAzGky43Ztbp5v29+p b/VmWSJZMOHEmosMpettlFiKMxINtZiLihMBWkvRlGcCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCJMWRmVeSWpSXmKPExsXCtZGTTXeSWWeEwaK7LBYHf7YxWnz9P53F YuXqo0wWbavPMFq0Ln3L5MDqcX/7ESaP3Tcb2DymrTnP5LH5dLXH501yAaxRXDYpqTmZZalF +nYJXBkv5v1gL5giW/HusGID42qJLkZODgkBE4lZE7pZuhi5OIQE1jNKfLr1kwUkwSZgJPHt /UwwW0TAQOJ37wVGkCJmgRmMEjNfLGDqYuTgEBYIk9j5QwOkhkVAVeLXq1VMIDavgL3Ep3cb WCEWyEvsarsIZnMCxVvPQswXErCTWH+glWkCI/cCRoZVjGK5mTnFuemZBYaGesWJeSmZxdl6 yfm5mxgh4RC5g/HpRPNDjEwcnFINjHscLyc8kOKO+/2F90WVGM/mnzML+/5+OmzeU6TzTMS2 t+50V0f0vuotbaIdcc2HZ+cp2H5ziipZ9Wd1Qxffwvf/xYNW7/yz+/GKCxEJ5ZLbL5z9GNBS Vrbu83QlBueAz08s68x/M+5W1Fdzmj7n/L9s1QXqoo5sj9r8Z6+eN2GjvpKE3sb3DUosxRmJ hlrMRcWJAMiRU1S3AQAA MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39860400002)(39450400003)(39840400002)(2980300002)(438002)(199003)(189002)(5660300001)(6200100001)(53936002)(36756003)(626004)(7049001)(97736004)(92566002)(50226002)(6666003)(47776003)(81156014)(5003940100001)(38730400001)(8936002)(81166006)(189998001)(8676002)(77096006)(50986999)(305945005)(69596002)(76176999)(1691005)(50466002)(48376002)(86362001)(2270400002)(2906002)(1076002)(356003)(2950100002)(110136003)(33646002)(106466001)(6862003)(68736007)(4326007)(54906002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR02MB1423; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD038; 1:yqkxjDMCizEQx7tMuXqHky0x2iyjXHqpoeOo/wNxlzwXOGJuYID5vRmdeqNL4Pv3H84Ij9y2+UlKOGSryNW5rQ2793VFdT/VMXfXnhPCKRZAXtv3MDzaFFMtLi/eNq1FyhGhJ01MGnb9dIQR6tAcisv/NiWjn7GSwIzaTkE3V3Vf6bK20xNgotoMxKGwb8vC8NZo6FHfF9UUsAKbjNTVPGbyd2pyemY8mZ232WI+fdn4O1cZvOrXBEcX33eqK6wUhOz+9Zry2MIyiFj7AByLulWNc8VgelKr2XVSdK9/EGPSIO08MzrtTeECfESqNbimOIzuj1WnXlKY/o/HrRpljQRu63TQv8DomnyGV6u0zqpml/Xhw00lhtoKN948TeodUVjo84k1rRBNs2jp8L3MFGP33FkJYbunzgTukJwqTsJFJeEs0M8zXbCLHKiGJEFEteXP8VoEyWijlYKMWmIaQFStGV499OX23TNNnyMgXEtcs7ilBN3yuCCWKayXFcjh X-MS-Office365-Filtering-Correlation-Id: 4b4acf67-4041-4eb2-435a-08d4457b0cf6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:SN1PR02MB1423; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1423; 3:8je/pF5TX84M7PSXuNWx3HHG3Vbz5BwkbYRcMNe+Z4OYAGL9OMAK4T6eqNbCa/vNpHBzQbXBTU2qu1bsucmP0aWKm09yI8prNh/3TocyqXn/2njV31+xnLjEog1udNBhQuVA+jIKmHWK5vU/ENlpPFmGOK00cPqjVN/pqzJp+FkbydRqb7AbNFvDGIh9SyXCN418/Y/8Cn0PI2bUixYfyFwQ83Iudt5GzOmsyFsAYfbrFg9sQ/GqkNDU27/Bpbl485LeXYz31Fak0rdxxuU3sShFXeOjHX5LKaXh2rGrQa8mFT3174v1NEl98N8lg7xn+8cXHklYvZ/6l+FUIAJJOCdXVedRbwKu0odtzLWiJPFxb6PB3i2ogR3cu5Sc3euTJ/a/C5MaVQUURJAoln9l5Q== X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1423; 25:K2fYEaQcNPR5UF1VoXmVUzzE32pFj4hTgej/S9eM9NpaeFyvNyKiGMb1A9nk3ydvJMZstCNG9m4cHwV5VS1MkB8K62fvdErl2XzZvmf4zn6oJa0byuOrLR19S3VfaJeO9xsK14D0mOTlL0+YXLgRHr1uUsyMNaMLXFqK3fpJI2AxesiWKzxEBe4cuseWxedoFCanGHI9tmo6uKeUvGFerkYU+egTNONJYK0zjaeH3JGuQggE3wxL+d0cXI+gmf5Q1NEnfB7XMCLXQ/uwYLRJaaKyxGOhpwXci4BVETI/TGwi3NxJ0tU8omXq8e7vlZc8t8b+Hbtrnsg30+AjBlX5qvzwk/HaEYobKqFsblggFeqwyLzWcCOKUY7ONKFwypNAVz+tITnTC9d4HK60bzftFt76tsRfHOneBhqNvdAVrwh61aPshmpU+gu3G2TSvax2X5vnT7LUKBKmYKXa1R4O4P99UQP9XJ/dAbKwcDTxnkL+sH/8ToMbREgIgF1pG55ZTGfe/UTOUc++YNSIORrSr3/JXXfYWx0zQybhELATLIhM7gVqWe7EM5YQmno4Y5ut1EwOk+E4dz6rCk5ZY+V/IwtjcL2BaVKXLQPGswbZOxdE8ouOtoDtHTh3bYocNGF83IGoKmnTwhReMXOgtdCJHmbUUHz4CB9yJa9EpQWxDlyJCbgH+LgImkj1Fn55riNd1gNwYdxNL6YlC5J2R69cjDRfk7PM4npxiiLsXe0T3/bbGoXLxWFXSCaOeYN0B/D5 X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1423; 31:jmj6dbmhWHgJ7azVRWL9OTUuKMx3QvtQqMag69pbdi/H1suw+TfQrnofZy3S7ktmXvJhthCpe5c8rYOghPJ2KiTwPL0Lg0YH0qCO7eVHpbZbHEicpyKDJWVmvVl5G1qVl8k0VKtpQyQB175DnWljF+ofZ17jeanDMxWyDg4nDWtw9sK//I1a/DkaY/fQyDwzhGNFWztIzWOXx9XoJ46m2A0VVcgbAFIiqlxbaIiNkY78UoReMAJTK9DX6/Qq+yZQ0XZ5H7EXaDNJGk394EZ/zY3X5+WEUfnhIxv97gKqQFU=; 20:BwmoPlQPXmBeO1/C+G6M+OL6e2ifl/a22OwsQaMwrmU8RrjRSs26nLWDcpCoU9W7IXma3H9quW6Igus86/tHlEdQvnZs8oa/wQg2C7o2cmzBHAKpXs8dlFFTOfvhneyUEAJoTRWufdOsnLvkqSBqkF634zH/YImfBb1C5XuXmD5DbM9RQCI9bWp+LUs9yZQ30J6Guh+OYjBCPHb6Y2yt0Pshoyu8JtVHOEbVY6lUTxtYiSxCL558SQLH3NvzyImFpU2PRuxSFPmC4V26Nl+4NX2WkXAiqA9kDC0iSB3NTxkRzkZ241ZrWPo27qWgdiiTPscEcOGa7QRLz7pHPnkNGfdC9sxfdy6uprazfjMcRLNF9Pk+8kzYqW+d8G6gl5nhWRo2upwPPvAtbSPUuslGFcYI7BX5E74mlrKfjpYAGnt4Unt3mNl7GaDmgyzApNZnmlVgSnvnRHZ0tuXoM4F5etPEoS5JIChtWd7bZkgvAv3Qrf0s+IOG16PTym/F0yBL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13018025)(13016025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123558021)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148); SRVR:SN1PR02MB1423; BCL:0; PCL:0; RULEID:; SRVR:SN1PR02MB1423; X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1423; 4:pMBVUOQq1kc9CjtrM0YJ5YvLEJDb7FikhFu6gZZlg5PdrvFt0vYJpVSLmDnzABhZut7cOiFs2INYBINyiIhHI68tG9LLStHZTWBDPRc3s4WKK4Lf7zquvtxDr5C2XtsyMwyJuoBwUUhbWBtSfLTKaXdC4GOB0k4C1mg0T7frNKyF4scdQdeCwPdmzbukNd9lAQ15LebyE6bD6NudRieqBv/gqEM0xWP4s4Wu5+Wtd1CRXTKo3mgGKLpj/LV3Z8az1uSVSpe1B+QdKGRetg5XDehRyqh6LCJOmEwIj1m91DLGXWTgLCEJuUjXD3R+31vApt9Bvj51xGZfuQsiIaAN9pZ3OcOjRgPHqPSyusYeY3xWaTAS9rawmAIuUVVxd/DJ7C/VJbqwXzF0L3VeAjsOJSZWQ51Y2XoWMaciQdtVgywOSnaQEb1XkgytG9IdylhklO/5uiCNdTtltDtQimP18Nf4dbqIp5C3RmHZ3Aq9FAJEh+Hjy2kX576Xm7XWN9YTzAg2go7wQGk/SI/I0ndHUZh73F5ZD0ZVJJlQd9XT9aBg9xIn44+bEfNuZd5NgLUm5oHSwO4vEh0T8BEeJsKAIcq29Sqam9/+6udU1j9pSdy2ytYKkbJIIPcrCT1ScLFmwov2x1XAshn3ZGyPC5HcW4CiPNbend90ft7NXqNt2TNUCJB/gQ1rce28W9Y+oULKS8rI0GiTEs00xCQyLFRv6Q== X-Forefront-PRVS: 01986AE76B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR02MB1423; 23:6EJS91Fx4CgifmL2jP66l4pGOQskvuOOXUT9vplFB?= =?us-ascii?Q?iaR8+FwsVqF6efsg2YZrReGo1MHybJ35msI/adVLnpc4dh9At+ucKhYkbkbL?= =?us-ascii?Q?0VJDsKzpcibwsRarQ2q8Z6iP8sDRJS6l67l30LpMUPM9UGDzSMKg/Uvs/oUa?= =?us-ascii?Q?PVC0wgYqPWIXApCc1dRsNZa20B+gL8jvQGnJa3ScOgDvkOlE3J18WptG4/6S?= =?us-ascii?Q?tFEyak9z6zQYHJUdBC7DMcG6+zgHeRTKdqU3JPk8zwQKeKRSdhvDKVhQVaXX?= =?us-ascii?Q?ePfJ3LYiG2soroNE0y/g8WkIYE6PBIIrkWkZKsouoeip06REnG1MwCyqm8T5?= =?us-ascii?Q?heffRHd0lrNyncGyPjyAP39WCKkoZDCkhc7qFMScdU1SgA5LeJp4/mc5UYTB?= =?us-ascii?Q?XV3FJWsTwc516+H74yEzV6th2s3mLzBBANSmkFIO6ijdGa7+FjZK4JRarTls?= =?us-ascii?Q?GX2aYpfbd4OVYoF5rguvH183zX89rMJybeiHXjWXl1FqT6v/pu7oAr5kPuVt?= =?us-ascii?Q?g85HEIceQ/5LxOAMLBeY7XZTI7GNEdWpSU0ATV6ICgKe1K22QNdS3T7hId6P?= =?us-ascii?Q?0YfVpnhBfpdPcqQQp5arNikUHGcPhcvda2f6h6LLkHHIwYoctogWbYBMND0U?= =?us-ascii?Q?NNd+7+pK/+4U4uJPh05ORHIpbQnzw7o8qPqLSZNwkOfDGwrM+OxkLjQfCn1f?= =?us-ascii?Q?g+zj/fIn2VyTZaxEJdt04402tEC/TPaOCRm+GsxED+E7jmoyjDJzdvllT+Y7?= =?us-ascii?Q?4taCa8ijRNJ3rS+Y9GbGTTpTRoFE7pM3Np46ME01dfGmJEVPHnsWIaofz0s7?= =?us-ascii?Q?1P96wiB7mueBcUUmMwnt9T+iHj3yNee9gd1RROUpBb5dgKcUjJGtDm91GgJ7?= =?us-ascii?Q?fFX+jJROawYS/a4dE5FDmTVniot0vLesKQK3U6EurxhaoNoDuyw7dMkr/DnJ?= =?us-ascii?Q?Q9snCLAJ05RBs5QntwsyWws6aj2bG6t3qRs7Mo8Y64tG8jVUwiCd8+vBxUPO?= =?us-ascii?Q?eELVburyvfwDUaJORLcgPe5VZgNDY3/4rjIFcCkf7JZiuFhhJwKj3WnxgiFK?= =?us-ascii?Q?RjV9f8FuV56gyNxvHGB6xZ5CmEUe0My3tkYcB6B/R3U+x8LFXzExgBdQuyUM?= =?us-ascii?Q?v7/pvcTfRviJd34bMFIIvHAyC0JttHFe6T39Q3Gmr5BCCzDl81ZiOVXgTYW3?= =?us-ascii?Q?esZb+6Zrq1VEBVCUUp8Roh9hGX+JO+u7sdh8CtVZIGtvTbbo7wVl7Os7g=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1423; 6://SsEKDzgDKQ1tvzoknipGo5ndaLQJ29uqHzUXRRdjFYwKudA/pTs5dd0Gei98o9QUb8G3DMLa/1oFDI8U3XUeEvxYltGYp/XOVk5B3NGZUEg5NzrFZz7Vfvxuzq1p3qnnZfFJt8vZ9qvmpBJXj0eaQ+VLvbw3bV0WKkVMxJC7SM4UXDlU9GLNHgvj5OSaPlcIy0XE6ccph8rjs3yN5vhM1j7AMOcdeEfD8ZwAXwjxPNNNhd12U3YqaFOjMnqjN5egB+YEn5Jr6LqE+yYJSZe4S8MSEOf2dZAQMnYSt1eWj5o/mRK/pow3VNYDiVcJfVV2sRaR1/GWRO85AU3plwNHM9KKgZPkgXWQDsPHlAEkYoAn6tOvvc6DYKDh2DxmhnEva7Xbk0jEqt28Qkp5ICMsH8a1DEGTSknpNG37RXxYFy4qhqx5m6WrRzsM2scjFgr89/u6OvzDr7vPejxtwmWg==; 5:7CfSvMPQlJ/JfkCmSJ4yc7njQLPEmxYbdP31Pdk9KAaQzwX+N9vuO6AJjt84giXV6B49huJefG9LaehD4FDRAq+7yOOHftAKl6VAOI6syVY0swayQV8QRP9eYR5cJh1XYgsXURcvhF0wvXRU7qRL8g==; 24:BShE7uiBC832ReHWIRwOIQW4XoUBJ30VhPL/dStry5aSG3mFKNLBzPfRHQrzSwcYF28LnP4nHCug8L3Ii2AHh9KNiD925ka4QdK/v2zeE2U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR02MB1423; 7:63PAzVjkQQbhKgRpFBP8IZ6GiBsJkXJDbTHg+YNu3/wbMrwR2xqz6/rB40yXjuqpJqGCBeQu+8+76kdTbWjTzd/DXESStVlPyaskL6aZPtf9xdBr0jNb85KTGRwwQtppS12i8OGJxqNhpH4EqAgCvSQxSZes1+b4aFr0ACwSLQk8CsfmPVCc1akEHKCeRxqNAaHKjQMA/U0sYN83TLWEWs4m8APXOK6DT6l+RABt95V2P7C7nOLy3jZ0j0MxS7BifDMjGd9f12mHbBWC6XSE/POJoMJxwLdqL9ejc5D8lmMCPt1wOKAGe7iphvRUyCXezHNsK7GwHJ5TannkxK//CUN29hWbu4rtb4xsTHlWd4aKt8oqIErs0ECxyLjRVi6MR5hVrzTW8sZYOd4uxp8+xYhc6AaDvYI3iLKGkoH6tcUUqclzvkRMuPxR2jmMTABx567LJE05fMc7GbZvOTfrmQ== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2017 23:36:56.2162 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1423 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The tas pointer is set by __transport_wait_for_tasks() but the value that is set is ignored by all callers due to previous patches. Hence remove the code that sets the 'tas' variable. Also remove the 'aborted' pointer because the value stored in that pointer is only used in debug code. Signed-off-by: Bart Van Assche Cc: Nicholas A. Bellinger Cc: Christoph Hellwig Cc: David Disseldorp Reviewed-by: Hannes Reinecke --- drivers/target/target_core_transport.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 43c69d2a0836..25d794c20959 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2483,28 +2483,25 @@ static void transport_write_pending_qf(struct se_cmd *cmd) } static bool -__transport_wait_for_tasks(struct se_cmd *, bool, bool *, bool *, - unsigned long *flags); +__transport_wait_for_tasks(struct se_cmd *, bool, unsigned long *flags); -static void target_wait_free_cmd(struct se_cmd *cmd, bool *aborted, bool *tas) +static void target_wait_free_cmd(struct se_cmd *cmd) { unsigned long flags; spin_lock_irqsave(&cmd->t_state_lock, flags); - __transport_wait_for_tasks(cmd, true, aborted, tas, &flags); + __transport_wait_for_tasks(cmd, true, &flags); spin_unlock_irqrestore(&cmd->t_state_lock, flags); } int transport_generic_free_cmd(struct se_cmd *cmd, int wait_for_tasks) { - bool aborted = false, tas = false; - if (!(cmd->se_cmd_flags & SCF_SE_LUN_CMD)) { if (wait_for_tasks && (cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)) - target_wait_free_cmd(cmd, &aborted, &tas); + target_wait_free_cmd(cmd); } else { if (wait_for_tasks) - target_wait_free_cmd(cmd, &aborted, &tas); + target_wait_free_cmd(cmd); /* * Handle WRITE failure case where transport_generic_new_cmd() * has already added se_cmd to state_list, but fabric has @@ -2651,9 +2648,8 @@ void transport_clear_lun_ref(struct se_lun *lun) wait_for_completion(&lun->lun_ref_comp); } -static bool -__transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, - bool *aborted, bool *tas, unsigned long *flags) +static bool __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, + unsigned long *flags) __releases(&cmd->t_state_lock) __acquires(&cmd->t_state_lock) { @@ -2664,12 +2660,6 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, if (fabric_stop) cmd->transport_state |= CMD_T_FABRIC_STOP; - if (cmd->transport_state & CMD_T_ABORTED) - *aborted = true; - - if (cmd->transport_state & CMD_T_TAS) - *tas = true; - if (!(cmd->se_cmd_flags & SCF_SE_LUN_CMD) && !(cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)) return false; @@ -2681,7 +2671,7 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, if (!(cmd->transport_state & CMD_T_ACTIVE)) return false; - if (fabric_stop && *aborted) + if (fabric_stop && (cmd->transport_state & CMD_T_ABORTED)) return false; cmd->transport_state |= CMD_T_STOP; @@ -2714,10 +2704,10 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, bool transport_wait_for_tasks(struct se_cmd *cmd) { unsigned long flags; - bool ret, aborted = false, tas = false; + bool ret; spin_lock_irqsave(&cmd->t_state_lock, flags); - ret = __transport_wait_for_tasks(cmd, false, &aborted, &tas, &flags); + ret = __transport_wait_for_tasks(cmd, false, &flags); spin_unlock_irqrestore(&cmd->t_state_lock, flags); return ret;