From patchwork Thu Feb 2 00:58:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9550915 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6DB4660415 for ; Thu, 2 Feb 2017 00:59:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 590AA2844A for ; Thu, 2 Feb 2017 00:59:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DD922845B; Thu, 2 Feb 2017 00:59:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB8062844A for ; Thu, 2 Feb 2017 00:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751311AbdBBA7Z (ORCPT ); Wed, 1 Feb 2017 19:59:25 -0500 Received: from mail-dm3nam03on0056.outbound.protection.outlook.com ([104.47.41.56]:55853 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751398AbdBBA7H (ORCPT ); Wed, 1 Feb 2017 19:59:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandiskcorp.onmicrosoft.com; s=selector1-sandisk-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7goZQCJQW0yLQcybLon/sVkhMhnSfCIE6ygZbduHGmk=; b=Y0f+FnxNPm+N4+RWmsJ5mGHmsPNxnRO2Mpgtier9BzRAtsgXHcDzJU/5mXtJw2i4aSTVZ1lEJ72OngnbnPgZcm8CmtNJj+KtB6vNv3f6jX3AtL6qXNPU4jAcikfKSLNSnyRQkQMHr+m44finjMQBunifP9fsTyzMsyssZ9KsfQQ= Received: from BY2PR02CA0060.namprd02.prod.outlook.com (10.141.216.50) by BLUPR02MB034.namprd02.prod.outlook.com (10.242.191.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Thu, 2 Feb 2017 00:59:04 +0000 Received: from BY2FFO11OLC006.protection.gbl (2a01:111:f400:7c0c::150) by BY2PR02CA0060.outlook.office365.com (2a01:111:e400:2c40::50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12 via Frontend Transport; Thu, 2 Feb 2017 00:59:04 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; linux-iscsi.org; dkim=none (message not signed) header.d=none;linux-iscsi.org; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.225 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.225; helo=milsmgep14.sandisk.com; Received: from milsmgep14.sandisk.com (63.163.107.225) by BY2FFO11OLC006.mail.protection.outlook.com (10.1.14.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.2 via Frontend Transport; Thu, 2 Feb 2017 00:59:03 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id AC.BC.01420.F0282985; Wed, 1 Feb 2017 16:49:19 -0800 (PST) Received: from milsmgip11.sandisk.com (10.177.9.6) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.319.2; Wed, 1 Feb 2017 16:58:57 -0800 X-AuditID: 0ac94371-7ee9b9800001058c-a6-5892820fcdc0 Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.8.100]) by (Symantec Messaging Gateway) with SMTP id 93.73.16817.15482985; Wed, 1 Feb 2017 16:58:57 -0800 (PST) From: Bart Van Assche To: Bart Van Assche CC: , "Nicholas A . Bellinger" , Christoph Hellwig , David Disseldorp Subject: [PATCH v2 29/36] target: Reduce number of __transport_wait_for_tasks() arguments Date: Wed, 1 Feb 2017 16:58:46 -0800 Message-ID: <20170202005853.23456-30-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170202005853.23456-1-bart.vanassche@sandisk.com> References: <20170202005853.23456-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsXCddJ5kS5/06QIg7OrhC2+/p/OYrFy9VEm i7bVZxgtWpe+ZXJg8bi//QiTx+6bDWwem09Xe3zeJBfAEsVlk5Kak1mWWqRvl8CVcWvXO9aC Q7IVD25fZ2tgvCLRxcjJISFgIrHk727WLkYuDiGBpUwSbf3dzCAJIYGtjBIda4JhimY8XcME Ed/MKHF7mh6IzSZgJPHt/UwWEFtEwEDid+8FRpBBzAIzGCXebH0GlhAWiJT4/Ok2mM0ioCLR vGo9mM0r4CDxY1oXG8QCeYldbRdZQWxOoPji4xBDhQTsJb79OcoCMlRCoI1V4kTLLjaIZkGJ kzOfgBUxC0hIHHzxAupqdYmTS+YzTWAUmoWkbBaSsgWMTKsYxXIzc4pz01MLDE30ihPzUjKL s/WS83M3MUICu3AH4+vb3ocYBTgYlXh4BUQmRQixJpYVV+YeYpTgYFYS4fVtBArxpiRWVqUW 5ccXleakFh9ilOZgURLnbX3dHyEkkJ5YkpqdmlqQWgSTZeLglGpgrOpNblN+1RSnPXvtlk9C andvxD+pO6y218/r1enMpdPSyrRZflmLKUSf25M/5Y1jtdiZn5sMNa4eeDrHy6Wr+KDYnMNT NJ459Cye9/tVWZxCg5O53OoJXb8Up9xwPyHu+PCc3N1VRh/vPbi0mCUjp433y6Zbe3JFTx2L /aud9WPi9jKN2V39FUosxRmJhlrMRcWJAH0gIRBoAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGJMWRmVeSWpSXmKPExsXCtZEjRTewZVKEwZ8bihYHf7YxWnz9P53F YuXqo0wWbavPMFq0Ln3L5MDqcX/7ESaP3Tcb2DymrTnP5LH5dLXH501yAaxRXDYpqTmZZalF +nYJXBm3dr1jLTgkW/Hg9nW2BsYrEl2MnBwSAiYSM56uYepi5OIQEtjIKLHvz3omkASbgJHE t/czWUBsEQEDid+9FxhBipgFZjBKzHyxAKxIWCBS4vOn22BFLAKqEmdWH2MEsXkFHCQebe1j h9ggL7Gr7SIriM0JFF98HGKokIC9xLc/R1kmMHIvYGRYxSiWm5lTnJueWWBoqFecmJeSWZyt l5yfu4kRHBKckTsYn040P8TIxMEp1cC4bfvaf08mXpwh9Xzi4tVyhZ2lRq/Wd+63TubefYL5 R/DEqtiNN23ea/TuuBC2Ou7Lx+9Pz++V3f3F8ff8LWYP/jaoWB8TmnLC+33Kgzb7nZc2nXzK aG2qeXleWh6nsNWk/z/MfDecYuk/H8BzdP6SaGUtppPKxVUi2/PNzBfJH/kVreP2T1vaSIml OCPRUIu5qDgRAHQhwEm5AQAA MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.225; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(39850400002)(39410400002)(39860400002)(39840400002)(2980300002)(438002)(189002)(199003)(4326007)(38730400001)(8676002)(69596002)(110136003)(47776003)(626004)(36756003)(48376002)(6666003)(50226002)(5660300001)(189998001)(2950100002)(81166006)(92566002)(2270400002)(7049001)(1076002)(305945005)(33646002)(81156014)(2906002)(6200100001)(76176999)(50986999)(97736004)(106466001)(356003)(77096006)(5003940100001)(6862003)(54906002)(8936002)(1691005)(68736007)(86362001)(50466002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR02MB034; H:milsmgep14.sandisk.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC006; 1:Z7bZ4fl4pi/C9+qYksee0u+CNZf5ZoPRhW6Yv6UXATrYgPHLRdGMKHRThi/G+TY61mdwLb5JkcTJliU6UgNP0wZ97yYdIES1DHMULfwtFS9o5kxijZyL0FzG33+ielR5bo+6bsqzkxw0Kbr/F4AwFV9WmDnxx0FM9IDIKb+6Lrh9/1ULXlzOIbPvhgxVJcgiJ9QeKy35eEg1dmMUYknZ3Jfz1Nd5STU2L29RQLYOiJgmp5g7Omam8LTvdodVjoU1aMe0y4COoIlp8G48O+nrmEJyM/1zztqodxgjLZX4rg+mzNclzGIctFV8FrsfF2LQYI9djMwXcNS6fenibKt8R76YseLa00aPrMkbImuZLKndICffmTo2xxt4g/tIjNFn3WxHUpcwx85IGS+14qsCibvaFBQB/Fs9Nej+8mouQDFpWxuS8ksM38DNKrAtBm+VAJFSLmxk2oONHvquL9n8cOVu3dyph7laHMF0mtSvsFpUbzOAMvoGkvZ4pjisl/ZU X-MS-Office365-Filtering-Correlation-Id: a8fe7ee1-b335-43a1-6d62-08d44b06aebe X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:BLUPR02MB034; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB034; 3:tZ+CCHykQQAlveuRdawJP1jiXEXknN2ayaI9YznQumofCAw7g07iR6E7XRcfz0sEE51m1D1NyjjmnspxmMOnCAu/tb38FKWWn4l/da5cAX0LvyBJGcc+7OkyU4PBoFeQrcKjZrLIkaLZtUgMdoBJvrNOoCR6LjtFsuD2Wv6F0Kwr9YD4YG6p8Ocy+M8U2l/zHX7Ysdn7Pyu4+oidCkg+iQ10+hHBGHiaxEuNsH6kCWG7Y5G69uyjGnVltLdZh20b70cPFnlDIZ9SqvKI+ROezN25KG4j47sTIBlJPK69uQC3L/HrVOMpCtcnW6GXPZ0uTgYL//dmZKhusNzWM7VRfA/uZAGM9tS2NIhh1a9WDGS+Bo2BvmX9sQJUw3Wbe3Lz2xc1VKHneD46l+ZmFsD5iA==; 25:EhBgNXotaZcy1kdFVKlx+HUQqM2gvrt3S9QrD34VUgOrVR6btUGF6jysRCRUMK49Ts5Lyx1limYKzs8fDx/HCvUebU/hwmkB0EMfc4nZ/QIK0RS7LaJFeNKHs/QevPU/QRJE+WGgOWmiWg9maIph/TDgYFwWWM7w3OQ9I2Pi2QEUdI9oQ6EfbqJLHRd2sjEESNt0rB4U2eJjtpzXS7YSQ2GimJeJ+9CJl82zRrF24UJeGZPA5/QlLPGy0lqdajHgKX/0TZ8Gdb43j1d7bgm9ZKVb4dYptTzrWybFsZzag3QfiuQjbUzITqNaW4hzB4wMnsf3MbT+gYCQ7QJ6ZOgWjohqNvDyOdzsNS4/UahEQDB2YTLbSlHPbDHSC+iQQl41JdzwVt7/ucYkcDxutfpkw/Z7DsybkBKDLF/WYdqMZRhVOFCWFw+X3isGVkL/uA0+JK7jD9mToKgRTS52Vnasrg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB034; 31:ZK4Q/mql/SewSZT42Kxm1bzofCuIUjlLjtKfNBMfvc+bg6+Z7yDG5wKL86AesqZan/azrkMVB7o0u0tUBW0B7EkpEAQsxkYFXsHMSUz1BhDjZbS+blfe+E6Ugot7b3VUuJDeu7eA1WOMdR536w7u/OgvSK4bI992dmZGWRbrNw7+mphecDja78iU+khR3ns4EYD4ue8RAKEDMmn0Cm0urD/9+Dv1y1l3mcGxnn9nbjLVnt4a2m1MIpzmPM/v0r0f6pzekD/9cj1qP8nwqSe5VJTofPU4PE7mlnVN9b0vQVs=; 20:I7R/rCGtWJd5p23EFN+QiYcDGicIrxd8Hgq9z7LsdsWgSck2MciJENEI6zfbSWwh5eqil59iCLp8bDOn0BiumqhNoZOE5Bp65wpysjizcs1vg00qlBSdOuj9mYwqpEHvmSsh2NeX5Mjy8u6d9H8J+N3ax/T7uR62/D46ZZfbkCfEsxmUKk8liKtWnvQWzxkBMseRE5OODTqt24jHAYD0OMqMJ99jiia9IIRIx1u1R9UQKLX/2o7vK0HUO3Bw/XffqnL9+8TAUj5fXiRoZ6m+fYHH7yMgJOpWBzoXBuEWcttm5TCi4tx/P50Bt8tW0/i0sYqOY8FwoWZa1Cq4c7oD+qR1prMqqDPw3SfoZKhDUjq10bqTAMFZZGTHPKH2XR/QPIrbujLcnRS7za0rNz9aWBjV9oVurRfltTRVHunl1/ViEUgdprdXrQR1mpI+x/WURYJnusDtOFQa5U3809m2ufqXZD4itHxK+sbOIFKRVn2TbpGlKC2ic5h4pvpYddoD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(13016025)(13018025)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123558025)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:BLUPR02MB034; BCL:0; PCL:0; RULEID:; SRVR:BLUPR02MB034; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB034; 4:tXwZ7q5NnzSSP0VAcG2BvvErxwBYw3sr2mk2s3dUc/YvuUTEcO/yAEPdwrTgxj6OCgEPAQ93dX43jGnxYyWrRmq3rUiO2tDENmsObCIy3C3qbdRDXUF/sZA4PyBFs4mJGDSe4xsw34LHYxU+SvSEeRHq4TLJ9KyFm8dwblgL/KxuLaE27Dz7cf9Fk2ocZMgOvpznzQ6PYUPPHnR+7mp/D6D7utPSsgnXQtyestIfAmtZy3GA5JX7HVR9et2y/A23P1s9OTdh8b4Ynk3xAGqIEM+YpXyfUIAXO0xECjU81V2A1crpsvemgd+IN6ppH3QuhOD/f1dpFLNyAlBlXTPDpPn2/UR7OaKHXqY0b+BBhvX2BQL0Dtbrr8CGCHPOW+owF+mUlr3BTWfiSWtSnG25Ljo06XvyfyUiGf+eBQDy0oKYNNuEwVMdKOHi5t6Cg7bZY6jf12UQFPoKyJxaTbysL4Wm8qtnw5YcyismI6sMkoaMK1BUXPsmADbE26BqaFCNCKvXUm+1dJcnKB6+sMIjmJZCL5cG9cl0ZWDkVSIbnSv8RAf78nqSOcyOIdp7TgGKHyYW5NlW8dnmjfHx2lqkKQiuRwKTgmN9JGwhtgxHPia05tTbupQmG0/oYhvgjVyvDE1d4ijHKU/H77H+8BXwqpn1tic9hUhvsXUOzaoE68b3ITzDHpGMtwwqBttTr8WSQrGCZ09MXLpIPJxQjczJSw== X-Forefront-PRVS: 02065A9E77 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR02MB034; 23:hNazUvCXvWeEh4VgnJaDhd5vuFVNISBUi3osuNc05c?= =?us-ascii?Q?f3jntSYIpsGzUU0hRjGhw+6GCmdsNRvZ4nxETHtWwbg4wpRM6aTYxVEQRojt?= =?us-ascii?Q?oDT5viOzLpJ65PN3eqK/psfV5BPze7P/Tb+3utikTiN1jPzegH0u6g/almch?= =?us-ascii?Q?rz79Bm7a6Ge5Ox3F8wHfotYuHFr85WaCFiUxcvRA7TFuBf8W6tnG/JyA0LA+?= =?us-ascii?Q?vze0nhBiV5Q9yotUKBkQsMZ00vZyqjZoLAoyFP9cf5JsCdmwLDoWv+SvPBsm?= =?us-ascii?Q?hGvX8b8/S+MVQIi9SJkCAf9n+zLlC2MTtMG9nUU8b/S/woe1gSWbsZv1DFX+?= =?us-ascii?Q?K8bll3AgWf0OZO4EQbNk0Wno1KplMS0GoB3XME6cN0XdJCVuRZ/wAkKtmZYs?= =?us-ascii?Q?XUQHP8Lwf7WcCmC5morVT+aI2EeIYHW7ndta1ZcUvLb3/p6raK5STIAMkERb?= =?us-ascii?Q?6Sl2amsNsk6qi9L6bgNgq4+x2WRdqQ9/RNG9yvOPY0CohPrYAOP8GvTZ4MCb?= =?us-ascii?Q?RUP3MOFBWuOiq+Agv/JD42XWIBIWLCMAqGLq6SOjyBMbwcY2l/meH/PhaIIC?= =?us-ascii?Q?Olot5yK9WJ//IoeGZPm60tZPx5koS5PEALP/pQyOhRjGujYDj6wk0Ph6R4r7?= =?us-ascii?Q?iGEtUbz7iIq+9Cxcd5TmFIK9Xdfyh4orblvpk52Vt9JR5EysFPDb8hSlJqkc?= =?us-ascii?Q?uUh4uVwYHYfoXiZxUr+z3AKmLgnCZ/9U07OOcZuyGkPSk37ScGJIOBc9n2L0?= =?us-ascii?Q?YOk45CUemRWvMexYvytRuUv3WSAhD3iW2WRHhD8vKAk7F+Y0NLVEsdSTaddt?= =?us-ascii?Q?TzOZQoJsAi5zbeYgPxwACiOlX63a6R9jVLQ1Q4HMwEmDC+7v7lHHwjI+gOgq?= =?us-ascii?Q?FwyzzCFcLTa+I6ztQq88v0rbQpWZbY9MVUcXHQnwAahtcNBilXQqDAhKjQM8?= =?us-ascii?Q?LATpbb9JjTR/DAOoFHDiCUQtY6Ly9JhKD/Jah0Qrygzl2KFSjGIqUpdEfUkL?= =?us-ascii?Q?rarGb9T+UCPRwbRcAskaT5RZ5eMkbKHpCWkeAyO96w5IITsYqLfDUVeDGIcv?= =?us-ascii?Q?KKw1nhyXo6HpKbNemmo5xfBPUTgIxSMIa2BHIfGjImbeVIXfR0izbkpyybZr?= =?us-ascii?Q?LQSW2N4GT/E6XGBAP2TaQNs9fGmNRkUmVPOUnvLNfsD4wA5LIsCtgCF0Tqgg?= =?us-ascii?Q?7aQLtwhjhZ7xMabWRrGf2tHtIRLwPoMiBlfOvqEDWTF/Ro7gT2OGvBrA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB034; 6:RKspr6vwe7IOi43TIjbNa2GXQHNnb5afD50eQV7YkqagN89O6oe3j5ioMz7WMALpYftxzaRlHIYh4ltd1uQy8zAMrgKeWZKNAmGJLDTEhorL2q5lzOPpRwo2iJ/JpIK8nNKBmn1aJiD/VB5rZxKN35DgS6JVqd8VIDNWRmXsxYnlKfhu4c47TtxP6TEW6H+02z8W+iFlkN+W7nfA+QPhn+QuN8jqI6RD3wTqMvtLl8yGvS7HB/0WUCW1mlbzbRjH0lTflyJQsSML8yOt2m/J7OhF3C+fRsNX6T/Z46unqhjb9zj/10bYrkwyBT2ZE979S8iS8U/w9gPxLaJ3UdTcLkzs4mkuzYQdgi7va0/8hfdHGmCH2AHorP3s5Lpjeguiac6JNFXryy0hUlxUT1Bmk4z5Xb24cmt0cZDY3W2nMLcOKb9FF4XbyUYC+eqivbHd; 5:7blrwEwVsihCc9mIgXNfzYacTXRCgep801cm4ZXA1HelnmW0cZlkiKQJPxy9UqkNjQAGGvIataWhk4OsX52/IMhgVTCMvMHtCIchIGXrkIBi60lxjlHuziXEGhDU8B8LFgplpOK7i6csRHN55C+ryyG6zqVRVbjtUBGLlvDL24s=; 24:17C4EB5TNqaNwG4p0MFKLcEFw+LkAtzbO+O6SSzqPI+Wr8JlcTXuyyseoN4HRTWkNM682QiduA4ip9wI8y/zgmVUTc6fdpwfMXW7fI7MkwU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB034; 7:u/IKd6bQf/GYnfpY6XQOKtDr9Q7bwq8Dw4JjNZNsDOSCklLZ96dbXfnjJn02HG7UOWFIIcs3MdXSlP0aqTYAPf3qqlF0vlWvWTt5SZ/wvX7QemxsZ8z/H850J7Z3WDVzhwi1fshD672Y4vAmlAg7qDHJe9ErhQc6Mc00YPRRZ1d2ApBX0qZ9qHduUwZcO51dYKtm66TvYpa3xV1WF+dRBA3VNKE54sUPBb5d8wAKq4jGyzbZx3Ge4kRLWve38Im5H9O61hhfIblql+c9BwSW2EHN13A8AFlzPQDZOADzVLNAxK46TrCPFnQx5F2mIOiX5UvfgFQe76KJXq4tY3USQWm57wICrXx4vpKMXM1BuPPi5MJS51u2wycRixQGGgcKWZckpWd1sXagfRAiXZr3/5/WI2JZ4qnMpi8QoIg+CyJRDNb9tF/81ZhgJmn9C9JEVrwE7XZ/bh17kniPFHXnWSeP1q5LKHyW+j73ddNV4B1jD9HfhcJSx/Y338eXx70NYiyjgh7Gy39AB6J18eKMVrnOy0CmBZ19/qipUonufSpiDMAEcZerrvSZdcZrO1Ke X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2017 00:59:03.9372 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.225]; Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB034 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The tas pointer is set by __transport_wait_for_tasks() but the value that is set is ignored by all callers due to previous patches. Hence remove the code that sets the 'tas' variable. Also remove the 'aborted' pointer because the value stored in that pointer is only used in debug code. Signed-off-by: Bart Van Assche Reviewed-by: Hannes Reinecke Cc: Nicholas A. Bellinger Cc: Christoph Hellwig Cc: David Disseldorp --- drivers/target/target_core_transport.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index fe8132df7f01..6379abc521b1 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -2497,28 +2497,25 @@ static void transport_write_pending_qf(struct se_cmd *cmd) } static bool -__transport_wait_for_tasks(struct se_cmd *, bool, bool *, bool *, - unsigned long *flags); +__transport_wait_for_tasks(struct se_cmd *, bool, unsigned long *flags); -static void target_wait_free_cmd(struct se_cmd *cmd, bool *aborted, bool *tas) +static void target_wait_free_cmd(struct se_cmd *cmd) { unsigned long flags; spin_lock_irqsave(&cmd->t_state_lock, flags); - __transport_wait_for_tasks(cmd, true, aborted, tas, &flags); + __transport_wait_for_tasks(cmd, true, &flags); spin_unlock_irqrestore(&cmd->t_state_lock, flags); } int transport_generic_free_cmd(struct se_cmd *cmd, int wait_for_tasks) { - bool aborted = false, tas = false; - if (!(cmd->se_cmd_flags & SCF_SE_LUN_CMD)) { if (wait_for_tasks && (cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)) - target_wait_free_cmd(cmd, &aborted, &tas); + target_wait_free_cmd(cmd); } else { if (wait_for_tasks) - target_wait_free_cmd(cmd, &aborted, &tas); + target_wait_free_cmd(cmd); /* * Handle WRITE failure case where transport_generic_new_cmd() * has already added se_cmd to state_list, but fabric has @@ -2665,9 +2662,8 @@ void transport_clear_lun_ref(struct se_lun *lun) wait_for_completion(&lun->lun_ref_comp); } -static bool -__transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, - bool *aborted, bool *tas, unsigned long *flags) +static bool __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, + unsigned long *flags) __releases(&cmd->t_state_lock) __acquires(&cmd->t_state_lock) { @@ -2678,12 +2674,6 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, if (fabric_stop) cmd->transport_state |= CMD_T_FABRIC_STOP; - if (cmd->transport_state & CMD_T_ABORTED) - *aborted = true; - - if (cmd->transport_state & CMD_T_TAS) - *tas = true; - if (!(cmd->se_cmd_flags & SCF_SE_LUN_CMD) && !(cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)) return false; @@ -2695,7 +2685,7 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, if (!(cmd->transport_state & CMD_T_ACTIVE)) return false; - if (fabric_stop && *aborted) + if (fabric_stop && (cmd->transport_state & CMD_T_ABORTED)) return false; cmd->transport_state |= CMD_T_STOP; @@ -2728,10 +2718,10 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop, bool transport_wait_for_tasks(struct se_cmd *cmd) { unsigned long flags; - bool ret, aborted = false, tas = false; + bool ret; spin_lock_irqsave(&cmd->t_state_lock, flags); - ret = __transport_wait_for_tasks(cmd, false, &aborted, &tas, &flags); + ret = __transport_wait_for_tasks(cmd, false, &flags); spin_unlock_irqrestore(&cmd->t_state_lock, flags); return ret;