From patchwork Thu Mar 30 17:12:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9654861 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2F51760113 for ; Thu, 30 Mar 2017 17:13:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19CEF285BD for ; Thu, 30 Mar 2017 17:13:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0EB30285C0; Thu, 30 Mar 2017 17:13:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99449285C3 for ; Thu, 30 Mar 2017 17:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933024AbdC3RNC (ORCPT ); Thu, 30 Mar 2017 13:13:02 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:56144 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933322AbdC3RM5 (ORCPT ); Thu, 30 Mar 2017 13:12:57 -0400 X-IronPort-AV: E=Sophos;i="5.36,247,1486396800"; d="scan'208";a="7316754" Received: from mail-sn1nam01lp0111.outbound.protection.outlook.com (HELO NAM01-SN1-obe.outbound.protection.outlook.com) ([207.46.163.111]) by ob1.hgst.iphmx.com with ESMTP; 31 Mar 2017 01:12:56 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VnKaABrreA5w5Zj6IVrZQHyBJi+X7vIFuxiNuIzJbdI=; b=fEcYLMu+QlyRVxUD9lzLkSNz3wXoXlrJQzXiaGByHQT4rqzd98L17aVrYKED4uog07XMU9YS/QW+00Rw0g7QdQfAgV8slZznQxWKrJKIEkClfS0blYeV9/yPI/bwJICS5LHLgFdWDteEJ9jo7EuSowSCqe6yLEgByUPEiTPjtiw= Received: from BN3PR0401CA0018.namprd04.prod.outlook.com (10.162.159.156) by BN1PR04MB108.namprd04.prod.outlook.com (10.255.199.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Thu, 30 Mar 2017 17:12:52 +0000 Received: from CO1NAM04FT012.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4d::205) by BN3PR0401CA0018.outlook.office365.com (2a01:111:e400:51d1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10 via Frontend Transport; Thu, 30 Mar 2017 17:12:52 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by CO1NAM04FT012.mail.protection.outlook.com (10.152.90.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1005.5 via Frontend Transport; Thu, 30 Mar 2017 17:12:52 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id C3.BD.29323.29C3DD85; Thu, 30 Mar 2017 10:12:50 -0700 (PDT) Received: from milsmgip12.sandisk.com (10.177.9.6) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.319.2; Thu, 30 Mar 2017 10:12:48 -0700 X-AuditID: 0ac94369-548749800000728b-4c-58dd3c926f4b Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.8.100]) by (Symantec Messaging Gateway) with SMTP id AC.29.18148.09C3DD85; Thu, 30 Mar 2017 10:12:48 -0700 (PDT) From: Bart Van Assche To: Nicholas Bellinger CC: , Bart Van Assche Subject: [PATCH 4/6] target/iscsi: Simplify iscsit_free_cmd() Date: Thu, 30 Mar 2017 10:12:42 -0700 Message-ID: <20170330171244.8346-5-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170330171244.8346-1-bart.vanassche@sandisk.com> References: <20170330171244.8346-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsXCddJ5ke4km7sRBhvPK1i0rT7DaNG69C2T A5PH/e1HmDw+b5ILYIrisklJzcksSy3St0vgyjjy5Rh7wRvBijtbFjI3MB7h62Lk5JAQMJE4 9q+BpYuRi0NIYCmTRP+EhcwQzjZGiZcNb1lgqg7un8kEkdjMKNEx+xk7SIJNwEji2/uZYEUi AjoSs+6+AIszCwRJ/Nu1DywuLGArsf3NayYQm0VAVWL61AesIDavgJ3Ehoct7BAL5CUWbZoB Vs8pYC9x4doisLgQUM279j52kMUSAs9ZJJ7fvs8C0SwocXLmExaIZRISB1+8YIZoUJc4uWQ+ 0wRGoVlIymYhKVvAyLSKUSw3M6c4Nz21wNBUrzgxLyWzOFsvOT93EyMkaDN3MN594n2IUYCD UYmHd4fg3Qgh1sSy4srcQ4wSHMxKIrwd1kAh3pTEyqrUovz4otKc1OJDjNIcLErivOdkpkYI CaQnlqRmp6YWpBbBZJk4OKUaGPNSrsnLpveE8Uu8SRfze28SPXOZ/W3Ro5veS5+fq7T5woI+ O1e+VNUZenecAiWcsqWWa0kXRIlvPsY55/HOIJawD9dUJkwNiD11Y83lu3fOHW76w7h2eX/f kX+XghqX128qfpatmi1w7o++4Lpw2cux6xw8r+Ur8f5e4L8z6x4XS4XAqRe1x5RYijMSDbWY i4oTAcuRcNpWAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEJMWRmVeSWpSXmKPExsXCtZEjRXeCzd0Ig+kLZSwO/mxjtGhbfYbR onXpWyYHZo/7248weUxbc57J4/MmuQDmKC6blNSczLLUIn27BK6MI1+OsRe8Eay4s2UhcwPj Eb4uRk4OCQETiYP7ZzJ1MXJxCAlsZJQ407+FBSTBJmAk8e39TDBbREBHYtbdF+wgNrNAgMSx WS1MILawgK3E9jevwWwWAVWJ6VMfsILYvAJ2Ev9fXWCCWCAvsWjTDLA5nAL2EheuLQKbIwRU 8669j30CI/cCRoZVjGK5mTnFuemZBYZGesWJeSmZxdl6yfm5mxjBvuaM2sF4faL5IUYmDk6p BsZjzyUcJz71Eq/M+BbkE64TvKw1WGgyYx3/LOdEhQ/COcu+uaRM/H+eexGP1sv8NXw8fdc3 m/w70/Gm1Ul6ltmDLevYFkbdvHN0c3VNjCbDj50qTvJ8jH2vQmNcTR3enZpfPumnxNsjO/7M cN3Lv1T7+5VUSVFF1VvyAv+2ut88pDFhc9W6f+1KLMUZiYZazEXFiQAh704KpQEAAA== MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(39410400002)(39850400002)(39400400002)(39860400002)(39450400003)(39840400002)(2980300002)(438002)(199003)(189002)(9170700003)(2950100002)(81166006)(6666003)(8936002)(50226002)(305945005)(8676002)(33646002)(6916009)(5003940100001)(38730400002)(356003)(77096006)(5660300001)(107886003)(110136004)(54906002)(36756003)(4326008)(76176999)(50986999)(1076002)(106466001)(189998001)(53936002)(86362001)(47776003)(50466002)(2906002)(48376002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN1PR04MB108; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM04FT012; 1:OH2gf3JxZEFBiIDMM1VI0VqEw8m1eZ6a46Pux05sFRbMQAZ07+liNJse+zO+lpFtZvW7ndSOQp39oK5lcptMu3tVBeeFpjBc/pFWzAoaFJR49gdePU8V7gdFpkNmqo/qpyCDOc8MLK+dN1k+8lJQ4lJoj6s4uKhl8aAQtYtq/3EUosORev8V1wyQPyCq5RLPxqK4DxgAtW07PQCaEh5yY3TlSlOlcXtoB73ARj7TrjZw5rsOpc7E0og62CuKg9xrQsyW/1nOIEUYegkbYHsoWCjchETIsQGkx9cxiGELsZIVIEIJzps04A43ubwYvqhqUvOrSfYob2+1t8D6JJdJSd32kVV0iftUEFNWKy7BG8CZhldEGnBbefXMJM4JSs7SqXFp8MZmZ8gS1RPAJT4gZuA09F7eBEVychTVB+ixymDMhXyAUorBLKxRRptzNZCyaApVZRa75PIilyFgN/909Fd2ra0M7INqmMQ3QDhy3dQB5d/6rmkV8iFD4KVL3GzqP1b4KdntvWNKAlTGhiuVcCmWmnWhJi1/HXYixm7l6to= X-MS-Office365-Filtering-Correlation-Id: f7b03f80-a840-4c4d-f1a1-08d4778fffcd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081); SRVR:BN1PR04MB108; X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB108; 3:oWEQrmhwsdL7ZjlJgVMrq1KfJoGs8kyvx9HOGAy2KRM1As+GXMLcZE1j3AwmzAsuBWgxZ+3VGkM4rn1SEoMw/mDUPXOhhaaLYKM6ozHWKh13gVSTXluDMObi8X9AxkGnjebbYkGTqYeUs2M48XJaqRHu5GOCzmFh4sfdDX7EpZ5Wn9ww+ePn1WKGW9Mi2iu/eKorIwwz1Cdn7Jxu/r6wld4Yj093y62rToCqo9AqMCvz/H0Cdu3tiBz3a0875Mg6B1z85QVeFxDhEnZmput4fqrq4ojmPwZ0CfvYmhkLbjDo4zuOTNOHnJdRgWrgnYIOLD9Tn9lnV+foaKeqsHfd7WlzkEqCLII3YfRYsVGFLrrGEWLeRg+Gaqk64+DxgYM5Da397vYj05U2Jd/hFNt7UArcHfk2DW12YbmXOx7h/dqhSEa7DW3uBY+Ivb7xHtHYpmEN7BkrOIB8TnnYcX6zNnnpNFaLNEbdijH6ckwLE/bGmZoDnZ/IxXwzI+Be8Rlp X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB108; 25:/MyWsnQu7M0QT/4iwQSxhnKnoVv/63vD/iJp0BRkb16ScLQTOCALdRypA8zy2/Vdoc5CF0P5EUDiyVONa2ilpv3vhWikPVvS4ZhlGAH5iwahPdqw8KIcWKMfkoT5WRVKD6h85F9HpLyQFME90w9bD+Scz2om1hLqGnrCBN6Hcg5N6MdIPsoxJ7bNYQRS5XxJb4iGwWlfPKvG+yRTrN/b4vkItb2NhnWtnBnsVVlixsehALzTnelFnubKu6GuAoY37QkPDue/ebcuSWie/YqUXxBEOG32owfZNCt2jhkBYJkJsBmKItrGkjEfuIGNArgLOyT8FwTEgnexI90eiKdCNvFY+PA3mTMMl7VFeMWnnDwDYzlqSnlWkisYEPYgaavxmqQBUT47CcZSTigIWfITVbm82PPpgXiTPLF3UWcXmgQDN7kQL46kRQwe0U1nOK3uWRexhcm1pQ1TFsvNWUIvfQ==; 31:NT3UPt5leM2oBgAtPJ9Q2TwhYyXWBlLS1SR0frCQtkYxWTRSBKQleSqlZazQIeFaqx6qL5A40vveMcIDyRAdMvC2VlyX1ec/+jz7Wk5l8cU0J4XXx0jxoc8owPzFQFyJv8ky8c8TIRJIQBlqKfooJpbvdlZ6JLrCPA4ZjQl8CAj6f0Z3R+dOGv7VVKk1lYDKH7JzjlkW8Qqg28RSwLuteJOrbCeJqz4fK65x88Rmapix9r8HHtUt/caYyz10pB6mkhFsawIbk5uFy4jR/8vzYQ== WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB108; 20:CB4eiQBX2dOdFRdnoeN++EHvipQXIzTxLRdoZGDvX7wDHXcTW3RPIQI3MytPCSCjKDENkeSC6GG4V+y6WhT+ige28Z0X5UScpNpr1bM4fje/9Paztjy+5uDSXpXvs0nJxgTwIueUmQXB3TQEBvrui64w8tOGWBzj+GvEYKd+n4J9MU85wkw3TTOz4EvvBm0w2LNGB4s4wAbMX7EFSfdgXjvML3y8NoSB/Vg9WNhiiVRood4Tzsc5hwD9WW78iIlzBAKxuLvyllYV7qjURE7hNDBt0XP/khjYP59ZES36gnRGaEZWgwNxYpZLiUHMYRW6jnFlHEGsSI5fI5DodE3IDB5xfQK2Bf6+4XeyHSpkUoB3Ug8NOkkkzyy9vFmLj4dhwoUROjVr1fNh3LrPahbyX3KZ//7crL3ucARuv6eFBm75uKAJibef7P2r6SvcGa7GWbLEEb4ufmohRP5W8wG+7vy04TN4IloOVPS17E/5RvQsXXG+xkTp3Gu1/skymucp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(13016025)(5005006)(13018025)(10201501046)(3002001)(93006067)(93004067)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123562025)(20161123560025)(6072148); SRVR:BN1PR04MB108; BCL:0; PCL:0; RULEID:; SRVR:BN1PR04MB108; X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB108; 4:Hl3+YKae6DAONQb2ZUD5tfGTGH0AWCviIeCvKKlJZUC7/iz/bbxiSR2AFvNP0CsjMLMOT+6zPeJJoMB41oce5D8pbhGFwJA3QFjtD8loHLz50hjFgqRf+wdo2mMcdomcusD8YjIlYI+HXRD52tED/28epOJjkAEhvMREw10aSbn6Xld8gO+LFxDLCvERRkzm9upEY1Bld/8rVE0ct6OGP/+eiHwWFfxP6WJ1o+jM5wBN/BaCPev+BIL7x163FXPACdyd2PncN58J3JtS8PWixbFUrzj0IIZ+vu7Z/+19CTPkPuPgGOpgl2oAJKXsCUp0LIF8UPcSkvaW/39EW6KJ8aOgiQ5XWh+SMAdIP+BzdG6Ibnny79Ia/Bz1QnSwGsq0aTK78INWlz+p5E58tZpn9/fuHsc2Gr+/8xinTdiy7NVVOEqOHUWzx6FVQQJkeueLb/4ejrIFPULk9gjOFdx0dDwh/XN0wCAEscOpwiZ0dK8BxIja/Zb94Qeo4qQHMXOnb4lfzue5xFOc3jMm0aq42AYXGB7tVMXI8SgWHkbl8jNpSTGcyVPFWjWB4JlbAm+rrq0as87Ciq8Dl+EtNxhewKFoC9xImpleA3dMdx/OlawCsj5b61ncp5jBIeN4+rUUuDwe70MhmoHtV9PkV9kPwxiG1ITlbCsvqXWijyPRJC5aazseee8n08SN3Sh6DYIrB3Js4i/BxH3+RJoJKNGjkIXIXlJwbG5sTiuCCOzkh0t/S8X4LBtGMswGsy16FTSrynrRZScXJQgqRBj3JNN2h7HpgZsBT6U2FDeRR62nG5YTgd14oGRq8mA6DKIsOWMz X-Forefront-PRVS: 02622CEF0A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR04MB108; 23:ouLSeckaRSBD0Nl5Lydob+QD4o5at6aPhUtpYxv54N?= =?us-ascii?Q?uGHPd374KrHYmP9CS0A9xGnQL5MbaohzC01nqnDdFXfrg8O/3NchqmPqY0SB?= =?us-ascii?Q?EUiJfoXnV87nyp3g1dv/NL8NOlZMO0mOWwVFdBbYbzv8sH/HLJjIPWnDxVpm?= =?us-ascii?Q?tXPz4eJ/vElZJ+3s4TuxapEYFbgeAIHZcutRayvwTRgXdH7eCi8bLdj6cKeL?= =?us-ascii?Q?PeEskXu4oPSHCaR7Wg8O1YxM/iFrBAUNa9s2RdvOQ71OrTz4EevtaR+pGqIe?= =?us-ascii?Q?P2awr/8BB+D9AaoPRdMjDLaF/YUaDQrnCF5h0EJeciye/2C81xNuOr/E862u?= =?us-ascii?Q?9pJsX7t1L6jseHnqeV5prxFY7MwiZSjzzQNZjoWnDR2bicub0TEp0I5tJFAY?= =?us-ascii?Q?0qsBoqXMOSuNw/CmFNXuOghsdezSkVcxzxS3UtLZSpGsHoHhlVknu4b6UT8X?= =?us-ascii?Q?aDZKZXcnw7gAZ9aa7yEOCFFqwqXY/E3FoBbrm7++uAxN1f35o6LpwtvJxPtZ?= =?us-ascii?Q?Y8Lfc5IKeTI7GrAeSAC8WPCeA6isABHbnakt1v2c+2bDV1xcVH8+T2fUg+JY?= =?us-ascii?Q?qibn8asZgg7MPHlJTMkE0idMMPnxE/Vh8HPuthmG6kh+S6XNv1J+gPnM/Pgz?= =?us-ascii?Q?UFx+ihKqqGXsI44o+v5zkDCwwg1677qCViHiPJuhX7rCOWjLoBNvsQ2mE7DQ?= =?us-ascii?Q?A1j4SCVxu0LPq0ZO5dGkPsdTH9T7d9qRN7L+N5fAKGpRj55ty5EvTINggBX7?= =?us-ascii?Q?hKctFDD20CdVLOWUFHOX8/N3lFO9+xH5Y8APBREwTvM8h2UbzT6n+9ILaj+N?= =?us-ascii?Q?00yRe0zL0291CPFaI2e57t3GGR9xYiQ/UdsHdmefywt5BS6okiXM2nxQCtvA?= =?us-ascii?Q?SbRVueU65nPk7X9YZOYKFvbHEFZ0xNnfuGyLYUWQgQvcdN5ppTp8sWAEDqur?= =?us-ascii?Q?OzMcUrs/gJTtBY198PTesXbehyFHHbfFvTqj+FKFXYyIFG8ABlqDWqUZo3WH?= =?us-ascii?Q?F9RqA3b8XTYjd+8ENkDD3qWt5NNw6H5Jl/0efsTdz62vimmzPfLWfLKG2DRE?= =?us-ascii?Q?FmB/E=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB108; 6:8HO0SNxO+EGlsM3uPdLEAYs5EYqCnZOl+KtVebjEtQ1+Jwe5VvfxOLF6uP7ixqxdH2UKrsxUiQ8XCTxrz8aTyY/lXik0zl9wRJukDpFkh0QP1a9SmdmPt3yY1c0KN+sQHIwdsWDL+zCh5gsUM+RXVksSHXRmLxj12RRDnpr/JsMu65KNNTqu7GiMDSdWZPKQ00g+JRT0VB8SsiwKAMBrJpitZ/vIEE6D3fBTJ7caviNH4tbfytn9a+ZVtrVQ+lJu1u1qjweOI7hjx1OKeCk+2DbvwenfPk5eNAEswDAWLQgxQ7V5ChghW5ZC6Ojo8AR5WowQI24FPd7SyYR0TCoMGtmFje4VdzCrg10bM55Z0B7ciRNepqKd+mbfFJZUIbPoSuxxE8vPZrr6h9CDv9C7Eq290f4Cqap0yDDuYm5r7Kg=; 5:wLDhXPgYx2l7PlJpJE+bWd7Ka9Bv5fNRhzlfa0qbAyjy70AeE4TELFjDKUfXFKwZ8PtcJMQuKZjK+3HavxRYTvfoj9z1t4qkixyJszpKpty9qAG6YryaDs5MgKCh8hbzNJ8VJnzo0h6b9rFSCKcfYw==; 24:Ox/D9tYy6yYfyRQtyj7ddmCR19Kn0fOJg+S6FsftnqspoouvJ1OvkjB6G7SpF7IJ+Q9M+4qEbzdHSzmRWxgoGsVUtnOgFeIcXP5gBPH91PU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB108; 7:fZMZmrdsMU4b8cuagRUG93IztFz//+NWRHewaYToBwE0Z2mtmqzG05J+e7jDAgu/A4hg4gv7rzZ3d/uC3pNvjSnwuZl0YXX5XyZzV6qddWNR+pjjllVY6ar2EjZ+44mbunyt3nkXZBvYuALAYFVD/r6Fd7L3wP2L7Osg79ko8loHh1uswMWEcJLajuKAKqKqMFZn6LWIQ3xAv2wH5eH4Sb0urI3w64c8F2HmqePxHMZ1E0WXNa8e8Ids+uBgCpMHBeiNiQmHCPuQ0LyAF5HKeEdGArgrZtbvw3GZbJEnmx23OZ40dmavu1r0C+K17Kr6+zOeO+sB9eGQ4N0IP0Ii+g==; 20:NECZGLLC3ANOsJ+D2LgmgEV3npjx43QVlWB5SMhwbNX0/MCK9QebkxZDwkT9FdhTR5e5GjEvdK5KGdh/naC10zq7eGYXwiWlXhsNBJ51cyQ6X41tkZUpf0qhHr25QcYkxdMr85y40GhiSzvjDYPhkyvW0RlPpKIXeqRRFJToBjA= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2017 17:12:52.0079 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR04MB108 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since .se_tfo is only set if a command has been submitted to the LIO core, check .se_tfo instead of .iscsi_opcode. Since __iscsit_free_cmd() only affects SCSI commands but not TMFs, calling that function for TMFs does not change behavior. This patch does not change the behavior of iscsit_free_cmd(). Signed-off-by: Bart Van Assche --- drivers/target/iscsi/iscsi_target_util.c | 40 ++++---------------------------- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c index 8b89251c644d..139746b3b189 100644 --- a/drivers/target/iscsi/iscsi_target_util.c +++ b/drivers/target/iscsi/iscsi_target_util.c @@ -736,48 +736,18 @@ void __iscsit_free_cmd(struct iscsi_cmd *cmd, bool check_queues) void iscsit_free_cmd(struct iscsi_cmd *cmd, bool shutdown) { - struct se_cmd *se_cmd = NULL; + struct se_cmd *se_cmd = cmd->se_cmd.se_tfo ? &cmd->se_cmd : NULL; int rc; - /* - * Determine if a struct se_cmd is associated with - * this struct iscsi_cmd. - */ - switch (cmd->iscsi_opcode) { - case ISCSI_OP_SCSI_CMD: - se_cmd = &cmd->se_cmd; - __iscsit_free_cmd(cmd, shutdown); - /* - * Fallthrough - */ - case ISCSI_OP_SCSI_TMFUNC: + + __iscsit_free_cmd(cmd, shutdown); + if (se_cmd) { rc = transport_generic_free_cmd(&cmd->se_cmd, shutdown); if (!rc && shutdown && se_cmd && se_cmd->se_sess) { __iscsit_free_cmd(cmd, shutdown); target_put_sess_cmd(se_cmd); } - break; - case ISCSI_OP_REJECT: - /* - * Handle special case for REJECT when iscsi_add_reject*() has - * overwritten the original iscsi_opcode assignment, and the - * associated cmd->se_cmd needs to be released. - */ - if (cmd->se_cmd.se_tfo != NULL) { - se_cmd = &cmd->se_cmd; - __iscsit_free_cmd(cmd, shutdown); - - rc = transport_generic_free_cmd(&cmd->se_cmd, shutdown); - if (!rc && shutdown && se_cmd->se_sess) { - __iscsit_free_cmd(cmd, shutdown); - target_put_sess_cmd(se_cmd); - } - break; - } - /* Fall-through */ - default: - __iscsit_free_cmd(cmd, shutdown); + } else { iscsit_release_cmd(cmd); - break; } } EXPORT_SYMBOL(iscsit_free_cmd);