From patchwork Thu May 4 20:17:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Butterfield X-Patchwork-Id: 9712655 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3FD5260362 for ; Thu, 4 May 2017 20:17:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 350C428691 for ; Thu, 4 May 2017 20:17:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 262D5286A9; Thu, 4 May 2017 20:17:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B811528691 for ; Thu, 4 May 2017 20:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbdEDURr (ORCPT ); Thu, 4 May 2017 16:17:47 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:34622 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdEDURq (ORCPT ); Thu, 4 May 2017 16:17:46 -0400 Received: by mail-it0-f67.google.com with SMTP id c26so3011198itd.1 for ; Thu, 04 May 2017 13:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Mr2fnFJgJed78YjakaEpGLH6o/3ixvvZGlWhMy0KhXg=; b=oOdaKgm9Szxm96343gzuej7Xes+wWHg2wPB5+GBoxKq5ey/IdVkrVAJFvpFcwBVbjG cD43zyD9cyCFMocJhPoepfHX2CDXVIAG7oLg43zOF8UT1kVl74+ji36kCJag/NUaCn/O J9XCUC9sDZXRxpH1um6PXsamFH1OwGRFy4GeSfhqdAqau7MzbE8LvMbwwjkTbAcgWCIt xB+Sc1mXJRHkvAEeJtWTKtVqrnGCPaRKgFfvqZILYm9lAgDstbyeTHPfAGeDu1nypdkB fYDYNdFEBymtxJUKkIxjoiRCAXQpB2odEQBVcW8Jnw2YpY+4lgUfakWNuTmv0BWK9q5t xgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Mr2fnFJgJed78YjakaEpGLH6o/3ixvvZGlWhMy0KhXg=; b=lDJYeXlAjc59zq0VKJD1UXdxTpimorGqro9wIz7EbErvM/L5PRhOZd48hqf1Usqilt V5uYs8JwovccynMwJFcc6DKVtXPKg5xllTfX5cFKA+M5VRk+QLKr3G+5s3taXkKW49zP jn2oYLi7BaBzcRe6uPpJ9sm7YW8+BkZDJH/FEIVrRyNOAqhmYKku9mn1vjHgXtYSNhWI f1Jx9LAmm6MtuDmYWum/yBrczHvKdKAymyl2F6pAYYm6m/X9wxflMXqK2eqEW8AOP0ZC UMW+nLA8+9IVPst+jetayBoHZmodfSQIPvUibL8ZbK9CIQ/JEK37a0DHeSw0NIemk1/Q RSNg== X-Gm-Message-State: AN3rC/5LdCX8Q0x37XG7asP3qK/vP3QM0kjo6Fg/a2na2oQN4gRXR1vA dn/iDM3eIm/zj5K/ X-Received: by 10.36.57.68 with SMTP id l65mr4625162ita.101.1493929065503; Thu, 04 May 2017 13:17:45 -0700 (PDT) Received: from localhost.localdomain (c-73-181-28-74.hsd1.co.comcast.net. [73.181.28.74]) by smtp.gmail.com with ESMTPSA id c82sm11120266ioe.62.2017.05.04.13.17.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 May 2017 13:17:44 -0700 (PDT) From: David Butterfield To: target-devel@vger.kernel.org Cc: David Butterfield Subject: [PATCH] improve some error logging in rbd.c Date: Thu, 4 May 2017 14:17:27 -0600 Message-Id: <20170504201728.25807-1-dab21774@gmail.com> X-Mailer: git-send-email 2.12.2.575.gb14f27f Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: David Butterfield --- rbd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rbd.c b/rbd.c index 8f78e54..852338d 100644 --- a/rbd.c +++ b/rbd.c @@ -427,18 +427,20 @@ static int tcmu_rbd_open(struct tcmu_device *dev) pool = strtok(config, "/"); if (!pool) { + tcmu_dev_err(dev, "Could not get pool name\n"); ret = -EINVAL; goto free_state; } state->pool_name = strdup(pool); if (!state->pool_name) { ret = -ENOMEM; - tcmu_dev_err(dev, "Could copy pool name\n"); + tcmu_dev_err(dev, "Could not copy pool name\n"); goto free_state; } name = strtok(NULL, "/"); if (!name) { + tcmu_dev_err(dev, "Could not get image name\n"); ret = -EINVAL; goto free_state; } @@ -446,7 +448,7 @@ static int tcmu_rbd_open(struct tcmu_device *dev) state->image_name = strdup(name); if (!state->image_name) { ret = -ENOMEM; - tcmu_dev_err(dev, "Could copy image name\n"); + tcmu_dev_err(dev, "Could not copy image name\n"); goto free_state; }