| Message ID | 20170511101616.19790-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Making target_parse_xcopy_cmd static fixes sparse warning: > > "warning: symbol 'target_parse_xcopy_cmd' was not declared. Should > it be static?" > > Fixes: 1bd05294519f76 ("target/iscsi: Fix a deadlock between the XCOPY code and session shutdown") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/target/target_core_xcopy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c > index aecb36d955f0..00e0269e6be4 100644 > --- a/drivers/target/target_core_xcopy.c > +++ b/drivers/target/target_core_xcopy.c > @@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work) > * Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing > * fails. > */ > -sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) > +static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) > { > struct se_cmd *se_cmd = xop->xop_se_cmd; > unsigned char *p = NULL, *seg_desc; Hello Colin, Thanks for the patch. I will merge it in patch "target/iscsi: Fix a deadlock between the XCOPY code and session shutdown". Bart.
On 11/05/17 14:55, Bart Van Assche wrote: > On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Making target_parse_xcopy_cmd static fixes sparse warning: >> >> "warning: symbol 'target_parse_xcopy_cmd' was not declared. Should >> it be static?" >> >> Fixes: 1bd05294519f76 ("target/iscsi: Fix a deadlock between the XCOPY code and session shutdown") >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/target/target_core_xcopy.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c >> index aecb36d955f0..00e0269e6be4 100644 >> --- a/drivers/target/target_core_xcopy.c >> +++ b/drivers/target/target_core_xcopy.c >> @@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work) >> * Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing >> * fails. >> */ >> -sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) >> +static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) >> { >> struct se_cmd *se_cmd = xop->xop_se_cmd; >> unsigned char *p = NULL, *seg_desc; > > Hello Colin, > > Thanks for the patch. I will merge it in patch "target/iscsi: Fix a deadlock between the > XCOPY code and session shutdown". > > Bart. > Thanks, sounds good to me. Colin -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c index aecb36d955f0..00e0269e6be4 100644 --- a/drivers/target/target_core_xcopy.c +++ b/drivers/target/target_core_xcopy.c @@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work) * Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing * fails. */ -sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) +static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) { struct se_cmd *se_cmd = xop->xop_se_cmd; unsigned char *p = NULL, *seg_desc;